[jira] [Resolved] (HBASE-27535) Separate slowlog thresholds for scans vs other requests

2023-04-21 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-27535. -- Fix Version/s: 2.6.0 3.0.0-alpha-4 Hadoop Flags: Reviewed

[jira] [Resolved] (HBASE-27536) Include more request information in slowlog for Scans

2023-04-21 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-27536. -- Fix Version/s: 2.6.0 3.0.0-alpha-4 Hadoop Flags: Reviewed

[jira] [Assigned] (HBASE-27536) Include more request information in slowlog for Scans

2023-04-21 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-27536: Assignee: Ray Mattingly > Include more request information in slowlog for Scans >

[jira] [Commented] (HBASE-27536) Include more request information in slowlog for Scans

2023-04-21 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715221#comment-17715221 ] Viraj Jasani commented on HBASE-27536: -- Closing this Jira. Thanks [~rmdmattingly] for the

[GitHub] [hbase] virajjasani commented on pull request #5188: HBASE-27535: Separate slowlog thresholds for scans vs other requests

2023-04-21 Thread via GitHub
virajjasani commented on PR #5188: URL: https://github.com/apache/hbase/pull/5188#issuecomment-1518503210 Thanks @rmdmattingly and @bbeaudreault !! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] virajjasani merged pull request #5188: HBASE-27535: Separate slowlog thresholds for scans vs other requests

2023-04-21 Thread via GitHub
virajjasani merged PR #5188: URL: https://github.com/apache/hbase/pull/5188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #5188: HBASE-27535: Separate slowlog thresholds for scans vs other requests

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5188: URL: https://github.com/apache/hbase/pull/5188#issuecomment-1518494579 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s |

[jira] [Comment Edited] (HBASE-27788) Skip family comparing when compare cells inner the store

2023-04-21 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712226#comment-17712226 ] Zheng Wang edited comment on HBASE-27788 at 4/22/23 3:34 AM: - Test Env:

[GitHub] [hbase] bsglz commented on pull request #5171: HBASE-27788 Skip family comparing when compare cells inner the store

2023-04-21 Thread via GitHub
bsglz commented on PR #5171: URL: https://github.com/apache/hbase/pull/5171#issuecomment-1518476388 Test code: ``` /* * Copyright (c) 2014, Oracle America, Inc. * All rights reserved. * * Redistribution and use in source and binary forms, with or without *

[GitHub] [hbase] Apache-HBase commented on pull request #5188: HBASE-27535: Separate slowlog thresholds for scans vs other requests

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5188: URL: https://github.com/apache/hbase/pull/5188#issuecomment-1518471533 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 21s |

[GitHub] [hbase] bbeaudreault commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s

2023-04-21 Thread via GitHub
bbeaudreault commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1518440268 i dont have time to handle merging right now, but will try to do it in the next couple days. thanks! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on pull request #5197: HBASE-27809 Attach move replication queue storage from zookeeper to a separated HBase table design doc to git repo

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5197: URL: https://github.com/apache/hbase/pull/5197#issuecomment-1518435960 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 57s |

[GitHub] [hbase] Apache-HBase commented on pull request #5197: HBASE-27809 Attach move replication queue storage from zookeeper to a separated HBase table design doc to git repo

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5197: URL: https://github.com/apache/hbase/pull/5197#issuecomment-1518435406 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s |

[GitHub] [hbase] Apache-HBase commented on pull request #5197: HBASE-27809 Attach move replication queue storage from zookeeper to a separated HBase table design doc to git repo

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5197: URL: https://github.com/apache/hbase/pull/5197#issuecomment-1518435276 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s |

[GitHub] [hbase] Apache-HBase commented on pull request #5188: HBASE-27535: Separate slowlog thresholds for scans vs other requests

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5188: URL: https://github.com/apache/hbase/pull/5188#issuecomment-1518387847 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 49s |

[GitHub] [hbase] Apache-HBase commented on pull request #5188: HBASE-27535: Separate slowlog thresholds for scans vs other requests

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5188: URL: https://github.com/apache/hbase/pull/5188#issuecomment-1518342925 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s |

[GitHub] [hbase] Apache-HBase commented on pull request #5188: HBASE-27535: Separate slowlog thresholds for scans vs other requests

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5188: URL: https://github.com/apache/hbase/pull/5188#issuecomment-1518282093 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] Apache-HBase commented on pull request #5195: HBASE-27806 Support dynamic reinitializing replication peer storage

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5195: URL: https://github.com/apache/hbase/pull/5195#issuecomment-151890 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[GitHub] [hbase] Apache-HBase commented on pull request #5195: HBASE-27806 Support dynamic reinitializing replication peer storage

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5195: URL: https://github.com/apache/hbase/pull/5195#issuecomment-1518206734 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] Apache-HBase commented on pull request #5188: HBASE-27535: Separate slowlog thresholds for scans vs other requests

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5188: URL: https://github.com/apache/hbase/pull/5188#issuecomment-1518102828 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5188: HBASE-27535: Separate slowlog thresholds for scans vs other requests

2023-04-21 Thread via GitHub
bbeaudreault commented on code in PR #5188: URL: https://github.com/apache/hbase/pull/5188#discussion_r1173963970 ## src/main/asciidoc/_chapters/ops_mgt.adoc: ## @@ -1904,14 +1904,20 @@ It is also prepended with identifying tags `(responseTooSlow)`, `(responseTooLar

[GitHub] [hbase] Apache-HBase commented on pull request #5197: HBASE-27809 Attach move replication queue storage from zookeeper to a separated HBase table design doc to git repo

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5197: URL: https://github.com/apache/hbase/pull/5197#issuecomment-1518065806 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s |

[GitHub] [hbase] Apache-HBase commented on pull request #5197: HBASE-27809 Attach move replication queue storage from zookeeper to a separated HBase table design doc to git repo

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5197: URL: https://github.com/apache/hbase/pull/5197#issuecomment-1518064004 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s |

[GitHub] [hbase] Apache-HBase commented on pull request #5197: HBASE-27809 Attach move replication queue storage from zookeeper to a separated HBase table design doc to git repo

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5197: URL: https://github.com/apache/hbase/pull/5197#issuecomment-1518063803 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s |

[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1518054219 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s |

[GitHub] [hbase] 2005hithlj opened a new pull request, #5197: HBASE-27809 Attach move replication queue storage from zookeeper to a separated HBase table design doc to git repo

2023-04-21 Thread via GitHub
2005hithlj opened a new pull request, #5197: URL: https://github.com/apache/hbase/pull/5197 https://issues.apache.org/jira/browse/HBASE-27809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1518030776 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1518030132 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s |

[GitHub] [hbase] Apache-HBase commented on pull request #5195: HBASE-27806 Support dynamic reinitializing replication peer storage

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5195: URL: https://github.com/apache/hbase/pull/5195#issuecomment-1518023218 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

[jira] [Created] (HBASE-27809) Attach move replication queue storage from zookeeper to a separated HBase table design doc to git repo

2023-04-21 Thread Liangjun He (Jira)
Liangjun He created HBASE-27809: --- Summary: Attach move replication queue storage from zookeeper to a separated HBase table design doc to git repo Key: HBASE-27809 URL:

[jira] [Created] (HBASE-27808) Change flatten mode for oss in our pom file

2023-04-21 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-27808: - Summary: Change flatten mode for oss in our pom file Key: HBASE-27808 URL: https://issues.apache.org/jira/browse/HBASE-27808 Project: HBase Issue Type:

[GitHub] [hbase] wchevreuil commented on a diff in pull request #5194: HBASE-27752: Update the block cache and list of prefetched files upon region movement

2023-04-21 Thread via GitHub
wchevreuil commented on code in PR #5194: URL: https://github.com/apache/hbase/pull/5194#discussion_r1173851733 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/CloseRegionHandler.java: ## @@ -101,6 +105,19 @@ public void process() throws IOException {

[GitHub] [hbase] Apache-HBase commented on pull request #5195: HBASE-27806 Support dynamic reinitializing replication peer storage

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5195: URL: https://github.com/apache/hbase/pull/5195#issuecomment-1517953579 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

[GitHub] [hbase] Apache-HBase commented on pull request #5195: HBASE-27806 Support dynamic reinitializing replication peer storage

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5195: URL: https://github.com/apache/hbase/pull/5195#issuecomment-1517929157 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s |

[GitHub] [hbase] bbeaudreault commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s

2023-04-21 Thread via GitHub
bbeaudreault commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1517902202 @rmdmattingly can you fix the javac warnings? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (HBASE-27785) Encapsulate and centralize totalBufferUsed in ReplicationSourceManager

2023-04-21 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-27785: - Resolution: Fixed Status: Resolved (was: Patch Available) > Encapsulate and centralize

[jira] [Updated] (HBASE-27785) Encapsulate and centralize totalBufferUsed in ReplicationSourceManager

2023-04-21 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-27785: - Fix Version/s: 2.6.0 3.0.0-alpha-4 > Encapsulate and centralize totalBufferUsed in

[jira] [Commented] (HBASE-27785) Encapsulate and centralize totalBufferUsed in ReplicationSourceManager

2023-04-21 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715018#comment-17715018 ] chenglei commented on HBASE-27785: -- Pushed to 2.6+, thanks [~zhangduo] for reviewing! > Encapsulate

[GitHub] [hbase] comnetwork merged pull request #5196: HBASE-27785 Encapsulate and centralize totalBufferUsed in Replication…

2023-04-21 Thread via GitHub
comnetwork merged PR #5196: URL: https://github.com/apache/hbase/pull/5196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] comnetwork opened a new pull request, #5196: HBASE-27785 Encapsulate and centralize totalBufferUsed in Replication…

2023-04-21 Thread via GitHub
comnetwork opened a new pull request, #5196: URL: https://github.com/apache/hbase/pull/5196 …SourceManager -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [hbase] Apache9 commented on a diff in pull request #5195: HBASE-27806 Support dynamic reinitializing replication peer storage

2023-04-21 Thread via GitHub
Apache9 commented on code in PR #5195: URL: https://github.com/apache/hbase/pull/5195#discussion_r1173783821 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java: ## @@ -67,15 +68,18 @@ /** * Manages and performs all

[GitHub] [hbase] 2005hithlj commented on a diff in pull request #5195: HBASE-27806 Support dynamic reinitializing replication peer storage

2023-04-21 Thread via GitHub
2005hithlj commented on code in PR #5195: URL: https://github.com/apache/hbase/pull/5195#discussion_r1173706346 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java: ## @@ -67,15 +68,18 @@ /** * Manages and performs all

[GitHub] [hbase] comnetwork merged pull request #5168: HBASE-27785 Encapsulate and centralize totalBufferUsed in Replication…

2023-04-21 Thread via GitHub
comnetwork merged PR #5168: URL: https://github.com/apache/hbase/pull/5168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] comnetwork commented on a diff in pull request #5168: HBASE-27785 Encapsulate and centralize totalBufferUsed in Replication…

2023-04-21 Thread via GitHub
comnetwork commented on code in PR #5168: URL: https://github.com/apache/hbase/pull/5168#discussion_r1173738044 ## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java: ## @@ -366,20 +352,17 @@ void clearWALEntryBatch() {

[GitHub] [hbase] Apache-HBase commented on pull request #5195: HBASE-27806 Support dynamic reinitializing replication peer storage

2023-04-21 Thread via GitHub
Apache-HBase commented on PR #5195: URL: https://github.com/apache/hbase/pull/5195#issuecomment-1517701821 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

[GitHub] [hbase] Apache9 commented on a diff in pull request #5189: HBASE-27746 Check if the file system supports storage policy before invoking setStoragePolicy()

2023-04-21 Thread via GitHub
Apache9 commented on code in PR #5189: URL: https://github.com/apache/hbase/pull/5189#discussion_r1173627795 ## hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java: ## @@ -415,8 +417,9 @@ public void testSetStoragePolicyDefault() throws Exception { *

[jira] [Commented] (HBASE-27807) PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario

2023-04-21 Thread haosen chen (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714867#comment-17714867 ] haosen chen commented on HBASE-27807: - Available patch is uploaded. >

[jira] [Updated] (HBASE-27807) PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario

2023-04-21 Thread haosen chen (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] haosen chen updated HBASE-27807: Attachment: 0001-HBASE-27807-PressureAwareCompactionThroughputControl.patch >

[jira] [Updated] (HBASE-27807) PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario

2023-04-21 Thread haosen chen (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] haosen chen updated HBASE-27807: Attachment: image-2023-04-21-14-28-19-766.png > PressureAwareCompactionThroughputController#tune

[jira] [Updated] (HBASE-27807) PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario

2023-04-21 Thread haosen chen (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] haosen chen updated HBASE-27807: Description: In

[jira] [Updated] (HBASE-27807) PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario

2023-04-21 Thread haosen chen (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] haosen chen updated HBASE-27807: Description: In

[jira] [Created] (HBASE-27807) PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario

2023-04-21 Thread haosen chen (Jira)
haosen chen created HBASE-27807: --- Summary: PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario Key: HBASE-27807 URL: https://issues.apache.org/jira/browse/HBASE-27807