[GitHub] [hbase] virajjasani commented on a diff in pull request #5295: HBASE-27902 New async admin api to invoke coproc on multiple servers

2023-06-19 Thread via GitHub
virajjasani commented on code in PR #5295: URL: https://github.com/apache/hbase/pull/5295#discussion_r1234627180 ## hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestInterfaceAlign.java: ## @@ -56,6 +56,7 @@ public void testAdminWithAsyncAdmin() {

[GitHub] [hbase] virajjasani commented on a diff in pull request #5266: HBASE-27902 New async admin api to invoke coproc on multiple servers

2023-06-19 Thread via GitHub
virajjasani commented on code in PR #5266: URL: https://github.com/apache/hbase/pull/5266#discussion_r1234622903 ## hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestInterfaceAlign.java: ## @@ -58,6 +58,7 @@ public void testAdminWithAsyncAdmin() {

[GitHub] [hbase] Apache-HBase commented on pull request #5295: HBASE-27902 New async admin api to invoke coproc on multiple servers

2023-06-19 Thread via GitHub
Apache-HBase commented on PR #5295: URL: https://github.com/apache/hbase/pull/5295#issuecomment-1597908095 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 28s |

[GitHub] [hbase] Apache-HBase commented on pull request #5295: HBASE-27902 New async admin api to invoke coproc on multiple servers

2023-06-19 Thread via GitHub
Apache-HBase commented on PR #5295: URL: https://github.com/apache/hbase/pull/5295#issuecomment-1597907183 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s |

[GitHub] [hbase] Apache-HBase commented on pull request #5295: HBASE-27902 New async admin api to invoke coproc on multiple servers

2023-06-19 Thread via GitHub
Apache-HBase commented on PR #5295: URL: https://github.com/apache/hbase/pull/5295#issuecomment-1597906562 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s |

[GitHub] [hbase] Apache-HBase commented on pull request #5266: HBASE-27902 New async admin api to invoke coproc on multiple servers

2023-06-19 Thread via GitHub
Apache-HBase commented on PR #5266: URL: https://github.com/apache/hbase/pull/5266#issuecomment-1597884987 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 20s |

[GitHub] [hbase] Apache-HBase commented on pull request #5266: HBASE-27902 New async admin api to invoke coproc on multiple servers

2023-06-19 Thread via GitHub
Apache-HBase commented on PR #5266: URL: https://github.com/apache/hbase/pull/5266#issuecomment-1597882650 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

[GitHub] [hbase] Apache-HBase commented on pull request #5266: HBASE-27902 New async admin api to invoke coproc on multiple servers

2023-06-19 Thread via GitHub
Apache-HBase commented on PR #5266: URL: https://github.com/apache/hbase/pull/5266#issuecomment-1597882094 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 49s |

[GitHub] [hbase] Apache-HBase commented on pull request #5300: HBASE-27936 NPE in StoreFileReader.passesGeneralRowPrefixBloomFilter()

2023-06-19 Thread via GitHub
Apache-HBase commented on PR #5300: URL: https://github.com/apache/hbase/pull/5300#issuecomment-1597682425 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s |

[GitHub] [hbase] Apache-HBase commented on pull request #5300: HBASE-27936 NPE in StoreFileReader.passesGeneralRowPrefixBloomFilter()

2023-06-19 Thread via GitHub
Apache-HBase commented on PR #5300: URL: https://github.com/apache/hbase/pull/5300#issuecomment-1597665736 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

[jira] [Commented] (HBASE-27904) A random data generator tool leveraging bulk load.

2023-06-19 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17734386#comment-17734386 ] Viraj Jasani commented on HBASE-27904: -- To provide additional context, for this Jira, master PR

[jira] [Commented] (HBASE-27904) A random data generator tool leveraging bulk load.

2023-06-19 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17734383#comment-17734383 ] Viraj Jasani commented on HBASE-27904: -- FYI [~zhangduo], I see that for master PR, we don't have

[GitHub] [hbase] virajjasani commented on pull request #5295: HBASE-27902 New async admin api to invoke coproc on multiple servers

2023-06-19 Thread via GitHub
virajjasani commented on PR #5295: URL: https://github.com/apache/hbase/pull/5295#issuecomment-1597478507 Alright, as long as we have IA#Public API for this, it is fine, no problem with having new class: AsyncAdminClientUtils as IA.Public -- This is an automated message from the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #5300: HBASE-27936 NPE in StoreFileReader.passesGeneralRowPrefixBloomFilter()

2023-06-19 Thread via GitHub
Apache-HBase commented on PR #5300: URL: https://github.com/apache/hbase/pull/5300#issuecomment-1597447322 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s |

[jira] [Created] (HBASE-27941) Possible memory leak in MemStoreLAB implementation

2023-06-19 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-27941: - Summary: Possible memory leak in MemStoreLAB implementation Key: HBASE-27941 URL: https://issues.apache.org/jira/browse/HBASE-27941 Project: HBase Issue Type: Bug

[jira] [Commented] (HBASE-27941) Possible memory leak in MemStoreLAB implementation

2023-06-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17734261#comment-17734261 ] Duo Zhang commented on HBASE-27941: --- [~heliangjun] FYI. > Possible memory leak in MemStoreLAB

[GitHub] [hbase] Apache9 opened a new pull request, #5300: HBASE-27936 NPE in StoreFileReader.passesGeneralRowPrefixBloomFilter()

2023-06-19 Thread via GitHub
Apache9 opened a new pull request, #5300: URL: https://github.com/apache/hbase/pull/5300 Need to also copy bloomFilterMetrics in StoreFileReader.copyFields -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (HBASE-27936) NPE in StoreFileReader.passesGeneralRowPrefixBloomFilter()

2023-06-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17734255#comment-17734255 ] Duo Zhang commented on HBASE-27936: --- I think a problem is that, in HBASE_27421, we introduced a new

[jira] [Commented] (HBASE-27936) NPE in StoreFileReader.passesGeneralRowPrefixBloomFilter()

2023-06-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17734225#comment-17734225 ] Duo Zhang commented on HBASE-27936: --- {code} BloomFilter bloomFilter = this.generalBloomFilter;

[jira] [Updated] (HBASE-27829) Introduce build for `kuttl` image, basis for dev/test environment

2023-06-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-27829: - Resolution: Fixed Status: Resolved (was: Patch Available) Thanks [~psomogyi],

[jira] [Commented] (HBASE-27904) A random data generator tool leveraging bulk load.

2023-06-19 Thread Himanshu Gwalani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17734189#comment-17734189 ] Himanshu Gwalani commented on HBASE-27904: -- The build for this PR was green:  1.

[GitHub] [hbase-kustomize] ndimiduk merged pull request #3: HBASE-27829 Introduce build for kuttl image, basis for dev/test environment

2023-06-19 Thread via GitHub
ndimiduk merged PR #3: URL: https://github.com/apache/hbase-kustomize/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase-kustomize] Apache-HBase commented on pull request #3: HBASE-27829 Introduce build for kuttl image, basis for dev/test environment

2023-06-19 Thread via GitHub
Apache-HBase commented on PR #3: URL: https://github.com/apache/hbase-kustomize/pull/3#issuecomment-1597192273 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hbase-kustomize] Apache-HBase commented on pull request #3: HBASE-27829 Introduce build for kuttl image, basis for dev/test environment

2023-06-19 Thread via GitHub
Apache-HBase commented on PR #3: URL: https://github.com/apache/hbase-kustomize/pull/3#issuecomment-1597119915 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hbase-kustomize] busbey commented on a diff in pull request #3: HBASE-27829 Introduce build for kuttl image, basis for dev/test environment

2023-06-19 Thread via GitHub
busbey commented on code in PR #3: URL: https://github.com/apache/hbase-kustomize/pull/3#discussion_r1233987657 ## dockerfiles/kuttl/README.md: ## @@ -0,0 +1,71 @@ + + +# dockerfiles/kuttl + +This directory builds a docker image containing everything required to run

[GitHub] [hbase-kustomize] Apache-HBase commented on pull request #3: HBASE-27829 Introduce build for kuttl image, basis for dev/test environment

2023-06-19 Thread via GitHub
Apache-HBase commented on PR #3: URL: https://github.com/apache/hbase-kustomize/pull/3#issuecomment-1597098135 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hbase-kustomize] ndimiduk commented on pull request #3: HBASE-27829 Introduce build for kuttl image, basis for dev/test environment

2023-06-19 Thread via GitHub
ndimiduk commented on PR #3: URL: https://github.com/apache/hbase-kustomize/pull/3#issuecomment-1597021154 The hadolint complaint is invalid, seems it was fixed in 2.11.0, ``` % docker container run --rm -i hadolint/hadolint:v2.11.0 < dockerfiles/kuttl/Dockerfile % ``` --

[GitHub] [hbase-kustomize] Apache-HBase commented on pull request #3: HBASE-27829 Introduce build for kuttl image, basis for dev/test environment

2023-06-19 Thread via GitHub
Apache-HBase commented on PR #3: URL: https://github.com/apache/hbase-kustomize/pull/3#issuecomment-1597004342 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hbase-kustomize] Apache-HBase commented on pull request #4: HBASE-27935 Introduce Jenkins PR job for hbase-kustomize (addendum)

2023-06-19 Thread via GitHub
Apache-HBase commented on PR #4: URL: https://github.com/apache/hbase-kustomize/pull/4#issuecomment-1596995212 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hbase-kustomize] Apache-HBase commented on pull request #4: HBASE-27935 Introduce Jenkins PR job for hbase-kustomize (addendum)

2023-06-19 Thread via GitHub
Apache-HBase commented on PR #4: URL: https://github.com/apache/hbase-kustomize/pull/4#issuecomment-1596993726 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hbase-kustomize] ndimiduk commented on a diff in pull request #3: HBASE-27829 Introduce build for kuttl image, basis for dev/test environment

2023-06-19 Thread via GitHub
ndimiduk commented on code in PR #3: URL: https://github.com/apache/hbase-kustomize/pull/3#discussion_r1233884551 ## dockerfiles/kuttl/README.md: ## @@ -0,0 +1,71 @@ + + +# dockerfiles/kuttl + +This directory builds a docker image containing everything required to run

[jira] [Commented] (HBASE-27888) Record readBlock message in log when it takes too long time

2023-06-19 Thread chaijunjie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17734056#comment-17734056 ] chaijunjie commented on HBASE-27888: [~zhangduo] Thanks for reviewing, I filled the  release note.

[jira] [Updated] (HBASE-27888) Record readBlock message in log when it takes too long time

2023-06-19 Thread chaijunjie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chaijunjie updated HBASE-27888: --- Release Note: Add a configuration parameter,which control to record read block slow in logs.