Re: [PR] HBASE-25549 Provide a switch that allows avoiding reopening all regions when modifying a table to prevent RIT storms [hbase]

2023-11-30 Thread via GitHub
Apache-HBase commented on PR #5549: URL: https://github.com/apache/hbase/pull/5549#issuecomment-1835612728 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s |

[jira] [Commented] (HBASE-27998) Enhance region metrics to include prefetch ratio for each region

2023-11-30 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791910#comment-17791910 ] Hudson commented on HBASE-27998: Results for branch branch-2 [build #934 on

[jira] [Commented] (HBASE-27999) Implement cache aware load balancer

2023-11-30 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791911#comment-17791911 ] Hudson commented on HBASE-27999: Results for branch branch-2 [build #934 on

[jira] [Commented] (HBASE-28204) Canary can take lot more time If any region (except the first region) starts with delete markers

2023-11-30 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791900#comment-17791900 ] Viraj Jasani commented on HBASE-28204: -- FYI [~bbeaudreault], we have seen a bit of perf regression

[jira] [Reopened] (HBASE-28204) Canary can take lot more time If any region (except the first region) starts with delete markers

2023-11-30 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reopened HBASE-28204: -- Reopening for revert. > Canary can take lot more time If any region (except the first region)

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2023-11-30 Thread via GitHub
virajjasani commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1411603477 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DualFileStoreEngine.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (HBASE-27999) Implement cache aware load balancer

2023-11-30 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791894#comment-17791894 ] Hudson commented on HBASE-27999: Results for branch branch-2.6 [build #3 on

[jira] [Commented] (HBASE-27998) Enhance region metrics to include prefetch ratio for each region

2023-11-30 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791893#comment-17791893 ] Hudson commented on HBASE-27998: Results for branch branch-2.6 [build #3 on

Re: [PR] HBASE-28150 CreateTableProcedure and DeleteTableProcedure should slee… [hbase]

2023-11-30 Thread via GitHub
bbeaudreault commented on code in PR #5502: URL: https://github.com/apache/hbase/pull/5502#discussion_r1411477104 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DeleteTableProcedure.java: ## @@ -133,7 +137,13 @@ protected Flow executeFromState(final

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2023-11-30 Thread via GitHub
bbeaudreault commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1411474153 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DualFileStoreEngine.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28222 Leak in ExportSnapshot during verifySnapshot on S3A [hbase]

2023-11-30 Thread via GitHub
Apache-HBase commented on PR #5554: URL: https://github.com/apache/hbase/pull/5554#issuecomment-1835119503 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s |

Re: [PR] HBASE-28222 Leak in ExportSnapshot during verifySnapshot on S3A [hbase]

2023-11-30 Thread via GitHub
Apache-HBase commented on PR #5554: URL: https://github.com/apache/hbase/pull/5554#issuecomment-1835101760 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-30 Thread via GitHub
bbeaudreault commented on code in PR #5534: URL: https://github.com/apache/hbase/pull/5534#discussion_r1411456292 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java: ## @@ -53,6 +54,16 @@ public class

Re: [PR] HBASE-28222 Leak in ExportSnapshot during verifySnapshot on S3A [hbase]

2023-11-30 Thread via GitHub
Apache-HBase commented on PR #5554: URL: https://github.com/apache/hbase/pull/5554#issuecomment-1835054200 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

[jira] [Commented] (HBASE-28222) Leak in ExportSnapshot during verifySnapshot on S3A

2023-11-30 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791815#comment-17791815 ] Bryan Beaudreault commented on HBASE-28222: --- I've spent a lot of time (too much) thinking

[jira] [Commented] (HBASE-28031) TestClusterScopeQuotaThrottle is still failing with broken WAL writer

2023-11-30 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791809#comment-17791809 ] Bryan Beaudreault commented on HBASE-28031: --- I'm actually not sure that exception is the

Re: [PR] HBASE-28187 NPE when flushing a non-existing column family [hbase]

2023-11-30 Thread via GitHub
Apache-HBase commented on PR #5553: URL: https://github.com/apache/hbase/pull/5553#issuecomment-1834624938 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

Re: [PR] HBASE-28187 NPE when flushing a non-existing column family [hbase]

2023-11-30 Thread via GitHub
Apache-HBase commented on PR #5553: URL: https://github.com/apache/hbase/pull/5553#issuecomment-1834559484 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

[jira] [Comment Edited] (HBASE-25714) Offload the compaction job to independent Compaction Server

2023-11-30 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791761#comment-17791761 ] Andrew Kyle Purtell edited comment on HBASE-25714 at 11/30/23 9:02 PM:

Re: [PR] HBASE-28226 Add logic to check for RegionStateNode null pointer in FlushRegionProcedure [hbase]

2023-11-30 Thread via GitHub
Apache-HBase commented on PR #5548: URL: https://github.com/apache/hbase/pull/5548#issuecomment-1834530562 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2023-11-30 Thread via GitHub
kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1411228804 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java: ## @@ -135,11 +136,17 @@ public static List

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2023-11-30 Thread via GitHub
kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1411227263 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DualFileStoreEngine.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Comment Edited] (HBASE-25714) Offload the compaction job to independent Compaction Server

2023-11-30 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791761#comment-17791761 ] Andrew Kyle Purtell edited comment on HBASE-25714 at 11/30/23 8:25 PM:

[jira] [Comment Edited] (HBASE-25714) Offload the compaction job to independent Compaction Server

2023-11-30 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791761#comment-17791761 ] Andrew Kyle Purtell edited comment on HBASE-25714 at 11/30/23 8:24 PM:

[jira] [Updated] (HBASE-28230) Update branch-2 version to 2.7-SNAPSHOT

2023-11-30 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-28230: -- Fix Version/s: 2.7.0 Resolution: Fixed Status: Resolved (was: Patch

Re: [PR] HBASE-28230 Update branch-2 version to 2.7-SNAPSHOT [hbase]

2023-11-30 Thread via GitHub
bbeaudreault merged PR #5552: URL: https://github.com/apache/hbase/pull/5552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (HBASE-25714) Offload the compaction job to independent Compaction Server

2023-11-30 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791761#comment-17791761 ] Andrew Kyle Purtell edited comment on HBASE-25714 at 11/30/23 8:19 PM:

[jira] [Commented] (HBASE-25714) Offload the compaction job to independent Compaction Server

2023-11-30 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791761#comment-17791761 ] Andrew Kyle Purtell commented on HBASE-25714: - [~vjasani] [~niuyulin] I spent a couple of

Re: [PR] HBASE-28226 Add logic to check for RegionStateNode null pointer in FlushRegionProcedure [hbase]

2023-11-30 Thread via GitHub
Apache-HBase commented on PR #5548: URL: https://github.com/apache/hbase/pull/5548#issuecomment-1834470931 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

[jira] [Commented] (HBASE-25714) Offload the compaction job to independent Compaction Server

2023-11-30 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791724#comment-17791724 ] Viraj Jasani commented on HBASE-25714: -- [~niuyulin] looks like the feature branch has not had much

Re: [PR] HBASE-28187 NPE when flushing a non-existing column family [hbase]

2023-11-30 Thread via GitHub
Apache-HBase commented on PR #5553: URL: https://github.com/apache/hbase/pull/5553#issuecomment-1834259769 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s |

Re: [PR] HBASE-28226 Add logic to check for RegionStateNode null pointer in FlushRegionProcedure [hbase]

2023-11-30 Thread via GitHub
Apache-HBase commented on PR #5548: URL: https://github.com/apache/hbase/pull/5548#issuecomment-1834080249 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 11s |

[jira] [Commented] (HBASE-27891) Report heap used by BucketCache as a jmx metric

2023-11-30 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791688#comment-17791688 ] Bryan Beaudreault commented on HBASE-27891: --- Hey [~wchevreuil]. We aren't working on it right

Re: [PR] HBASE-28226 Add logic to check for RegionStateNode null pointer in FlushRegionProcedure [hbase]

2023-11-30 Thread via GitHub
hiping-tech commented on code in PR #5548: URL: https://github.com/apache/hbase/pull/5548#discussion_r1410852935 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/FlushRegionProcedure.java: ## @@ -88,6 +81,12 @@ protected Procedure[]

[jira] [Updated] (HBASE-28186) Rebase CacheAwareBalance related commits into master branch

2023-11-30 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-28186: - Affects Version/s: 2.5.6 2.4.17

[jira] [Resolved] (HBASE-28186) Rebase CacheAwareBalance related commits into master branch

2023-11-30 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-28186. -- Resolution: Fixed Thanks for helping with the backport to branch-2,

[jira] [Updated] (HBASE-28186) Rebase CacheAwareBalance related commits into master branch

2023-11-30 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-28186: - Fix Version/s: 2.7.0 2.6.0 3.0.0-beta-1

Re: [PR] HBASE-28186 Rebase CacheAwareBalance related commits [hbase]

2023-11-30 Thread via GitHub
wchevreuil merged PR #5551: URL: https://github.com/apache/hbase/pull/5551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-11-30 Thread via GitHub
zhuyaogai commented on PR #5507: URL: https://github.com/apache/hbase/pull/5507#issuecomment-1833879957 Gentle ping @Apache9 If u have time, could u help review this? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (HBASE-27891) Report heap used by BucketCache as a jmx metric

2023-11-30 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791650#comment-17791650 ] Wellington Chevreuil commented on HBASE-27891: -- Are you guys currently working on this,

Re: [PR] HBASE-28150 CreateTableProcedure and DeleteTableProcedure should slee… [hbase]

2023-11-30 Thread via GitHub
Apache9 commented on code in PR #5502: URL: https://github.com/apache/hbase/pull/5502#discussion_r1410702906 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DeleteTableProcedure.java: ## @@ -133,7 +137,13 @@ protected Flow executeFromState(final

Re: [PR] HBASE-28186 Rebase CacheAwareBalance related commits [hbase]

2023-11-30 Thread via GitHub
Apache-HBase commented on PR #5551: URL: https://github.com/apache/hbase/pull/5551#issuecomment-1833810024 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28186 Rebase CacheAwareBalance related commits [hbase]

2023-11-30 Thread via GitHub
Apache-HBase commented on PR #5551: URL: https://github.com/apache/hbase/pull/5551#issuecomment-1833788618 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 15s |

[jira] [Commented] (HBASE-28031) TestClusterScopeQuotaThrottle is still failing with broken WAL writer

2023-11-30 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791625#comment-17791625 ] Bryan Beaudreault commented on HBASE-28031: --- I will take a look. I don't use ClusterQuota,

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2023-11-30 Thread via GitHub
wchevreuil commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1410561791 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DualFileStoreEngine.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (HBASE-28227) Tables to which Stripe Compaction policy is applied cannot be forced to trigger Major Compaction.

2023-11-30 Thread longping_jie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791575#comment-17791575 ] longping_jie commented on HBASE-28227: -- [~zhangduo] I'm willing to try it, but I need some time to

Re: [PR] HBASE-25549 Provide a switch that allows avoiding reopening all regions when modifying a table to prevent RIT storms [hbase]

2023-11-30 Thread via GitHub
gourabtaparia commented on PR #5549: URL: https://github.com/apache/hbase/pull/5549#issuecomment-1833548614 @GeorryHuang @bbeaudreault Looks like few of the unrelated unit tests are failing here. How should we move ahead here ? Should i submit a dummy change to retrigger the runs ? Or is

Re: [PR] HBASE-28220 Split the queueCallTime, processCallTime and totalCallTime according to queue type when using RWQueueRpcExecutor [hbase]

2023-11-30 Thread via GitHub
wchevreuil commented on code in PR #5550: URL: https://github.com/apache/hbase/pull/5550#discussion_r1410479230 ## hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcCall.java: ## @@ -132,4 +132,24 @@ public interface RpcCall extends RpcCallContext { /** Returns A

Re: [PR] HBASE-28186 Rebase CacheAwareBalance related commits [hbase]

2023-11-30 Thread via GitHub
Apache-HBase commented on PR #5551: URL: https://github.com/apache/hbase/pull/5551#issuecomment-1833464409 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

[jira] [Assigned] (HBASE-28238) rsrpcservice should perform the updateConfiguration operation to priority @QosPriority(priority = HConstants.ADMIN_QOS)

2023-11-30 Thread selina.yan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] selina.yan reassigned HBASE-28238: -- Assignee: selina.yan > rsrpcservice should perform the updateConfiguration operation to

[jira] [Created] (HBASE-28238) rsrpcservice should perform the updateConfiguration operation to priority @QosPriority(priority = HConstants.ADMIN_QOS)

2023-11-30 Thread selina.yan (Jira)
selina.yan created HBASE-28238: -- Summary: rsrpcservice should perform the updateConfiguration operation to priority @QosPriority(priority = HConstants.ADMIN_QOS) Key: HBASE-28238 URL:

[jira] [Commented] (HBASE-28211) BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated

2023-11-30 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791502#comment-17791502 ] Hudson commented on HBASE-28211: Results for branch master [build #954 on

Re: [PR] HBASE-28215: region reopen procedure batching/throttling [hbase]

2023-11-30 Thread via GitHub
Apache-HBase commented on PR #5534: URL: https://github.com/apache/hbase/pull/5534#issuecomment-1833307409 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |