Re: [PR] HBASE-28238 rpcservice should perform some important admin operation to priority ADMIN_QOS [hbase]

2023-12-11 Thread via GitHub
Kerasone commented on code in PR #5558: URL: https://github.com/apache/hbase/pull/5558#discussion_r1423336549 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java: ## Review Comment: ok,thanks. -- This is an automated message from the

[jira] [Commented] (HBASE-28190) Add slow sync log rolling test in TestAsyncLogRolling

2023-12-11 Thread zhuyaogai (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795568#comment-17795568 ] zhuyaogai commented on HBASE-28190: --- [~zhangduo] Okay, I will finish it as soon as possible. > Add

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2023-12-11 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-1851096467 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2023-12-11 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-1851083879 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28253: HBCK2 filesystem command to fix version file fails when Master in not up. [hbase-operator-tools]

2023-12-11 Thread via GitHub
robin7roy commented on PR #139: URL: https://github.com/apache/hbase-operator-tools/pull/139#issuecomment-1850937685 > There's already a `-s|--skip` option in hbck2 for skipping the check (see

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2023-12-11 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-1850841141 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28241 Fixed the check for an ongoing Snapshot before proceeding with the merge region operation. [hbase]

2023-12-11 Thread via GitHub
Apache-HBase commented on PR #5560: URL: https://github.com/apache/hbase/pull/5560#issuecomment-1850565146 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

Re: [PR] HBASE-28241 Fixed the check for an ongoing Snapshot before proceeding with the merge region operation. [hbase]

2023-12-11 Thread via GitHub
Apache-HBase commented on PR #5560: URL: https://github.com/apache/hbase/pull/5560#issuecomment-1850533799 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

[jira] [Commented] (HBASE-28190) Add slow sync log rolling test in TestAsyncLogRolling

2023-12-11 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795410#comment-17795410 ] Duo Zhang commented on HBASE-28190: --- [~zhuyaogai] Please open a PR against branch-2? The PR for master

[jira] [Updated] (HBASE-28254) Flaky test: TestTableShell

2023-12-11 Thread Andor Molnar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar updated HBASE-28254: - Description: The test is running the following Ruby commands: {noformat} # Instert test data

Re: [PR] HBASE-28190 Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-12-11 Thread via GitHub
Apache9 merged PR #5507: URL: https://github.com/apache/hbase/pull/5507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HBASE-28190) Add slow sync log rolling test in TestAsyncLogRolling

2023-12-11 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28190: -- Component/s: test > Add slow sync log rolling test in TestAsyncLogRolling >

[jira] [Created] (HBASE-28254) Flaky test: TestTableShell

2023-12-11 Thread Andor Molnar (Jira)
Andor Molnar created HBASE-28254: Summary: Flaky test: TestTableShell Key: HBASE-28254 URL: https://issues.apache.org/jira/browse/HBASE-28254 Project: HBase Issue Type: Test

Re: [PR] HBASE-28241 Fixed the check for an ongoing Snapshot before proceeding with the merge region operation. [hbase]

2023-12-11 Thread via GitHub
Apache-HBase commented on PR #5560: URL: https://github.com/apache/hbase/pull/5560#issuecomment-1850138051 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-28190 Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-12-11 Thread via GitHub
Apache9 commented on PR #5507: URL: https://github.com/apache/hbase/pull/5507#issuecomment-1850083564 TestZooKeeper is known to be flaky sometimes in pre commit. TestRollbackSCP is tracked by #5563 Let me merge. -- This is an automated message from the Apache Git Service.

Re: [PR] HBASE-28190 Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-12-11 Thread via GitHub
Apache-HBase commented on PR #5507: URL: https://github.com/apache/hbase/pull/5507#issuecomment-1850076030 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-28190 Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-12-11 Thread via GitHub
Apache-HBase commented on PR #5507: URL: https://github.com/apache/hbase/pull/5507#issuecomment-1850062454 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

Re: [PR] HBASE-28243 Bump jackson version to 2.15.2 [hbase]

2023-12-11 Thread via GitHub
Apache-HBase commented on PR #5562: URL: https://github.com/apache/hbase/pull/5562#issuecomment-1849997140 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 35s |

Re: [PR] HBASE-28243 Bump jackson version to 2.15.2 [hbase]

2023-12-11 Thread via GitHub
Apache-HBase commented on PR #5562: URL: https://github.com/apache/hbase/pull/5562#issuecomment-1849898083 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

[jira] [Resolved] (HBASE-28251) [SFT] Add description for specifying SFT impl during snapshot recovery

2023-12-11 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-28251. -- Resolution: Fixed Merged into master branch. Thanks for reviewing this,

[jira] [Updated] (HBASE-28251) [SFT] Add description for specifying SFT impl during snapshot recovery

2023-12-11 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-28251: - Fix Version/s: 4.0.0-alpha-1 > [SFT] Add description for specifying SFT impl

[jira] [Updated] (HBASE-28251) [SFT] Add description for specifying SFT impl during snapshot recovery

2023-12-11 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-28251: - Affects Version/s: 4.0.0-alpha-1 > [SFT] Add description for specifying SFT

Re: [PR] HBASE-28251 [SFT] Add description for specifying SFT impl during snapshot recovery [hbase]

2023-12-11 Thread via GitHub
wchevreuil merged PR #5570: URL: https://github.com/apache/hbase/pull/5570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28190 Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-12-11 Thread via GitHub
Apache-HBase commented on PR #5507: URL: https://github.com/apache/hbase/pull/5507#issuecomment-1849682483 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 26s |

Re: [PR] HBASE-28190 Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-12-11 Thread via GitHub
zhuyaogai commented on code in PR #5507: URL: https://github.com/apache/hbase/pull/5507#discussion_r1422130655 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestLogRolling.java: ## @@ -74,6 +82,12 @@ public abstract class AbstractTestLogRolling

Re: [PR] HBASE-28190 Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-12-11 Thread via GitHub
Apache9 commented on code in PR #5507: URL: https://github.com/apache/hbase/pull/5507#discussion_r1422083189 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestLogRolling.java: ## @@ -74,6 +82,12 @@ public abstract class AbstractTestLogRolling {