Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5775: URL: https://github.com/apache/hbase/pull/5775#issuecomment-2019310980 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 43s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
virajjasani commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1538525120 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,23 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
Apache9 commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1538516753 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,23 @@ public void regionServerReport(ServerName sn, ServerMetrics sl)

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5775: URL: https://github.com/apache/hbase/pull/5775#issuecomment-2019280912 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5775: URL: https://github.com/apache/hbase/pull/5775#issuecomment-2019259781 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2019254850 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
virajjasani commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1538494129 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,23 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5775: URL: https://github.com/apache/hbase/pull/5775#issuecomment-2019242072 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 57s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
bbeaudreault commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1538470996 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,23 @@ public void regionServerReport(ServerName sn,

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2019212143 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2019199580 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5775: URL: https://github.com/apache/hbase/pull/5775#issuecomment-201899 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 29s |

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5772: URL: https://github.com/apache/hbase/pull/5772#issuecomment-2018987203 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[jira] [Commented] (HBASE-28456) HBase Restore restores old data if data for the same timestamp is in different hfiles

2024-03-25 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830714#comment-17830714 ] Bryan Beaudreault commented on HBASE-28456: --- Yea I’m working on the 2.6.0 now, so reporting

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5772: URL: https://github.com/apache/hbase/pull/5772#issuecomment-2018973711 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 27s |

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2018963880 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

[jira] [Commented] (HBASE-28456) HBase Restore restores old data if data for the same timestamp is in different hfiles

2024-03-25 Thread Ruben Van Wanzeele (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830710#comment-17830710 ] Ruben Van Wanzeele commented on HBASE-28456: Hi Bryan, I'll test if the fix also fixes the

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5772: URL: https://github.com/apache/hbase/pull/5772#issuecomment-2018954446 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[jira] [Commented] (HBASE-28456) HBase Restore restores old data if data for the same timestamp is in different hfiles

2024-03-25 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830708#comment-17830708 ] Bryan Beaudreault commented on HBASE-28456: --- I've pushed a PR which resolves this issue:

[jira] [Updated] (HBASE-28456) HBase Restore restores old data if data for the same timestamp is in different hfiles

2024-03-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28456: --- Labels: pull-request-available (was: ) > HBase Restore restores old data if data for the

[PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-25 Thread via GitHub
bbeaudreault opened a new pull request, #5775: URL: https://github.com/apache/hbase/pull/5775 - Unifies _SeqId_ handling - Adds necessary config in MapReduceHFileSplliter so that sorting can include sequenceId - Updates HFileInputFormat to handle sequenceIds of bulkloaded files. This

[jira] [Resolved] (HBASE-28449) Fix BackupSystemTable Scans

2024-03-25 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault resolved HBASE-28449. --- Fix Version/s: 2.6.0 3.0.0-beta-2 Resolution: Fixed

[jira] [Resolved] (HBASE-28453) Support a middle ground between the Average and Fixed interval rate limiters

2024-03-25 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault resolved HBASE-28453. --- Fix Version/s: 2.6.0 3.0.0-beta-2 Release Note:

Re: [PR] HBASE-28449 - fix backupSystemTable prefix scans [hbase]

2024-03-25 Thread via GitHub
bbeaudreault merged PR #5768: URL: https://github.com/apache/hbase/pull/5768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28453 FixedIntervalRateLimiter support for a shorter refill interval [hbase]

2024-03-25 Thread via GitHub
bbeaudreault merged PR #5773: URL: https://github.com/apache/hbase/pull/5773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (HBASE-28456) HBase Restore restores old data if data for the same timestamp is in different hfiles

2024-03-25 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830637#comment-17830637 ] Bryan Beaudreault edited comment on HBASE-28456 at 3/25/24 6:47 PM:

[jira] [Assigned] (HBASE-28456) HBase Restore restores old data if data for the same timestamp is in different hfiles

2024-03-25 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault reassigned HBASE-28456: - Assignee: Bryan Beaudreault > HBase Restore restores old data if data for the

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2018643204 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

[jira] [Commented] (HBASE-28456) HBase Restore restores old data if data for the same timestamp is in different hfiles

2024-03-25 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830637#comment-17830637 ] Bryan Beaudreault commented on HBASE-28456: --- Ok I figured this out – there are 2 things going

[jira] [Updated] (HBASE-28456) HBase Restore restores old data if data for the same timestamp is in different hfiles

2024-03-25 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-28456: -- Priority: Blocker (was: Critical) > HBase Restore restores old data if data for the

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2018612244 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s |

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5772: URL: https://github.com/apache/hbase/pull/5772#issuecomment-2018608695 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

Re: [PR] HBASE-28449 - fix backupSystemTable prefix scans [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5768: URL: https://github.com/apache/hbase/pull/5768#issuecomment-2018424121 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28449 - fix backupSystemTable prefix scans [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5768: URL: https://github.com/apache/hbase/pull/5768#issuecomment-2018422885 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28449 - fix backupSystemTable prefix scans [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5768: URL: https://github.com/apache/hbase/pull/5768#issuecomment-2018422433 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s |

Re: [PR] HBASE-28449 - fix backupSystemTable prefix scans [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5768: URL: https://github.com/apache/hbase/pull/5768#issuecomment-2018411087 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2018348042 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 25s |

Re: [PR] HBASE-28449 - fix backupSystemTable prefix scans [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5768: URL: https://github.com/apache/hbase/pull/5768#issuecomment-2018220994 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 15s |

Re: [PR] HBASE-28449 - fix backupSystemTable prefix scans [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5768: URL: https://github.com/apache/hbase/pull/5768#issuecomment-2018214956 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28449 - fix backupSystemTable prefix scans [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5768: URL: https://github.com/apache/hbase/pull/5768#issuecomment-2018216063 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

Re: [PR] HBASE-28449 - fix backupSystemTable prefix scans [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5768: URL: https://github.com/apache/hbase/pull/5768#issuecomment-2018205291 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 24s |

Re: [PR] HBASE-28449 - fix backupSystemTable prefix scans [hbase]

2024-03-25 Thread via GitHub
briaugenreich commented on PR #5768: URL: https://github.com/apache/hbase/pull/5768#issuecomment-2018137695 I tweaked the existing test to verify the changes here. When the fix is not implemented we get double the expected results due to the scan matching the prefix incorrectly. cc

[jira] [Commented] (HBASE-28420) Aborting Active HMaster is not rejecting remote Procedure Reports

2024-03-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830495#comment-17830495 ] Duo Zhang commented on HBASE-28420: --- [~umesh9414] Do you have any plans here? If no clear solution

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-03-25 Thread via GitHub
wchevreuil commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1537538033 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -295,10 +302,23 @@ private void readStoreFile(Path storeFilePath, throws

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2017903345 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28436 Use connection url to specify the connection registry inf… [hbase]

2024-03-25 Thread via GitHub
Apache9 commented on PR #5770: URL: https://github.com/apache/hbase/pull/5770#issuecomment-2017744432 Ping @ndimiduk . Could you please take a look at this? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2017678393 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2017644363 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2017617328 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2017319464 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 49s |