Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-03-26 Thread via GitHub
kabhishek4 commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1540512005 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -295,10 +302,23 @@ private void readStoreFile(Path storeFilePath, throws

[jira] [Commented] (HBASE-28449) Fix BackupSystemTable Scans

2024-03-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831165#comment-17831165 ] Hudson commented on HBASE-28449: Results for branch branch-2.6 [build #82 on

[jira] [Commented] (HBASE-28456) HBase Restore restores old data if data for the same timestamp is in different hfiles

2024-03-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831166#comment-17831166 ] Hudson commented on HBASE-28456: Results for branch branch-2.6 [build #82 on

[jira] [Commented] (HBASE-28453) Support a middle ground between the Average and Fixed interval rate limiters

2024-03-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831164#comment-17831164 ] Hudson commented on HBASE-28453: Results for branch branch-2.6 [build #82 on

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5771: URL: https://github.com/apache/hbase/pull/5771#issuecomment-2021933581 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s |

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5771: URL: https://github.com/apache/hbase/pull/5771#issuecomment-2021923461 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s |

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-03-26 Thread via GitHub
mihir6692 commented on PR #5780: URL: https://github.com/apache/hbase/pull/5780#issuecomment-2021921186 Test failure in `TestBlockEvictionOnRegionMovement` is not related. I ran this test multiple times in local and it doesn't fail. -- This is an automated message from the Apache Git

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-26 Thread via GitHub
apurtell commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1540422199 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,23 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5771: URL: https://github.com/apache/hbase/pull/5771#issuecomment-2021860840 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s |

Re: [PR] HBASE-27315 Add timeout to JavaRegexEngine [hbase]

2024-03-26 Thread via GitHub
mwkang commented on code in PR #4720: URL: https://github.com/apache/hbase/pull/4720#discussion_r1540375136 ## hbase-client/src/main/java/org/apache/hadoop/hbase/filter/RegexStringComparator.java: ## @@ -255,11 +258,20 @@ static interface Engine { * This is the default

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5780: URL: https://github.com/apache/hbase/pull/5780#issuecomment-2021802269 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5780: URL: https://github.com/apache/hbase/pull/5780#issuecomment-2021800157 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-27986 Null Pointer Exception when running testLruBlockCache with a misconfiguration [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5779: URL: https://github.com/apache/hbase/pull/5779#issuecomment-2021721812 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59s |

Re: [PR] HBASE-27986 Null Pointer Exception when running testLruBlockCache with a misconfiguration [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5779: URL: https://github.com/apache/hbase/pull/5779#issuecomment-2021712358 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-27986 Null Pointer Exception when running testLruBlockCache with a misconfiguration [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5779: URL: https://github.com/apache/hbase/pull/5779#issuecomment-2021637515 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5771: URL: https://github.com/apache/hbase/pull/5771#issuecomment-2021626531 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5780: URL: https://github.com/apache/hbase/pull/5780#issuecomment-2021603545 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

[jira] [Updated] (HBASE-27931) Update hadoop.version to 3.3.6

2024-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-27931: --- Labels: pull-request-available (was: ) > Update hadoop.version to 3.3.6 >

Re: [PR] HBASE-27931. [DO NOT MERGE] Update hadoop.version to 3.3.6 [hbase]

2024-03-26 Thread via GitHub
jojochuang closed pull request #5289: HBASE-27931. [DO NOT MERGE] Update hadoop.version to 3.3.6 URL: https://github.com/apache/hbase/pull/5289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (HBASE-25920) Support Hadoop 3.3.1

2024-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-25920: --- Labels: pull-request-available (was: ) > Support Hadoop 3.3.1 > > >

Re: [PR] HBASE-25920 WIP. Test patch for Hadoop 3.3.1 support [hbase]

2024-03-26 Thread via GitHub
jojochuang closed pull request #3310: HBASE-25920 WIP. Test patch for Hadoop 3.3.1 support URL: https://github.com/apache/hbase/pull/3310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HBASE-28452: Missing null check of rpcServer.scheduler.executor causes NPE with invalid value of hbase.client.default.rpc.codec [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5778: URL: https://github.com/apache/hbase/pull/5778#issuecomment-2021593916 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s |

Re: [PR] HBASE-28452: Missing null check of rpcServer.scheduler.executor causes NPE with invalid value of hbase.client.default.rpc.codec [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5778: URL: https://github.com/apache/hbase/pull/5778#issuecomment-2021574910 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-03-26 Thread via GitHub
mihir6692 commented on PR #5772: URL: https://github.com/apache/hbase/pull/5772#issuecomment-2021561414 PR for branch-2 and branch-2.x https://github.com/apache/hbase/pull/5780 (It only required one manual change, using `org.apache.hadoop.hbase.StartMiniClusterOption` in branch-2 in

Re: [PR] HBASE-28452: Missing null check of rpcServer.scheduler.executor causes NPE with invalid value of hbase.client.default.rpc.codec [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5778: URL: https://github.com/apache/hbase/pull/5778#issuecomment-2021557546 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28458 BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5777: URL: https://github.com/apache/hbase/pull/5777#issuecomment-2021527640 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

[jira] [Commented] (HBASE-28453) Support a middle ground between the Average and Fixed interval rate limiters

2024-03-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831083#comment-17831083 ] Hudson commented on HBASE-28453: Results for branch master [build #1037 on

[jira] [Commented] (HBASE-28449) Fix BackupSystemTable Scans

2024-03-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831084#comment-17831084 ] Hudson commented on HBASE-28449: Results for branch master [build #1037 on

Re: [PR] HBASE-28443 Return too slow when scanning a table with non-existing REGION_REPLICA_ID [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5767: URL: https://github.com/apache/hbase/pull/5767#issuecomment-2021477976 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-03-26 Thread via GitHub
mihir6692 commented on code in PR #5772: URL: https://github.com/apache/hbase/pull/5772#discussion_r1540072864 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/http/hbck/resource/HbckMetricsResource.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software

Re: [PR] HBASE-28443 Return too slow when scanning a table with non-existing REGION_REPLICA_ID [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5767: URL: https://github.com/apache/hbase/pull/5767#issuecomment-2021413168 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28458 BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5777: URL: https://github.com/apache/hbase/pull/5777#issuecomment-2021400781 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28458 BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5777: URL: https://github.com/apache/hbase/pull/5777#issuecomment-2021387643 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28443 Return too slow when scanning a table with non-existing REGION_REPLICA_ID [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5767: URL: https://github.com/apache/hbase/pull/5767#issuecomment-2021372824 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

[jira] [Commented] (HBASE-28449) Fix BackupSystemTable Scans

2024-03-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831062#comment-17831062 ] Hudson commented on HBASE-28449: Results for branch branch-3 [build #172 on

[jira] [Commented] (HBASE-28453) Support a middle ground between the Average and Fixed interval rate limiters

2024-03-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831061#comment-17831061 ] Hudson commented on HBASE-28453: Results for branch branch-3 [build #172 on

Re: [PR] HBASE-27986 Null Pointer Exception when running testLruBlockCache with a misconfiguration [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5779: URL: https://github.com/apache/hbase/pull/5779#issuecomment-2021324202 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2021266305 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

[jira] [Updated] (HBASE-27986) Null Pointer Exception when running testLruBlockCache with a misconfiguration

2024-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-27986: --- Labels: pull-request-available (was: ) > Null Pointer Exception when running

[PR] HBASE-27986 Null Pointer Exception when running testLruBlockCache with a misconfiguration [hbase]

2024-03-26 Thread via GitHub
teamconfx opened a new pull request, #5779: URL: https://github.com/apache/hbase/pull/5779 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] HBASE-28452: Missing null check of rpcServer.scheduler.executor causes NPE with invalid value of hbase.client.default.rpc.codec [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5778: URL: https://github.com/apache/hbase/pull/5778#issuecomment-2021227320 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s |

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2021200540 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s |

[jira] [Resolved] (HBASE-28412) Restoring incremental backups to mapped table requires existence of original table

2024-03-26 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault resolved HBASE-28412. --- Fix Version/s: 2.6.0 3.0.0-beta-2 Resolution: Fixed

[jira] [Updated] (HBASE-28412) Restoring incremental backups to mapped table requires existence of original table

2024-03-26 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-28412: -- Affects Version/s: (was: 2.6.0) (was: 4.0.0-alpha-1) >

[jira] [Assigned] (HBASE-28412) Restoring incremental backups to mapped table requires existence of original table

2024-03-26 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault reassigned HBASE-28412: - Assignee: Ruben Van Wanzeele > Restoring incremental backups to mapped table

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2021177590 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

[jira] [Updated] (HBASE-28452) Missing null check of rpcServer.scheduler.executor causes NPE with invalid value of hbase.client.default.rpc.codec

2024-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28452: --- Labels: pull-request-available (was: ) > Missing null check of

[jira] [Updated] (HBASE-26192) Master UI hbck should provide a JSON formatted output option

2024-03-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26192: Fix Version/s: (was: 2.4.18) > Master UI hbck should provide a JSON formatted

[jira] [Updated] (HBASE-26192) Master UI hbck should provide a JSON formatted output option

2024-03-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26192: Fix Version/s: 2.4.18 2.7.0 2.6.1

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-03-26 Thread via GitHub
apurtell commented on code in PR #5772: URL: https://github.com/apache/hbase/pull/5772#discussion_r1539849184 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/http/hbck/resource/HbckMetricsResource.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-03-26 Thread via GitHub
apurtell commented on code in PR #5772: URL: https://github.com/apache/hbase/pull/5772#discussion_r1539849184 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/http/hbck/resource/HbckMetricsResource.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-03-26 Thread via GitHub
apurtell commented on code in PR #5772: URL: https://github.com/apache/hbase/pull/5772#discussion_r1539847142 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/http/hbck/HbckConfigFactory.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-03-26 Thread via GitHub
apurtell closed pull request #4470: HBASE-26192 Master UI hbck should provide a JSON formatted output option URL: https://github.com/apache/hbase/pull/4470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5775: URL: https://github.com/apache/hbase/pull/5775#issuecomment-2021138268 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5775: URL: https://github.com/apache/hbase/pull/5775#issuecomment-2021131115 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2021115402 Pre-commit looks good. There is 1 checkstyle issue. Branch permissions don't allow me to commit to this PR, so I'm going to cherry-pick it rather than merge. Closing this and

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
bbeaudreault closed pull request #5776: HBASE-28412 Select correct target table for incremental backup URL: https://github.com/apache/hbase/pull/5776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5775: URL: https://github.com/apache/hbase/pull/5775#issuecomment-2021108682 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2021094695 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2021093977 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2021082313 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2021066328 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2021002223 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s |

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020995259 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020972463 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s |

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020970457 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s |

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
rubenvw-ngdata commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539650301 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/BackupTestUtil.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
rubenvw-ngdata commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539649431 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -18,6 +18,7 @@ package

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539624430 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -18,6 +18,7 @@ package org.apache.hadoop.hbase.backup;

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539621891 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/BackupTestUtil.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] HBASE-28458 BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5777: URL: https://github.com/apache/hbase/pull/5777#issuecomment-2020878066 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
rubenvw-ngdata commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539574336 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
rubenvw-ngdata commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539479695 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

Re: [PR] HBASE-28443 Return too slow when scanning a table with non-existing REGION_REPLICA_ID [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5767: URL: https://github.com/apache/hbase/pull/5767#issuecomment-2020830781 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539531767 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539518711 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

[PR] HBASE-28458 BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached [hbase]

2024-03-26 Thread via GitHub
wchevreuil opened a new pull request, #5777: URL: https://github.com/apache/hbase/pull/5777 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Updated] (HBASE-28458) BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached

2024-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28458: --- Labels: pull-request-available (was: ) > BucketCache.notifyFileCachingCompleted may

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
rubenvw-ngdata commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539479695 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (HBASE-28458) BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached

2024-03-26 Thread Wellington Chevreuil (Jira)
Wellington Chevreuil created HBASE-28458: Summary: BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached Key: HBASE-28458 URL:

Re: [PR] HBASE-28443 Return too slow when scanning a table with non-existing REGION_REPLICA_ID [hbase]

2024-03-26 Thread via GitHub
guluo2016 commented on PR #5767: URL: https://github.com/apache/hbase/pull/5767#issuecomment-2020729857 > I think we should try to check the replica id when we hit the RegionOfflineException, like what we have done in AsyncRpcRetryingCaller. Thanks for your good suggestion, the

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539470479 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539449576 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
rubenvw-ngdata commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539447876 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (HBASE-28456) HBase Restore restores old data if data for the same timestamp is in different hfiles

2024-03-26 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830972#comment-17830972 ] Bryan Beaudreault commented on HBASE-28456: --- Pushed to branch-2.6+. Thanks [~rubenvw] for

[jira] [Updated] (HBASE-28456) HBase Restore restores old data if data for the same timestamp is in different hfiles

2024-03-26 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-28456: -- Affects Version/s: (was: 2.6.0) (was: 3.0.0) > HBase

[jira] [Resolved] (HBASE-28456) HBase Restore restores old data if data for the same timestamp is in different hfiles

2024-03-26 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault resolved HBASE-28456. --- Fix Version/s: 2.6.0 3.0.0-beta-2 Resolution: Fixed >

[jira] [Commented] (HBASE-27826) Region split and merge time while offline is O(n) with respect to number of store files

2024-03-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830966#comment-17830966 ] Duo Zhang commented on HBASE-27826: --- Filed HBASE-28457, for adding the version field. > Region split

[jira] [Updated] (HBASE-28457) Introduce a version field in file based tracker record

2024-03-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28457: -- Component/s: HFile > Introduce a version field in file based tracker record >

[jira] [Created] (HBASE-28457) Introduce a version field in file based tracker record

2024-03-26 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-28457: - Summary: Introduce a version field in file based tracker record Key: HBASE-28457 URL: https://issues.apache.org/jira/browse/HBASE-28457 Project: HBase Issue Type:

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
bbeaudreault merged PR #5775: URL: https://github.com/apache/hbase/pull/5775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2020592593 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s |

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5775: URL: https://github.com/apache/hbase/pull/5775#discussion_r1539365245 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileInputFormat.java: ## @@ -109,6 +114,9 @@ public boolean nextKeyValue() throws IOException,

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
Apache9 commented on code in PR #5775: URL: https://github.com/apache/hbase/pull/5775#discussion_r1539339492 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,262 @@ +/* + * Licensed to the Apache Software

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5775: URL: https://github.com/apache/hbase/pull/5775#issuecomment-2020514083 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
ndimiduk commented on code in PR #5775: URL: https://github.com/apache/hbase/pull/5775#discussion_r1539260241 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -165,7 +165,7 @@ protected static byte[] combineTableNameSuffix(byte[]

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-26 Thread via GitHub
wchevreuil commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2020453022 The UT flakeyness is actually a bug in the BucketCache.notifyFileCachingCompleted logic. The UT needs to be changed as well to consistently reproduce the issue, so I will address it in

Re: [PR] HBASE-27315 Add timeout to JavaRegexEngine [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #4720: URL: https://github.com/apache/hbase/pull/4720#issuecomment-2020447314 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s |

Re: [PR] HBASE-27315 Add timeout to JavaRegexEngine [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #4720: URL: https://github.com/apache/hbase/pull/4720#issuecomment-2020434957 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s |

Re: [PR] HBASE-27315 Add timeout to JavaRegexEngine [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #4720: URL: https://github.com/apache/hbase/pull/4720#issuecomment-2020425262 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

  1   2   >