[jira] [Commented] (HBASE-28591) Backport HBASE-26123 Restore fields dropped by HBASE-25986 to public interfaces

2024-05-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846497#comment-17846497 ] Andrew Kyle Purtell commented on HBASE-28591: - [~szucsvillo] We are only releasing 2.5 and

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-14 Thread via GitHub
apurtell commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2111577285 @Apache9 I think there was only one issue considered a blocker and @kadirozde has addressed it. There are three failing tests in the precommit but all are related to quotas so are

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-14 Thread via GitHub
Apache9 commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111493641 > > Here you just submit the async zk operation in the timer task, and then in the callback, you check reschedule the timer task and then you have a chance to check timeout, but what if

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-14 Thread via GitHub
Apache9 commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2111480245 Ping @q977734161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5899: URL: https://github.com/apache/hbase/pull/5899#issuecomment-218325 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5899: URL: https://github.com/apache/hbase/pull/5899#issuecomment-213972 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5899: URL: https://github.com/apache/hbase/pull/5899#issuecomment-2111084483 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
gvprathyusha6 closed pull request #5898: HBASE-27938 - PE load any custom implementation of tests at runtime URL: https://github.com/apache/hbase/pull/5898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HBASE-26625 ExportSnapshot tool failed to copy data files for tables with merge region [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5897: URL: https://github.com/apache/hbase/pull/5897#issuecomment-2110988251 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-26625 ExportSnapshot tool failed to copy data files for tables with merge region [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5897: URL: https://github.com/apache/hbase/pull/5897#issuecomment-2110968811 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
virajjasani commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2110922431 @gvprathyusha6 could you also create branch-2 PR? we can merge both of them together and backport as required. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-14 Thread via GitHub
virajjasani commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2110914019 > Here you just submit the async zk operation in the timer task, and then in the callback, you check reschedule the timer task and then you have a chance to check timeout, but what if

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2110679307 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2110679226 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2110675983 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2110656423 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-26625 ExportSnapshot tool failed to copy data files for tables with merge region [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5897: URL: https://github.com/apache/hbase/pull/5897#issuecomment-2110593995 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

[jira] [Updated] (HBASE-26625) ExportSnapshot tool failed to copy data files for tables with merge region

2024-05-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-26625: --- Labels: pull-request-available (was: ) > ExportSnapshot tool failed to copy data files for

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-14 Thread via GitHub
Apache9 commented on code in PR #5837: URL: https://github.com/apache/hbase/pull/5837#discussion_r1599917696 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncMetaRegionLocator.java: ## @@ -25,6 +25,7 @@ import java.util.concurrent.CompletableFuture; import

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2110053326 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2110045600 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2110041594 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-14 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2110040484 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16s |

Re: [PR] HBASE-25880 remove files from filesCompacting when clear compaction queue [hbase]

2024-05-14 Thread via GitHub
frostruan commented on PR #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-2109960909 > Thanks @frostruan. I don't have any other feedback here, I just saw that it stalled. > > If you have time to finish it, that'd be great. If not I can ask someone at my company

Re: [PR] HBASE-25880 remove files from filesCompacting when clear compaction queue [hbase]

2024-05-14 Thread via GitHub
bbeaudreault commented on PR #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-2109932196 Thanks @frostruan. I don't have any other feedback here, I just saw that it stalled. If you have time to finish it, that'd be great. If not I can ask someone at my company to

Re: [PR] HBASE-25880 remove files from filesCompacting when clear compaction queue [hbase]

2024-05-14 Thread via GitHub
frostruan commented on PR #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-2109777296 @bbeaudreault This PR has some conflicts with the master branch. I can fix PR if you need. And if you have new or more ideas, it's completely ok for me to close this PR and you can