[jira] [Commented] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin

2018-11-28 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702659#comment-16702659 ] Reid Chan commented on HBASE-21481: --- Fixed TestRpcAccessChecks initialization problems. Other failed

[jira] [Updated] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin

2018-11-28 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21481: -- Attachment: HBASE-21481.master.007.patch > [acl] Superuser's permissions should not be granted or

[jira] [Commented] (HBASE-21521) Expose master startup status via JMX and web UI

2018-11-28 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702632#comment-16702632 ] Reid Chan commented on HBASE-21521: --- +1 for the idea. > Expose master startup status via JMX and web

[jira] [Commented] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin

2018-11-28 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701747#comment-16701747 ] Reid Chan commented on HBASE-21481: --- v6 addressed some of comments in RB. > [acl] Superuser's

[jira] [Updated] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin

2018-11-28 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21481: -- Attachment: HBASE-21481.master.006.patch > [acl] Superuser's permissions should not be granted or

[jira] [Commented] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin

2018-11-27 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701327#comment-16701327 ] Reid Chan commented on HBASE-21481: --- Yes, passed locally. {{TestRpcAccessChecks.setup:141 »

[jira] [Comment Edited] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin

2018-11-26 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699883#comment-16699883 ] Reid Chan edited comment on HBASE-21481 at 11/27/18 4:40 AM: - It's a

[jira] [Commented] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin

2018-11-26 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699883#comment-16699883 ] Reid Chan commented on HBASE-21481: --- It's a non-trivial patch i think, need +1 from team member.

[jira] [Updated] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin

2018-11-26 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21481: -- Attachment: HBASE-21481.master.005.patch > [acl] Superuser's permissions should not be granted or

[jira] [Commented] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin

2018-11-21 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694722#comment-16694722 ] Reid Chan commented on HBASE-21481: --- ping [~stack], would you mind taking a look, if having free

[jira] [Commented] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin

2018-11-21 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694704#comment-16694704 ] Reid Chan commented on HBASE-21481: --- v4 fixed checkstyle warning > [acl] Superuser's permissions

[jira] [Updated] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin

2018-11-21 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21481: -- Attachment: HBASE-21481.master.004.patch > [acl] Superuser's permissions should not be granted or

[jira] [Updated] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin

2018-11-21 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21481: -- Attachment: HBASE-21481.master.003.patch > [acl] Superuser's permissions should not be granted or

[jira] [Commented] (HBASE-21154) Remove hbase:namespace table; fold it into hbase:meta

2018-11-19 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692759#comment-16692759 ] Reid Chan commented on HBASE-21154: --- {quote}ACL keeps cache of namespace names? The watcher triggers

[jira] [Updated] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin

2018-11-18 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21481: -- Attachment: HBASE-21481.master.002.patch > [acl] Superuser's permissions should not be granted or

[jira] [Updated] (HBASE-21489) TestShell is broken

2018-11-17 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21489: -- Resolution: Fixed Status: Resolved (was: Patch Available) > TestShell is broken >

[jira] [Commented] (HBASE-21489) TestShell is broken

2018-11-17 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690792#comment-16690792 ] Reid Chan commented on HBASE-21489: --- Thanks for the review. Let me push it to branch-2 and master

[jira] [Comment Edited] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin

2018-11-16 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690391#comment-16690391 ] Reid Chan edited comment on HBASE-21481 at 11/17/18 5:45 AM: - * Add a check

[jira] [Commented] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin

2018-11-16 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690391#comment-16690391 ] Reid Chan commented on HBASE-21481: --- * Add a check on target user/group where he is a superuser or a

[jira] [Updated] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin

2018-11-16 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21481: -- Attachment: HBASE-21481.master.001.patch > [acl] Superuser's permissions should not be granted or

[jira] [Commented] (HBASE-21489) TestShell is broken

2018-11-16 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690386#comment-16690386 ] Reid Chan commented on HBASE-21489: --- Test passed on local, {code} [INFO]

[jira] [Updated] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin

2018-11-16 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21481: -- Attachment: (was: HBASE-21481.master.001.patch) > [acl] Superuser's permissions should not be

[jira] [Updated] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin

2018-11-16 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21481: -- Attachment: HBASE-21481.master.001.patch > [acl] Superuser's permissions should not be granted or

[jira] [Updated] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin

2018-11-16 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21481: -- Status: Patch Available (was: Open) > [acl] Superuser's permissions should not be granted or revoked

[jira] [Updated] (HBASE-21489) TestShell is broken

2018-11-16 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21489: -- Fix Version/s: 2.2.0 3.0.0 > TestShell is broken > --- > >

[jira] [Updated] (HBASE-21489) TestShell is broken

2018-11-16 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21489: -- Affects Version/s: 2.2.0 3.0.0 > TestShell is broken > --- > >

[jira] [Updated] (HBASE-21489) TestShell is broken

2018-11-16 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21489: -- Attachment: HBASE-21489.master.001.patch > TestShell is broken > --- > >

[jira] [Updated] (HBASE-21489) TestShell is broken

2018-11-16 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21489: -- Status: Patch Available (was: Open) > TestShell is broken > --- > >

[jira] [Assigned] (HBASE-21489) TestShell is broken

2018-11-16 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan reassigned HBASE-21489: - Assignee: Reid Chan > TestShell is broken > --- > > Key:

[jira] [Commented] (HBASE-21428) Performance issue due to userRegionLock in the ConnectionManager.

2018-11-15 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689036#comment-16689036 ] Reid Chan commented on HBASE-21428: --- FYI [~stack] > Performance issue due to userRegionLock in the

[jira] [Commented] (HBASE-21428) Performance issue due to userRegionLock in the ConnectionManager.

2018-11-15 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689035#comment-16689035 ] Reid Chan commented on HBASE-21428: --- ping [~carp84], what do you think about this performance issue,

[jira] [Created] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin

2018-11-14 Thread Reid Chan (JIRA)
Reid Chan created HBASE-21481: - Summary: [acl] Superuser's permissions should not be granted or revoked by any non-su global admin Key: HBASE-21481 URL: https://issues.apache.org/jira/browse/HBASE-21481

[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-14 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Labels: ACLs security-issue (was: ) > [acl] Refactor TablePermission into three classes (Global,

[jira] [Resolved] (HBASE-21390) [test] TestRpcAccessChecks is buggy

2018-11-14 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-21390. --- Resolution: Fixed Hadoop Flags: Reviewed > [test] TestRpcAccessChecks is buggy >

[jira] [Commented] (HBASE-21390) [test] TestRpcAccessChecks is buggy

2018-11-14 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687450#comment-16687450 ] Reid Chan commented on HBASE-21390: --- Fixed in HBASE-21255. > [test] TestRpcAccessChecks is buggy >

[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-14 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Resolution: Resolved Hadoop Flags: Reviewed Status: Resolved (was: Patch Available)

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-14 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687449#comment-16687449 ] Reid Chan commented on HBASE-21255: --- Pushed to branch-2 and master. Thanks all for reviews and

[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-14 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Description: A TODO in {{TablePermission.java}} {code:java} //TODO refactor this class //we need

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-14 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687318#comment-16687318 ] Reid Chan commented on HBASE-21255: --- The checkstyle is about {{ShadedAccessControlUtil}}. Like this:

[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-14 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Attachment: HBASE-21225.master.009.patch > [acl] Refactor TablePermission into three classes (Global,

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-14 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686244#comment-16686244 ] Reid Chan commented on HBASE-21255: --- Retry v9. > [acl] Refactor TablePermission into three classes

[jira] [Comment Edited] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-13 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686047#comment-16686047 ] Reid Chan edited comment on HBASE-21255 at 11/14/18 3:33 AM: - bq. address

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-13 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686047#comment-16686047 ] Reid Chan commented on HBASE-21255: --- bq. address code duplication As suggestion, it is much cleaner.

[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-13 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Attachment: HBASE-21225.master.009.patch > [acl] Refactor TablePermission into three classes (Global,

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684636#comment-16684636 ] Reid Chan commented on HBASE-21255: --- Unrelated failure. > [acl] Refactor TablePermission into three

[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Attachment: (was: HBASE-21225.master.008.patch) > [acl] Refactor TablePermission into three

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683995#comment-16683995 ] Reid Chan commented on HBASE-21255: --- Attached a wrong v8 patch Re-upload it. > [acl] Refactor

[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Attachment: HBASE-21225.master.008.patch > [acl] Refactor TablePermission into three classes (Global,

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683936#comment-16683936 ] Reid Chan commented on HBASE-21255: --- v8 addressed comments from [~stack] in RB. > [acl] Refactor

[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Description: A TODO in {{TablePermission.java}} {code:java} //TODO refactor this class //we need

[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Attachment: HBASE-21225.master.008.patch > [acl] Refactor TablePermission into three classes (Global,

[jira] [Commented] (HBASE-21456) Make WALFactory only used for creating WALProviders

2018-11-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683874#comment-16683874 ] Reid Chan commented on HBASE-21456: --- Looks like Ted is working on it, but still in HBASE-21246. Do we

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-08 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680751#comment-16680751 ] Reid Chan commented on HBASE-21255: --- bq. perhaps ping dev@hbase for volunteers Thanks for reminder.

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-08 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679232#comment-16679232 ] Reid Chan commented on HBASE-21255: --- I will commit it late this day if no further comments. Since

[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface

2018-11-07 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679257#comment-16679257 ] Reid Chan commented on HBASE-21246: --- Can we file a sub task for refactoring WALFactory, let's start

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-07 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678066#comment-16678066 ] Reid Chan commented on HBASE-21255: --- Hoping more comments. > [acl] Refactor TablePermission into

[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface

2018-11-06 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677662#comment-16677662 ] Reid Chan commented on HBASE-21246: --- I spent some time on comments above, diagrams and basic codes

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-06 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677569#comment-16677569 ] Reid Chan commented on HBASE-21255: --- v7 changes visibility of new method

[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-06 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Attachment: HBASE-21225.master.007.patch > [acl] Refactor TablePermission into three classes (Global,

[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface

2018-11-05 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676063#comment-16676063 ] Reid Chan commented on HBASE-21246: --- I'm reading the diagrams, thanks for the work! > Introduce

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-05 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676057#comment-16676057 ] Reid Chan commented on HBASE-21255: --- Thanks Sean! Would you mind taking a look at

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-05 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675006#comment-16675006 ] Reid Chan commented on HBASE-21255: --- ping sir [~stack], do you have free cycles to give review? >

[jira] [Comment Edited] (HBASE-20623) Introduce the helper method "getCellBuilder()" to Mutation

2018-11-05 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674976#comment-16674976 ] Reid Chan edited comment on HBASE-20623 at 11/5/18 11:09 AM: - One more

[jira] [Commented] (HBASE-20623) Introduce the helper method "getCellBuilder()" to Mutation

2018-11-05 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674976#comment-16674976 ] Reid Chan commented on HBASE-20623: --- One more thing, family can also be reserved from client

[jira] [Commented] (HBASE-20623) Introduce the helper method "getCellBuilder()" to Mutation

2018-11-05 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674940#comment-16674940 ] Reid Chan commented on HBASE-20623: --- I think a {{Mutation}} should use one {{CellBuilder}} to create

[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-05 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Description: A TODO in {{TablePermission.java}} {code:java} //TODO refactor this class //we need

[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-05 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Attachment: HBASE-21255.master.006.patch > [acl] Refactor TablePermission into three classes (Global,

[jira] [Commented] (HBASE-21301) Heatmap for key access patterns

2018-11-04 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674633#comment-16674633 ] Reid Chan commented on HBASE-21301: --- Left some comments in RB, most of them are about style and

[jira] [Commented] (HBASE-21301) Heatmap for key access patterns

2018-11-02 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672866#comment-16672866 ] Reid Chan commented on HBASE-21301: --- Looks like you didn't publish it after modifications? But never

[jira] [Commented] (HBASE-21301) Heatmap for key access patterns

2018-11-02 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672847#comment-16672847 ] Reid Chan commented on HBASE-21301: --- For reviews, besides *people*, you are free to include *hbase*

[jira] [Commented] (HBASE-21301) Heatmap for key access patterns

2018-11-01 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672516#comment-16672516 ] Reid Chan commented on HBASE-21301: --- bq. Still working on the UI part, will upload that soon. You can

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-01 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672506#comment-16672506 ] Reid Chan commented on HBASE-21255: --- Failed UTs are not related, v5 addressed Duo's comment against

[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-11-01 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Attachment: HBASE-21255.master.005.patch > [acl] Refactor TablePermission into three classes (Global,

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-31 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669979#comment-16669979 ] Reid Chan commented on HBASE-21255: --- All modified UTs passed on local, and ShadedAccessControlUtil's

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-31 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669973#comment-16669973 ] Reid Chan commented on HBASE-21255: --- ping [~busbey] {code} [ERROR] Error occurred in starting fork,

[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-31 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Description: A TODO in {{TablePermission.java}} {code:java} //TODO refactor this class //we need

[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-30 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Fix Version/s: 2.2.0 3.0.0 > [acl] Refactor TablePermission into three classes

[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-30 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Description: A TODO in {{TablePermission.java}} {code:java} //TODO refactor this class //we need

[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-30 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Attachment: HBASE-21255.master.004.patch > [acl] Refactor TablePermission into three classes (Global,

[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface

2018-10-30 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668607#comment-16668607 ] Reid Chan commented on HBASE-21246: --- bq. Diagrams would have helped. from sir [~stack] Let me help to

[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-30 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668354#comment-16668354 ] Reid Chan commented on HBASE-21255: --- Let's see what will QA says before updating RB. > [acl] Refactor

[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-30 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Attachment: HBASE-21255.master.003.patch > [acl] Refactor TablePermission into three classes (Global,

[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-29 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Summary: [acl] Refactor TablePermission into three classes (Global, Namespace, Table) (was: Refactor

[jira] [Commented] (HBASE-21390) [test] TestRpcAccessChecks is buggy

2018-10-25 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16664649#comment-16664649 ] Reid Chan commented on HBASE-21390: --- I'm working on HBASE-21255 and struggling in fixing fail UTs

[jira] [Created] (HBASE-21390) [test] TestRpcAccessChecks is buggy

2018-10-25 Thread Reid Chan (JIRA)
Reid Chan created HBASE-21390: - Summary: [test] TestRpcAccessChecks is buggy Key: HBASE-21390 URL: https://issues.apache.org/jira/browse/HBASE-21390 Project: HBase Issue Type: Improvement

[jira] [Commented] (HBASE-21255) Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-25 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663597#comment-16663597 ] Reid Chan commented on HBASE-21255: --- echo: i'm still struggling to fix the failed UTs, some are bugs

[jira] [Resolved] (HBASE-21337) Master-Master Replication

2018-10-18 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-21337. --- Resolution: Not A Problem > Master-Master Replication > - > >

[jira] [Commented] (HBASE-21337) Master-Master Replication

2018-10-18 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655033#comment-16655033 ] Reid Chan commented on HBASE-21337: --- To ask questions, please send email to user at hbase.apache.org,

[jira] [Commented] (HBASE-21255) Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-18 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654840#comment-16654840 ] Reid Chan commented on HBASE-21255: --- Left some debug msg in patch, i will remove them in v3. >

[jira] [Commented] (HBASE-21255) Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-18 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654758#comment-16654758 ] Reid Chan commented on HBASE-21255: --- UTs are passed on local, but v2 may still have some checkstyle

[jira] [Updated] (HBASE-21255) Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-18 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Description: A TODO in {{TablePermission.java}} {code} //TODO refactor this class //we need to

[jira] [Updated] (HBASE-21255) Refactor TablePermission into three classes (Global, Namespace, Table)

2018-10-18 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Attachment: HBASE-21225.master.002.patch > Refactor TablePermission into three classes (Global,

[jira] [Commented] (HBASE-21255) Refactor TablePermission into three classes (Global, Namespace, Table)

2018-09-29 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633022#comment-16633022 ] Reid Chan commented on HBASE-21255: --- There're still branches of works... let me clean them up >

[jira] [Updated] (HBASE-21255) Refactor TablePermission into three classes (Global, Namespace, Table)

2018-09-29 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Status: Patch Available (was: Open) Still WIP (javadocs are missing), v1 is to check if it breaks

[jira] [Updated] (HBASE-21255) Refactor TablePermission into three classes (Global, Namespace, Table)

2018-09-29 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21255: -- Attachment: HBASE-21225.master.001.patch > Refactor TablePermission into three classes (Global,

[jira] [Created] (HBASE-21255) Refactor TablePermission into three classes (Global, Namespace, Table)

2018-09-29 Thread Reid Chan (JIRA)
Reid Chan created HBASE-21255: - Summary: Refactor TablePermission into three classes (Global, Namespace, Table) Key: HBASE-21255 URL: https://issues.apache.org/jira/browse/HBASE-21255 Project: HBase

[jira] [Updated] (HBASE-20993) [Auth] IPC client fallback to simple auth allowed doesn't work

2018-09-29 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-20993: -- Fix Version/s: (was: 1.4.8) > [Auth] IPC client fallback to simple auth allowed doesn't work >

[jira] [Commented] (HBASE-20993) [Auth] IPC client fallback to simple auth allowed doesn't work

2018-09-29 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632882#comment-16632882 ] Reid Chan commented on HBASE-20993: --- Can't fix this before 1.4.8 release, remove it from `Fix

[jira] [Updated] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

2018-09-27 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-20734: -- Resolution: Resolved Hadoop Flags: Reviewed Status: Resolved (was: Patch Available)

[jira] [Updated] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

2018-09-27 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-20734: -- Release Note: Previously the recovered.edits directory was under the root directory. This JIRA moves

<    5   6   7   8   9   10   11   12   13   14   >