Re: [PR] HBASE-28625 ExportSnapshot should verify checksums for the source file and the target file [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5950: URL: https://github.com/apache/hbase/pull/5950#issuecomment-2139476792 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] HBASE-28625 ExportSnapshot should verify checksums for the source file and the target file [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5950: URL: https://github.com/apache/hbase/pull/5950#issuecomment-2139446430 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 15s |

Re: [PR] HBASE-28625 ExportSnapshot should verify checksums for the source file and the target file [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5950: URL: https://github.com/apache/hbase/pull/5950#issuecomment-2139447321 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 10s |

Re: [PR] HBASE-28625 ExportSnapshot should verify checksums for the source file and the target file [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5950: URL: https://github.com/apache/hbase/pull/5950#issuecomment-2139429240 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] HBASE-28625 ExportSnapshot should verify checksums for the source file and the target file [hbase]

2024-05-30 Thread via GitHub
2005hithlj commented on code in PR #5950: URL: https://github.com/apache/hbase/pull/5950#discussion_r1620550710 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java: ## @@ -538,21 +537,47 @@ private FileChecksum getFileChecksum(final FileSystem

Re: [PR] HBASE-28631 Show the create time of the replication peer [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5954: URL: https://github.com/apache/hbase/pull/5954#issuecomment-2139226845 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2139150247 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2139140835 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 20s |

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2139135687 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[PR] HBASE-28631 Show the create time of the replication peer [hbase]

2024-05-30 Thread via GitHub
1458451310 opened a new pull request, #5954: URL: https://github.com/apache/hbase/pull/5954 When the table data needs to be migrated due to the closure of the computer room or the business side needs to have a primary and standby table, we need to create a peer. By checking the

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2139115176 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s |

Re: [PR] HBASE-28630 fix the explanation for the configuration of hbase.ipc.sserver.callqueue.read.ratio [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5953: URL: https://github.com/apache/hbase/pull/5953#issuecomment-2139096834 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

Re: [PR] HBASE-28630 fix the explanation for the configuration of hbase.ipc.sserver.callqueue.read.ratio [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5953: URL: https://github.com/apache/hbase/pull/5953#issuecomment-2139075186 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s |

Re: [PR] HBASE-28630 fix the explanation for the configuration of hbase.ipc.sserver.callqueue.read.ratio [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5953: URL: https://github.com/apache/hbase/pull/5953#issuecomment-2139075208 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58s |

Re: [PR] HBASE-28630 fix the explanation for the configuration of hbase.ipc.sserver.callqueue.read.ratio [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5953: URL: https://github.com/apache/hbase/pull/5953#issuecomment-2139074394 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-30 Thread via GitHub
DieterDP-ng commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2139066109 Requested changes applied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] HBASE-28630 fix the explanation for the configuration of hbase.ipc.sserver.callqueue.read.ratio [hbase]

2024-05-30 Thread via GitHub
1458451310 opened a new pull request, #5953: URL: https://github.com/apache/hbase/pull/5953 fix the explanation for the configuration of hbase.ipc.sserver.callqueue.read.ratio -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-30 Thread via GitHub
DieterDP-ng commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1620230862 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/TableBackupClient.java: ## @@ -281,13 +284,65 @@ protected void addManifest(BackupInfo backupInfo,

Re: [PR] HBASE-28628 Use Base64.getUrlEncoder().withoutPadding() in REST tests [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5952: URL: https://github.com/apache/hbase/pull/5952#issuecomment-2138826085 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28628 Use Base64.getUrlEncoder().withoutPadding() in REST tests [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5952: URL: https://github.com/apache/hbase/pull/5952#issuecomment-2138823506 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28628 Use Base64.getUrlEncoder().withoutPadding() in REST tests [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5952: URL: https://github.com/apache/hbase/pull/5952#issuecomment-2138814224 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28628 Use Base64.getUrlEncoder().withoutPadding() in REST tests [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5952: URL: https://github.com/apache/hbase/pull/5952#issuecomment-2138812856 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28625 ExportSnapshot should verify checksums for the source file and the target file [hbase]

2024-05-30 Thread via GitHub
Apache9 commented on code in PR #5950: URL: https://github.com/apache/hbase/pull/5950#discussion_r1620035220 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java: ## @@ -538,21 +537,47 @@ private FileChecksum getFileChecksum(final FileSystem fs,

Re: [PR] HBASE-28626 MultiRowRangeFilter deserialization fails in org.apache.h… [hbase]

2024-05-29 Thread via GitHub
stoty merged PR #5951: URL: https://github.com/apache/hbase/pull/5951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28625 ExportSnapshot should verify checksums for the source file and the target file [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5950: URL: https://github.com/apache/hbase/pull/5950#issuecomment-2138679697 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

Re: [PR] HBASE-28625 ExportSnapshot should verify checksums for the source file and the target file [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5950: URL: https://github.com/apache/hbase/pull/5950#issuecomment-2138680022 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

Re: [PR] HBASE-28625 ExportSnapshot should verify checksums for the source file and the target file [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5950: URL: https://github.com/apache/hbase/pull/5950#issuecomment-2138678103 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-28625 ExportSnapshot should verify checksums for the source file and the target file [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5950: URL: https://github.com/apache/hbase/pull/5950#issuecomment-2138668036 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28626 MultiRowRangeFilter deserialization fails in org.apache.h… [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5951: URL: https://github.com/apache/hbase/pull/5951#issuecomment-2138625611 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28546 Make WAL rolling exception clear [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5848: URL: https://github.com/apache/hbase/pull/5848#issuecomment-2138624445 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28626 MultiRowRangeFilter deserialization fails in org.apache.h… [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5951: URL: https://github.com/apache/hbase/pull/5951#issuecomment-2138620401 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28626 MultiRowRangeFilter deserialization fails in org.apache.h… [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5951: URL: https://github.com/apache/hbase/pull/5951#issuecomment-2138619106 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28626 MultiRowRangeFilter deserialization fails in org.apache.h… [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5951: URL: https://github.com/apache/hbase/pull/5951#issuecomment-2138618967 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28546 Make WAL rolling exception clear [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5848: URL: https://github.com/apache/hbase/pull/5848#issuecomment-2138618961 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28546 Make WAL rolling exception clear [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5848: URL: https://github.com/apache/hbase/pull/5848#issuecomment-2138617753 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28546 Make WAL rolling exception clear [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5848: URL: https://github.com/apache/hbase/pull/5848#issuecomment-2138441418 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-28546 Make WAL rolling exception clear [hbase]

2024-05-29 Thread via GitHub
jojochuang commented on PR #5848: URL: https://github.com/apache/hbase/pull/5848#issuecomment-2138414881 Thanks for the reminder. Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HBASE-28546 Make WAL rolling exception clear [hbase]

2024-05-29 Thread via GitHub
jojochuang commented on code in PR #5848: URL: https://github.com/apache/hbase/pull/5848#discussion_r1619577351 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncProtobufLogWriter.java: ## @@ -205,9 +205,11 @@ private long writeWALMetadata(Consumer>

Re: [PR] HBASE-28626 MultiRowRangeFilter deserialization fails in org.apache.h… [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5951: URL: https://github.com/apache/hbase/pull/5951#issuecomment-2137770696 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28626 MultiRowRangeFilter deserialization fails in org.apache.h… [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5951: URL: https://github.com/apache/hbase/pull/5951#issuecomment-2137769688 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s |

Re: [PR] HBASE-28626 MultiRowRangeFilter deserialization fails in org.apache.h… [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5951: URL: https://github.com/apache/hbase/pull/5951#issuecomment-2137769627 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28626 MultiRowRangeFilter deserialization fails in org.apache.h… [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5951: URL: https://github.com/apache/hbase/pull/5951#issuecomment-2137767288 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

Re: [PR] HBASE-28626 MultiRowRangeFilter deserialization fails in org.apache.h… [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5951: URL: https://github.com/apache/hbase/pull/5951#issuecomment-2137709304 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

Re: [PR] HBASE-28626 MultiRowRangeFilter deserialization fails in org.apache.h… [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5951: URL: https://github.com/apache/hbase/pull/5951#issuecomment-2137707425 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28626 MultiRowRangeFilter deserialization fails in org.apache.h… [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5951: URL: https://github.com/apache/hbase/pull/5951#issuecomment-2137703834 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-28626 MultiRowRangeFilter deserialization fails in org.apache.h… [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5951: URL: https://github.com/apache/hbase/pull/5951#issuecomment-2137699237 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

Re: [PR] HBASE-27126 Support multi-threads cleaner for MOB files [hbase]

2024-05-29 Thread via GitHub
Apache9 commented on PR #5833: URL: https://github.com/apache/hbase/pull/5833#issuecomment-2137667014 Please use shaded version of guava classes? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HBASE-27126 Support multi-threads cleaner for MOB files [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5833: URL: https://github.com/apache/hbase/pull/5833#issuecomment-2137660377 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-27126 Support multi-threads cleaner for MOB files [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5833: URL: https://github.com/apache/hbase/pull/5833#issuecomment-2137658162 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 16s |

Re: [PR] HBASE-27126 Support multi-threads cleaner for MOB files [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5833: URL: https://github.com/apache/hbase/pull/5833#issuecomment-2137656535 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-27126 Support multi-threads cleaner for MOB files [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5833: URL: https://github.com/apache/hbase/pull/5833#issuecomment-2137645855 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 11s |

[PR] HBASE-28626 MultiRowRangeFilter deserialization fails in org.apache.h… [hbase]

2024-05-29 Thread via GitHub
stoty opened a new pull request, #5951: URL: https://github.com/apache/hbase/pull/5951 …adoop.hbase.rest.model.ScannerModel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-29 Thread via GitHub
Apache9 merged PR #5903: URL: https://github.com/apache/hbase/pull/5903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28420 Update the procedure's field to store for ServerRemoteProcedure [hbase]

2024-05-29 Thread via GitHub
Apache9 commented on code in PR #5816: URL: https://github.com/apache/hbase/pull/5816#discussion_r1619031611 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java: ## @@ -80,17 +82,25 @@ public abstract class ServerRemoteProcedure

Re: [PR] HBASE-28420 Update the procedure's field to store for ServerRemoteProcedure [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5816: URL: https://github.com/apache/hbase/pull/5816#issuecomment-2137524077 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28420 Update the procedure's field to store for ServerRemoteProcedure [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5816: URL: https://github.com/apache/hbase/pull/5816#issuecomment-2137434305 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-28420 Update the procedure's field to store for ServerRemoteProcedure [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5816: URL: https://github.com/apache/hbase/pull/5816#issuecomment-2137364177 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28625 ExportSnapshot should verify checksums for the source file and the target file [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5950: URL: https://github.com/apache/hbase/pull/5950#issuecomment-2137320483 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28625 ExportSnapshot should verify checksums for the source file and the target file [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5950: URL: https://github.com/apache/hbase/pull/5950#issuecomment-2137304760 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28625 ExportSnapshot should verify checksums for the source file and the target file [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5950: URL: https://github.com/apache/hbase/pull/5950#issuecomment-2137289422 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28625 ExportSnapshot should verify checksums for the source file and the target file [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5950: URL: https://github.com/apache/hbase/pull/5950#issuecomment-2137274945 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s |

[PR] HBASE-28625 ExportSnapshot should verify checksums for the source file and the target file [hbase]

2024-05-29 Thread via GitHub
2005hithlj opened a new pull request, #5950: URL: https://github.com/apache/hbase/pull/5950 https://issues.apache.org/jira/browse/HBASE-28625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HBASE-28420 Update the procedure's field to store for ServerRemoteProcedure [hbase]

2024-05-29 Thread via GitHub
Apache-HBase commented on PR #5816: URL: https://github.com/apache/hbase/pull/5816#issuecomment-2136970940 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28420 Update the procedure's field to store for ServerRemoteProcedure [hbase]

2024-05-29 Thread via GitHub
Umeshkumar9414 commented on code in PR #5816: URL: https://github.com/apache/hbase/pull/5816#discussion_r1618473493 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java: ## @@ -80,17 +82,25 @@ public abstract class

Re: [PR] HBASE-28420 Update the procedure's field to store for ServerRemoteProcedure [hbase]

2024-05-29 Thread via GitHub
Umeshkumar9414 commented on code in PR #5816: URL: https://github.com/apache/hbase/pull/5816#discussion_r1618451655 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java: ## @@ -80,17 +82,25 @@ public abstract class

Re: [PR] HBASE-28420 Update the procedure's field to store for ServerRemoteProcedure [hbase]

2024-05-29 Thread via GitHub
Umeshkumar9414 commented on code in PR #5816: URL: https://github.com/apache/hbase/pull/5816#discussion_r1618451655 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java: ## @@ -80,17 +82,25 @@ public abstract class

Re: [PR] HBASE-28616 Remove/Deprecated the rs.* related configuration in Table… [hbase]

2024-05-29 Thread via GitHub
Apache9 merged PR #5946: URL: https://github.com/apache/hbase/pull/5946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-28 Thread via GitHub
virajjasani commented on code in PR #5903: URL: https://github.com/apache/hbase/pull/5903#discussion_r1617606384 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java: ## @@ -1084,14 +1085,55 @@ public TransitRegionStateProcedure[]

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-28 Thread via GitHub
Apache9 merged PR #5893: URL: https://github.com/apache/hbase/pull/5893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-28 Thread via GitHub
2005hithlj commented on PR #5893: URL: https://github.com/apache/hbase/pull/5893#issuecomment-2135213878 The failed UT TestMajorCompaction is not related to the changes, and it is ok in my local env. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] HBASE-28546 Make WAL rolling exception clear [hbase]

2024-05-28 Thread via GitHub
Apache9 commented on PR #5848: URL: https://github.com/apache/hbase/pull/5848#issuecomment-2135163966 Any updates here? @jojochuang Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-28 Thread via GitHub
Apache9 commented on PR #5903: URL: https://github.com/apache/hbase/pull/5903#issuecomment-2135159868 Any other concerns here? @virajjasani Let's get this in, and then focus on how to deal with CloseTableProcedure? Thanks. -- This is an automated message from the Apache Git

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-28 Thread via GitHub
Apache9 commented on code in PR #5903: URL: https://github.com/apache/hbase/pull/5903#discussion_r1617204410 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java: ## @@ -1084,14 +1085,55 @@ public TransitRegionStateProcedure[]

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-28 Thread via GitHub
Apache-HBase commented on PR #5893: URL: https://github.com/apache/hbase/pull/5893#issuecomment-2134928074 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-28 Thread via GitHub
Apache-HBase commented on PR #5893: URL: https://github.com/apache/hbase/pull/5893#issuecomment-2134883682 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-28 Thread via GitHub
Apache-HBase commented on PR #5893: URL: https://github.com/apache/hbase/pull/5893#issuecomment-2134878220 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28613 Use streaming when marshalling protobuf REST output [hbase]

2024-05-28 Thread via GitHub
stoty merged PR #5943: URL: https://github.com/apache/hbase/pull/5943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-28 Thread via GitHub
Apache-HBase commented on PR #5893: URL: https://github.com/apache/hbase/pull/5893#issuecomment-2134465932 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-28613 Use streaming when marshalling protobuf REST output [hbase]

2024-05-28 Thread via GitHub
stoty commented on code in PR #5943: URL: https://github.com/apache/hbase/pull/5943#discussion_r1616669746 ## hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/ProtobufMessageHandler.java: ## @@ -18,21 +18,55 @@ package org.apache.hadoop.hbase.rest; import

Re: [PR] HBASE-28613 Use streaming when marshalling protobuf REST output [hbase]

2024-05-27 Thread via GitHub
ankitsinghal commented on code in PR #5943: URL: https://github.com/apache/hbase/pull/5943#discussion_r1615407245 ## hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/ProtobufMessageHandler.java: ## @@ -18,21 +18,55 @@ package org.apache.hadoop.hbase.rest; import

Re: [PR] HBASE-28620 fix replication quota leak when peer changes [hbase]

2024-05-27 Thread via GitHub
Apache-HBase commented on PR #5949: URL: https://github.com/apache/hbase/pull/5949#issuecomment-2133923844 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28620 fix replication quota leak when peer changes [hbase]

2024-05-27 Thread via GitHub
Apache-HBase commented on PR #5949: URL: https://github.com/apache/hbase/pull/5949#issuecomment-2133903277 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28619 Fix the inaccurate message when snapshot doesn't exist [hbase]

2024-05-27 Thread via GitHub
Apache-HBase commented on PR #5948: URL: https://github.com/apache/hbase/pull/5948#issuecomment-2133649035 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

Re: [PR] HBASE-28619 Fix the inaccurate message when snapshot doesn't exist [hbase]

2024-05-27 Thread via GitHub
Apache-HBase commented on PR #5948: URL: https://github.com/apache/hbase/pull/5948#issuecomment-2133647953 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

Re: [PR] HBASE-28619 Fix the inaccurate message when snapshot doesn't exist [hbase]

2024-05-27 Thread via GitHub
Apache-HBase commented on PR #5948: URL: https://github.com/apache/hbase/pull/5948#issuecomment-2133648685 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-28619 Fix the inaccurate message when snapshot doesn't exist [hbase]

2024-05-27 Thread via GitHub
Apache-HBase commented on PR #5948: URL: https://github.com/apache/hbase/pull/5948#issuecomment-2133645907 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28620 fix replication quota leak when peer changes [hbase]

2024-05-27 Thread via GitHub
Apache-HBase commented on PR #5949: URL: https://github.com/apache/hbase/pull/5949#issuecomment-2133641167 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-28620 fix replication quota leak when peer changes [hbase]

2024-05-27 Thread via GitHub
Apache-HBase commented on PR #5949: URL: https://github.com/apache/hbase/pull/5949#issuecomment-2133635607 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28620 fix replication quota leak when peer changes [hbase]

2024-05-27 Thread via GitHub
1458451310 commented on PR #5949: URL: https://github.com/apache/hbase/pull/5949#issuecomment-2133567524 ` long timeout = EnvironmentEdgeManager.currentTime() + this.shipEditsTimeout;` `this.shipEditsTimeout` = this.conf.getInt(HConstants.REPLICATION_SOURCE_SHIPEDITS_TIMEOUT,

Re: [PR] HBASE-28620 fix replication quota leak when peer changes [hbase]

2024-05-27 Thread via GitHub
1458451310 commented on PR #5949: URL: https://github.com/apache/hbase/pull/5949#issuecomment-2133562275 long timeout = EnvironmentEdgeManager.currentTime() + this.shipEditsTimeout; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] HBASE-28620 fix replication quota leak when peer changes [hbase]

2024-05-27 Thread via GitHub
1458451310 opened a new pull request, #5949: URL: https://github.com/apache/hbase/pull/5949 When peer changes, replication closes the reader and shipper created earlier. However, after the specified timeout, the shipper still does not automatically close. The existing code simply returns

Re: [PR] HBASE-28612 fix replication quota leak when peer changes [hbase]

2024-05-27 Thread via GitHub
1458451310 closed pull request #5944: HBASE-28612 fix replication quota leak when peer changes URL: https://github.com/apache/hbase/pull/5944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HBASE-28619 Fix the inaccurate message when snapshot doesn't exist [hbase]

2024-05-27 Thread via GitHub
Apache-HBase commented on PR #5948: URL: https://github.com/apache/hbase/pull/5948#issuecomment-2133434813 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 22s |

Re: [PR] HBASE-28619 Fix the inaccurate message when snapshot doesn't exist [hbase]

2024-05-27 Thread via GitHub
Apache-HBase commented on PR #5948: URL: https://github.com/apache/hbase/pull/5948#issuecomment-2133434177 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 16s |

Re: [PR] HBASE-28619 Fix the inaccurate message when snapshot doesn't exist [hbase]

2024-05-27 Thread via GitHub
Apache-HBase commented on PR #5948: URL: https://github.com/apache/hbase/pull/5948#issuecomment-2133430848 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28619 Fix the inaccurate message when snapshot doesn't exist [hbase]

2024-05-27 Thread via GitHub
Apache-HBase commented on PR #5948: URL: https://github.com/apache/hbase/pull/5948#issuecomment-2133430350 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28613 Use streaming when marshalling protobuf REST output [hbase]

2024-05-27 Thread via GitHub
Apache-HBase commented on PR #5943: URL: https://github.com/apache/hbase/pull/5943#issuecomment-2132858928 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-28613 Use streaming when marshalling protobuf REST output [hbase]

2024-05-27 Thread via GitHub
Apache-HBase commented on PR #5943: URL: https://github.com/apache/hbase/pull/5943#issuecomment-2132857034 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 11s |

Re: [PR] HBASE-28613 Use streaming when marshalling protobuf REST output [hbase]

2024-05-27 Thread via GitHub
Apache-HBase commented on PR #5943: URL: https://github.com/apache/hbase/pull/5943#issuecomment-2132854853 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 9s |

Re: [PR] HBASE-28613 Use streaming when marshalling protobuf REST output [hbase]

2024-05-27 Thread via GitHub
Apache-HBase commented on PR #5943: URL: https://github.com/apache/hbase/pull/5943#issuecomment-2132856127 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

  1   2   3   4   5   6   7   8   9   10   >