Re: [PR] HBASE-28335 Expose CacheStats ageAtEviction histogram in jmx [hbase]

2024-05-23 Thread via GitHub
Apache-HBase commented on PR #5942: URL: https://github.com/apache/hbase/pull/5942#issuecomment-2127767790 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28613 Use streaming when marshalling protobuf REST output [hbase]

2024-05-23 Thread via GitHub
Apache-HBase commented on PR #5943: URL: https://github.com/apache/hbase/pull/5943#issuecomment-2127439225 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-28613 Use streaming when marshalling protobuf REST output [hbase]

2024-05-23 Thread via GitHub
Apache-HBase commented on PR #5943: URL: https://github.com/apache/hbase/pull/5943#issuecomment-2127433769 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s |

Re: [PR] HBASE-28613 Use streaming when marshalling protobuf REST output [hbase]

2024-05-23 Thread via GitHub
Apache-HBase commented on PR #5943: URL: https://github.com/apache/hbase/pull/5943#issuecomment-2127429785 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-28613 Use streaming when marshalling protobuf REST output [hbase]

2024-05-23 Thread via GitHub
Apache-HBase commented on PR #5943: URL: https://github.com/apache/hbase/pull/5943#issuecomment-2127423289 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

[PR] HBASE-28613 Use streaming when marshalling protobuf REST output [hbase]

2024-05-23 Thread via GitHub
stoty opened a new pull request, #5943: URL: https://github.com/apache/hbase/pull/5943 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28335 Expose CacheStats ageAtEviction histogram in jmx [hbase]

2024-05-23 Thread via GitHub
Apache-HBase commented on PR #5942: URL: https://github.com/apache/hbase/pull/5942#issuecomment-2127281751 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] Hbase 28467 Fix Unit test [hbase]

2024-05-23 Thread via GitHub
Apache-HBase commented on PR #5941: URL: https://github.com/apache/hbase/pull/5941#issuecomment-2126793676 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] Hbase 28467 Fix Unit test [hbase]

2024-05-23 Thread via GitHub
Apache-HBase commented on PR #5941: URL: https://github.com/apache/hbase/pull/5941#issuecomment-2126783407 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-27915 Update hbase_docker with an extra Dockerfile compatible with mac m1 platform [hbase]

2024-05-23 Thread via GitHub
ndimiduk commented on code in PR #5286: URL: https://github.com/apache/hbase/pull/5286#discussion_r1611262805 ## dev-support/hbase_docker/m1/Dockerfile: ## @@ -0,0 +1,92 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-2.5 [hbase]

2024-05-23 Thread via GitHub
ndimiduk merged PR #5935: URL: https://github.com/apache/hbase/pull/5935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-2.6 [hbase]

2024-05-23 Thread via GitHub
ndimiduk merged PR #5934: URL: https://github.com/apache/hbase/pull/5934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-2 [hbase]

2024-05-23 Thread via GitHub
ndimiduk merged PR #5933: URL: https://github.com/apache/hbase/pull/5933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-3 [hbase]

2024-05-23 Thread via GitHub
ndimiduk merged PR #5932: URL: https://github.com/apache/hbase/pull/5932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Hbase 28467 Fix Unit test [hbase]

2024-05-23 Thread via GitHub
Apache-HBase commented on PR #5941: URL: https://github.com/apache/hbase/pull/5941#issuecomment-2126322271 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28425 Allow specify cluster key without zookeeper in replication [hbase]

2024-05-22 Thread via GitHub
Apache9 commented on PR #5865: URL: https://github.com/apache/hbase/pull/5865#issuecomment-2126295194 Going to merge this today if no other concerns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Hbase 28467: Fix unit test [hbase]

2024-05-22 Thread via GitHub
jhungund closed pull request #5940: Hbase 28467: Fix unit test URL: https://github.com/apache/hbase/pull/5940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] Hbase 28467 Fix Unit test [hbase]

2024-05-22 Thread via GitHub
jhungund opened a new pull request, #5941: URL: https://github.com/apache/hbase/pull/5941 Change-Id: Ibb7b1ecb2d084ce190c15eed5b3bc42ca32ceffb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Hbase 28467: Fix unit test [hbase]

2024-05-22 Thread via GitHub
jhungund opened a new pull request, #5940: URL: https://github.com/apache/hbase/pull/5940 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] HBASE-28564 Move Reference file read/creation to SFT interface [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5939: URL: https://github.com/apache/hbase/pull/5939#issuecomment-2126265175 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s |

Re: [PR] HBASE-28564 Move Reference file read/creation to SFT interface [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5939: URL: https://github.com/apache/hbase/pull/5939#issuecomment-2126262623 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 57s |

Re: [PR] HBASE-28564 Move Reference file read/creation to SFT interface [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5939: URL: https://github.com/apache/hbase/pull/5939#issuecomment-2126258758 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s |

Re: [PR] HBASE-28564 Move Reference file read/creation to SFT interface [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5939: URL: https://github.com/apache/hbase/pull/5939#issuecomment-2126257718 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2125613628 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2125611538 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2125604011 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-22 Thread via GitHub
wchevreuil merged PR #5905: URL: https://github.com/apache/hbase/pull/5905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-3 [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5932: URL: https://github.com/apache/hbase/pull/5932#issuecomment-2125232245 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-2.6 [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5934: URL: https://github.com/apache/hbase/pull/5934#issuecomment-2125148901 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s |

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2125133759 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-22 Thread via GitHub
rmdmattingly commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1610231908 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo backupInfo)

Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-2 [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5933: URL: https://github.com/apache/hbase/pull/5933#issuecomment-2125096826 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s |

Re: [PR] HBASE-27915 Update hbase_docker with an extra Dockerfile compatible with mac m1 platform [hbase]

2024-05-22 Thread via GitHub
wchevreuil merged PR #5286: URL: https://github.com/apache/hbase/pull/5286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5936: URL: https://github.com/apache/hbase/pull/5936#issuecomment-2125014397 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s |

Re: [PR] HBASE-27915 Update hbase_docker with an extra Dockerfile compatible with mac m1 platform [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5286: URL: https://github.com/apache/hbase/pull/5286#issuecomment-2125011378 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-27915 Update hbase_docker with an extra Dockerfile compatible with mac m1 platform [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5286: URL: https://github.com/apache/hbase/pull/5286#issuecomment-2125008079 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-27915 Update hbase_docker with an extra Dockerfile compatible with mac m1 platform [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5286: URL: https://github.com/apache/hbase/pull/5286#issuecomment-2125008930 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

Re: [PR] HBASE-27915 Update hbase_docker with an extra Dockerfile compatible with mac m1 platform [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5286: URL: https://github.com/apache/hbase/pull/5286#issuecomment-2125007446 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-3 [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5932: URL: https://github.com/apache/hbase/pull/5932#issuecomment-2125002879 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 13s |

Re: [PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5936: URL: https://github.com/apache/hbase/pull/5936#issuecomment-212489 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5937: URL: https://github.com/apache/hbase/pull/5937#issuecomment-2124987639 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5937: URL: https://github.com/apache/hbase/pull/5937#issuecomment-2124983062 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5936: URL: https://github.com/apache/hbase/pull/5936#issuecomment-2124981811 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5937: URL: https://github.com/apache/hbase/pull/5937#issuecomment-2124981438 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5936: URL: https://github.com/apache/hbase/pull/5936#issuecomment-2124979336 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5937: URL: https://github.com/apache/hbase/pull/5937#issuecomment-2124976901 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-2.5 [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5935: URL: https://github.com/apache/hbase/pull/5935#issuecomment-2124924859 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 17s |

Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-2.6 [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5934: URL: https://github.com/apache/hbase/pull/5934#issuecomment-2124865421 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-3 [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5932: URL: https://github.com/apache/hbase/pull/5932#issuecomment-2124864456 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-2 [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5933: URL: https://github.com/apache/hbase/pull/5933#issuecomment-2124846462 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s |

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-22 Thread via GitHub
wchevreuil merged PR #5866: URL: https://github.com/apache/hbase/pull/5866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-2.5 [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5935: URL: https://github.com/apache/hbase/pull/5935#issuecomment-2124776905 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2124773323 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2124659494 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s |

Re: [PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5937: URL: https://github.com/apache/hbase/pull/5937#issuecomment-2124642361 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5937: URL: https://github.com/apache/hbase/pull/5937#issuecomment-2124628330 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 49s |

Re: [PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5937: URL: https://github.com/apache/hbase/pull/5937#issuecomment-2124617423 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5937: URL: https://github.com/apache/hbase/pull/5937#issuecomment-2124615539 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5938: URL: https://github.com/apache/hbase/pull/5938#issuecomment-2124612631 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s |

Re: [PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5938: URL: https://github.com/apache/hbase/pull/5938#issuecomment-2124609474 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s |

Re: [PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5938: URL: https://github.com/apache/hbase/pull/5938#issuecomment-2124602348 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5936: URL: https://github.com/apache/hbase/pull/5936#issuecomment-2124590718 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

Re: [PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5936: URL: https://github.com/apache/hbase/pull/5936#issuecomment-2124588485 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5936: URL: https://github.com/apache/hbase/pull/5936#issuecomment-2124587657 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
szucsvillo closed pull request #5938: HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… URL: https://github.com/apache/hbase/pull/5938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5936: URL: https://github.com/apache/hbase/pull/5936#issuecomment-2124584184 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
szucsvillo opened a new pull request, #5938: URL: https://github.com/apache/hbase/pull/5938 …86 to public interfaces (#3527) Self-approving trivial change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
szucsvillo opened a new pull request, #5937: URL: https://github.com/apache/hbase/pull/5937 …86 to public interfaces (#3527) Self-approving trivial change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] HBASE-28591: Backport HBASE-26123 Restore fields dropped by HBASE-259… [hbase]

2024-05-22 Thread via GitHub
szucsvillo opened a new pull request, #5936: URL: https://github.com/apache/hbase/pull/5936 …86 to public interfaces (#3527) Self-approving trivial change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-22 Thread via GitHub
Apache9 merged PR #5883: URL: https://github.com/apache/hbase/pull/5883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28420 Update the procedure's field to store for ServerRemoteProcedure [hbase]

2024-05-22 Thread via GitHub
Apache9 commented on code in PR #5816: URL: https://github.com/apache/hbase/pull/5816#discussion_r1609630113 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java: ## @@ -80,17 +82,25 @@ public abstract class ServerRemoteProcedure

Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-3 [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5932: URL: https://github.com/apache/hbase/pull/5932#issuecomment-2124292416 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28539 Fix merging of incremental backups when the backup filesystem is not the same as the one underpinning HBase itself. [hbase]

2024-05-22 Thread via GitHub
ndimiduk commented on code in PR #5867: URL: https://github.com/apache/hbase/pull/5867#discussion_r1608322367 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupMerge.java: ## @@ -124,4 +128,43 @@ public void TestIncBackupMergeRestore() throws Exception {

Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-2.5 [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5935: URL: https://github.com/apache/hbase/pull/5935#issuecomment-2124286604 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s |

Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-2.6 [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5934: URL: https://github.com/apache/hbase/pull/5934#issuecomment-2124262914 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 21s |

Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-2 [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5933: URL: https://github.com/apache/hbase/pull/5933#issuecomment-2124256108 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 49s |

Re: [PR] HBASE-28612 fix replication quota leak when peer changes [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5930: URL: https://github.com/apache/hbase/pull/5930#issuecomment-2124231821 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28612 fix replication quota leak when peer changes [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5930: URL: https://github.com/apache/hbase/pull/5930#issuecomment-2124218920 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-22 Thread via GitHub
ndimiduk commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1609532907 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/TableBackupClient.java: ## @@ -281,13 +284,65 @@ protected void addManifest(BackupInfo backupInfo,

[PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-2.5 [hbase]

2024-05-22 Thread via GitHub
ndimiduk opened a new pull request, #5935: URL: https://github.com/apache/hbase/pull/5935 This change results in this error on master at `3a3dd66e21`. ``` [WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message: Banned imports

[PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-2.6 [hbase]

2024-05-22 Thread via GitHub
ndimiduk opened a new pull request, #5934: URL: https://github.com/apache/hbase/pull/5934 This change results in this error on master at `3a3dd66e21`. ``` [WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message: Banned imports

Re: [PR] Bump requests from 2.31.0 to 2.32.2 in /dev-support/git-jira-release-audit [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5931: URL: https://github.com/apache/hbase/pull/5931#issuecomment-2124175215 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s |

Re: [PR] Bump requests from 2.31.0 to 2.32.2 in /dev-support/git-jira-release-audit [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5931: URL: https://github.com/apache/hbase/pull/5931#issuecomment-2124170279 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] Bump requests from 2.31.0 to 2.32.2 in /dev-support/git-jira-release-audit [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5931: URL: https://github.com/apache/hbase/pull/5931#issuecomment-2124169699 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] Bump requests from 2.31.0 to 2.32.2 in /dev-support/git-jira-release-audit [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5931: URL: https://github.com/apache/hbase/pull/5931#issuecomment-2124169531 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-2 [hbase]

2024-05-22 Thread via GitHub
ndimiduk opened a new pull request, #5933: URL: https://github.com/apache/hbase/pull/5933 This change results in this error on master at `3a3dd66e21`. ``` [WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message: Banned imports

[PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-3 [hbase]

2024-05-22 Thread via GitHub
ndimiduk opened a new pull request, #5932: URL: https://github.com/apache/hbase/pull/5932 This change results in this error on master at `3a3dd66e21`. ``` [WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message: Banned imports

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-22 Thread via GitHub
Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2124160809 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58s |

[PR] Bump requests from 2.31.0 to 2.32.2 in /dev-support/git-jira-release-audit [hbase]

2024-05-22 Thread via GitHub
dependabot[bot] opened a new pull request, #5931: URL: https://github.com/apache/hbase/pull/5931 Bumps [requests](https://github.com/psf/requests) from 2.31.0 to 2.32.2. Release notes Sourced from https://github.com/psf/requests/releases;>requests's releases. v2.32.2

Re: [PR] HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars [hbase]

2024-05-22 Thread via GitHub
ndimiduk merged PR #5918: URL: https://github.com/apache/hbase/pull/5918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-27915 Update hbase_docker with an extra Dockerfile compatible with mac m1 platform [hbase]

2024-05-21 Thread via GitHub
taklwu commented on PR #5286: URL: https://github.com/apache/hbase/pull/5286#issuecomment-2123916712 @wchevreuil maybe you can fix the style issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] HBASE-27915 Update hbase_docker with an extra Dockerfile compatible with mac m1 platform [hbase]

2024-05-21 Thread via GitHub
taklwu commented on code in PR #5286: URL: https://github.com/apache/hbase/pull/5286#discussion_r1609295820 ## dev-support/hbase_docker/m1/Dockerfile: ## @@ -0,0 +1,92 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] HBASE-28612 fix replication quota leak when peer changes [hbase]

2024-05-21 Thread via GitHub
Apache-HBase commented on PR #5930: URL: https://github.com/apache/hbase/pull/5930#issuecomment-2123881457 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s |

Re: [PR] HBASE-28612 fix replication quota leak when peer changes [hbase]

2024-05-21 Thread via GitHub
Apache-HBase commented on PR #5930: URL: https://github.com/apache/hbase/pull/5930#issuecomment-2123878548 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[PR] HBASE-28612 fix replication quota leak when peer changes [hbase]

2024-05-21 Thread via GitHub
1458451310 opened a new pull request, #5930: URL: https://github.com/apache/hbase/pull/5930 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-21 Thread via GitHub
Apache9 commented on code in PR #5903: URL: https://github.com/apache/hbase/pull/5903#discussion_r1609234851 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CloseExcessRegionReplicasProcedure.java: ## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-21 Thread via GitHub
Umeshkumar9414 commented on code in PR #5903: URL: https://github.com/apache/hbase/pull/5903#discussion_r1609221184 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CloseExcessRegionReplicasProcedure.java: ## @@ -0,0 +1,159 @@ +/* + * Licensed to the

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-21 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2123619524 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-21 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2123597574 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-21 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2123578891 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

<    1   2   3   4   5   6   7   8   9   10   >