Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2115125977 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-28469: Changes for enabling data-tiering checks during cacheOnWrite (compaction codepaths) [hbase]

2024-05-16 Thread via GitHub
jhungund commented on code in PR #5908: URL: https://github.com/apache/hbase/pull/5908#discussion_r1603223519 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java: ## @@ -553,16 +565,26 @@ private void writeInlineBlocks(boolean closing) throws

Re: [PR] HBASE-28598 Fixes NPE for writer object access in AsyncFSWAL#closeWriter [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5907: URL: https://github.com/apache/hbase/pull/5907#issuecomment-2115005224 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28598 Fixes NPE for writer object access in AsyncFSWAL#closeWriter [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5907: URL: https://github.com/apache/hbase/pull/5907#issuecomment-2114941818 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2114890243 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2114854114 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 20s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2114812889 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-16 Thread via GitHub
jhungund commented on code in PR #5905: URL: https://github.com/apache/hbase/pull/5905#discussion_r1602908275 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java: ## @@ -1357,9 +1357,16 @@ public HFileBlock readBlock(long dataBlockOffset, long

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2114510060 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28598 Fixes NPE for writer object access in AsyncFSWAL#closeWriter [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5907: URL: https://github.com/apache/hbase/pull/5907#issuecomment-2114252818 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2114231887 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2114226964 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28501 Support non-SPNEGO authentication methods and implement s… [hbase]

2024-05-16 Thread via GitHub
stoty commented on PR #5881: URL: https://github.com/apache/hbase/pull/5881#issuecomment-2114199403 I have forgot to add the signed-off header. I will add it for the backports. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2114199013 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

Re: [PR] HBASE-28501 Support non-SPNEGO authentication methods and implement s… [hbase]

2024-05-16 Thread via GitHub
stoty merged PR #5881: URL: https://github.com/apache/hbase/pull/5881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] HBASE-28598 Fixes NPE for writer object access in AsyncFSWAL#closeWriter [hbase]

2024-05-16 Thread via GitHub
vineet4008 opened a new pull request, #5907: URL: https://github.com/apache/hbase/pull/5907 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] HBASE-28502 Cleanup old backup manifest logic (#5871) [hbase]

2024-05-16 Thread via GitHub
ndimiduk merged PR #5902: URL: https://github.com/apache/hbase/pull/5902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Backport "HBASE-28502 Cleanup old backup manifest logic (#5871)" to branch-2 [hbase]

2024-05-16 Thread via GitHub
ndimiduk merged PR #5901: URL: https://github.com/apache/hbase/pull/5901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Backport "HBASE-28502 Cleanup old backup manifest logic (#5871)" to branch-3 [hbase]

2024-05-16 Thread via GitHub
ndimiduk merged PR #5900: URL: https://github.com/apache/hbase/pull/5900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2114088475 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2114088119 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2114088089 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2114087829 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-15 Thread via GitHub
Apache9 commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1602580409 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileManager.java: ## @@ -50,15 +50,15 @@ public interface StoreFileManager { */

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2113965661 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2113965652 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2113965649 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2113965547 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-15 Thread via GitHub
kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1602564157 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileManager.java: ## @@ -50,15 +50,15 @@ public interface StoreFileManager { */

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-15 Thread via GitHub
kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1602560727 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java: ## @@ -48,17 +52,38 @@ class DefaultStoreFileManager implements

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2113930166 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113502179 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s |

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113496816 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113495636 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s |

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113491628 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s |

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-15 Thread via GitHub
DieterDP-ng commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113452806 @rmdmattingly rebased the PR after addressing the `getAncestors` concerns. The test failure in previous version is a flaky test, it also occurs in

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5903: URL: https://github.com/apache/hbase/pull/5903#issuecomment-2113412114 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5903: URL: https://github.com/apache/hbase/pull/5903#issuecomment-2113365350 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5903: URL: https://github.com/apache/hbase/pull/5903#issuecomment-2113363345 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-15 Thread via GitHub
virajjasani merged PR #5899: URL: https://github.com/apache/hbase/pull/5899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-15 Thread via GitHub
virajjasani merged PR #5307: URL: https://github.com/apache/hbase/pull/5307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2113103339 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2113102062 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2113097479 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2113094212 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2113070051 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2113063306 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s |

Re: [PR] HBASE-28595: client side fix for partial results when exception from scan RPC is lost [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5904: URL: https://github.com/apache/hbase/pull/5904#issuecomment-2113050194 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2113047961 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s |

Re: [PR] HBASE-28595: client side fix for partial results when exception from scan RPC is lost [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5904: URL: https://github.com/apache/hbase/pull/5904#issuecomment-2113044620 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28595: client side fix for partial results when exception from scan RPC is lost [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5904: URL: https://github.com/apache/hbase/pull/5904#issuecomment-2113039642 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-15 Thread via GitHub
wchevreuil commented on code in PR #5905: URL: https://github.com/apache/hbase/pull/5905#discussion_r1601975139 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java: ## @@ -1357,9 +1357,16 @@ public HFileBlock readBlock(long dataBlockOffset, long

Re: [PR] HBASE-28595: client side fix for partial results when exception from scan RPC is lost [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5904: URL: https://github.com/apache/hbase/pull/5904#issuecomment-2113000337 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28595: client side fix for partial results when exception from scan RPC is lost [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5904: URL: https://github.com/apache/hbase/pull/5904#issuecomment-2112989343 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28595: client side fix for partial results when exception from scan RPC is lost [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5904: URL: https://github.com/apache/hbase/pull/5904#issuecomment-2112982784 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5903: URL: https://github.com/apache/hbase/pull/5903#issuecomment-2112980831 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[PR] HBASE-28595: client side fix for partial results when exception from scan RPC is lost [hbase]

2024-05-15 Thread via GitHub
csringhofer opened a new pull request, #5904: URL: https://github.com/apache/hbase/pull/5904 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] HBASE-28502 Cleanup old backup manifest logic (#5871) [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5902: URL: https://github.com/apache/hbase/pull/5902#issuecomment-2112909831 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28502 Cleanup old backup manifest logic (#5871) [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5902: URL: https://github.com/apache/hbase/pull/5902#issuecomment-2112905858 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

[PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-15 Thread via GitHub
Apache9 opened a new pull request, #5903: URL: https://github.com/apache/hbase/pull/5903 … when closing unused region replicas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Backport "HBASE-28502 Cleanup old backup manifest logic (#5871)" to branch-2 [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5901: URL: https://github.com/apache/hbase/pull/5901#issuecomment-2112896360 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s |

Re: [PR] HBASE-28502 Cleanup old backup manifest logic (#5871) [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5902: URL: https://github.com/apache/hbase/pull/5902#issuecomment-2112892247 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s |

Re: [PR] Backport "HBASE-28502 Cleanup old backup manifest logic (#5871)" to branch-2 [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5901: URL: https://github.com/apache/hbase/pull/5901#issuecomment-2112891097 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s |

Re: [PR] Backport "HBASE-28502 Cleanup old backup manifest logic (#5871)" to branch-3 [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5900: URL: https://github.com/apache/hbase/pull/5900#issuecomment-2112877030 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] Backport "HBASE-28502 Cleanup old backup manifest logic (#5871)" to branch-3 [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5900: URL: https://github.com/apache/hbase/pull/5900#issuecomment-2112876132 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] Backport "HBASE-28502 Cleanup old backup manifest logic (#5871)" to branch-3 [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5900: URL: https://github.com/apache/hbase/pull/5900#issuecomment-2112874843 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] Backport "HBASE-28502 Cleanup old backup manifest logic (#5871)" to branch-2 [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5901: URL: https://github.com/apache/hbase/pull/5901#issuecomment-2112857551 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] Backport "HBASE-28502 Cleanup old backup manifest logic (#5871)" to branch-3 [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5900: URL: https://github.com/apache/hbase/pull/5900#issuecomment-2112856270 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s |

[PR] HBASE-28502 Cleanup old backup manifest logic (#5871) [hbase]

2024-05-15 Thread via GitHub
ndimiduk opened a new pull request, #5902: URL: https://github.com/apache/hbase/pull/5902 In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-15 Thread via GitHub
jhungund commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1601814522 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo hFileInfo,

[PR] Backport "HBASE-28502 Cleanup old backup manifest logic (#5871)" to branch-2 [hbase]

2024-05-15 Thread via GitHub
ndimiduk opened a new pull request, #5901: URL: https://github.com/apache/hbase/pull/5901 In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete

[PR] Backport "HBASE-28502 Cleanup old backup manifest logic (#5871)" to branch-3 [hbase]

2024-05-15 Thread via GitHub
ndimiduk opened a new pull request, #5900: URL: https://github.com/apache/hbase/pull/5900 In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete

Re: [PR] HBASE-28502 Cleanup old backup manifest logic [hbase]

2024-05-15 Thread via GitHub
ndimiduk commented on PR #5871: URL: https://github.com/apache/hbase/pull/5871#issuecomment-2112749361 Merged to master. I'll start backporting and holler if I have any issues. Thanks for the contribution @DieterDP-ng and for the review @rmdmattingly ! -- This is an automated message

Re: [PR] HBASE-28502 Cleanup old backup manifest logic [hbase]

2024-05-15 Thread via GitHub
ndimiduk merged PR #5871: URL: https://github.com/apache/hbase/pull/5871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-15 Thread via GitHub
wchevreuil commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1601716156 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo

Re: [PR] HBASE-28501 Support non-SPNEGO authentication methods and implement s… [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5881: URL: https://github.com/apache/hbase/pull/5881#issuecomment-2112453219 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28501 Support non-SPNEGO authentication methods and implement s… [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5881: URL: https://github.com/apache/hbase/pull/5881#issuecomment-2112452475 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

Re: [PR] HBASE-28501 Support non-SPNEGO authentication methods and implement s… [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5881: URL: https://github.com/apache/hbase/pull/5881#issuecomment-2112451591 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28501 Support non-SPNEGO authentication methods and implement s… [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5881: URL: https://github.com/apache/hbase/pull/5881#issuecomment-2112448624 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 16s |

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-15 Thread via GitHub
2005hithlj commented on code in PR #5893: URL: https://github.com/apache/hbase/pull/5893#discussion_r1601578510 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java: ## @@ -162,8 +162,8 @@ public void testSelectiveFlushWhenEnabled()

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-15 Thread via GitHub
2005hithlj commented on code in PR #5893: URL: https://github.com/apache/hbase/pull/5893#discussion_r1601555207 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java: ## @@ -686,12 +686,6 @@ public void abortCacheFlush(byte[]

Re: [PR] HBASE-28501 Support non-SPNEGO authentication methods and implement s… [hbase]

2024-05-15 Thread via GitHub
stoty commented on code in PR #5881: URL: https://github.com/apache/hbase/pull/5881#discussion_r1601547952 ## hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/Client.java: ## @@ -377,19 +476,59 @@ public HttpResponse execute(Cluster cluster, HttpUriRequest method,

Re: [PR] HBASE-28501 Support non-SPNEGO authentication methods and implement s… [hbase]

2024-05-15 Thread via GitHub
stoty commented on code in PR #5881: URL: https://github.com/apache/hbase/pull/5881#discussion_r1601523125 ## hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/Client.java: ## @@ -176,22 +229,56 @@ public Client(Cluster cluster, Configuration conf, boolean

Re: [PR] HBASE-28501 Support non-SPNEGO authentication methods and implement s… [hbase]

2024-05-15 Thread via GitHub
petersomogyi commented on code in PR #5881: URL: https://github.com/apache/hbase/pull/5881#discussion_r1601501495 ## hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/Client.java: ## @@ -377,19 +476,59 @@ public HttpResponse execute(Cluster cluster, HttpUriRequest

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-15 Thread via GitHub
vinayakphegde commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1601501477 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-15 Thread via GitHub
jhungund commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1601360335 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo hFileInfo,

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-15 Thread via GitHub
jhungund commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1601360335 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo hFileInfo,

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-15 Thread via GitHub
jhungund commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1601360335 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo hFileInfo,

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-15 Thread via GitHub
jhungund commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1601360335 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo hFileInfo,

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-15 Thread via GitHub
vinayakphegde commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1601338343 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-15 Thread via GitHub
jhungund commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1601144798 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo hFileInfo,

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-15 Thread via GitHub
jhungund commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1601142345 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo hFileInfo,

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-15 Thread via GitHub
Apache9 commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111814481 > > > Both approaches have their own drawbacks. I still wonder what we can do here for ConnectionRegistry timeouts, given that Zookeeper response might never come back for timer to be

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-15 Thread via GitHub
q977734161 commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2111806293 > Ping @q977734161 ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-15 Thread via GitHub
virajjasani commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111800160 > > Both approaches have their own drawbacks. I still wonder what we can do here for ConnectionRegistry timeouts, given that Zookeeper response might never come back for timer to be

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-15 Thread via GitHub
Apache9 commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1601087841 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java: ## @@ -48,17 +52,38 @@ class DefaultStoreFileManager implements

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-15 Thread via GitHub
Apache9 commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111748836 > Both approaches have their own drawbacks. I still wonder what we can do here for ConnectionRegistry timeouts, given that Zookeeper response might never come back for timer to be

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-15 Thread via GitHub
virajjasani commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111746391 Both approaches have their own drawbacks. I still wonder what we can do here for ConnectionRegistry timeouts, given that Zookeeper response might never come back for timer to be

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-14 Thread via GitHub
apurtell commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2111577285 @Apache9 I think there was only one issue considered a blocker and @kadirozde has addressed it. There are three failing tests in the precommit but all are related to quotas so are

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-14 Thread via GitHub
Apache9 commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111493641 > > Here you just submit the async zk operation in the timer task, and then in the callback, you check reschedule the timer task and then you have a chance to check timeout, but what if

<    2   3   4   5   6   7   8   9   10   11   >