Apache-HBase commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-2115125977
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
jhungund commented on code in PR #5908:
URL: https://github.com/apache/hbase/pull/5908#discussion_r1603223519
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java:
##
@@ -553,16 +565,26 @@ private void writeInlineBlocks(boolean closing) throws
Apache-HBase commented on PR #5907:
URL: https://github.com/apache/hbase/pull/5907#issuecomment-2115005224
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
Apache-HBase commented on PR #5907:
URL: https://github.com/apache/hbase/pull/5907#issuecomment-2114941818
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5905:
URL: https://github.com/apache/hbase/pull/5905#issuecomment-2114890243
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5905:
URL: https://github.com/apache/hbase/pull/5905#issuecomment-2114854114
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 20s |
Apache-HBase commented on PR #5905:
URL: https://github.com/apache/hbase/pull/5905#issuecomment-2114812889
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
jhungund commented on code in PR #5905:
URL: https://github.com/apache/hbase/pull/5905#discussion_r1602908275
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java:
##
@@ -1357,9 +1357,16 @@ public HFileBlock readBlock(long dataBlockOffset, long
Apache-HBase commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-2114510060
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache-HBase commented on PR #5907:
URL: https://github.com/apache/hbase/pull/5907#issuecomment-2114252818
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
Apache-HBase commented on PR #5883:
URL: https://github.com/apache/hbase/pull/5883#issuecomment-2114231887
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
Apache-HBase commented on PR #5883:
URL: https://github.com/apache/hbase/pull/5883#issuecomment-2114226964
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
stoty commented on PR #5881:
URL: https://github.com/apache/hbase/pull/5881#issuecomment-2114199403
I have forgot to add the signed-off header.
I will add it for the backports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Apache-HBase commented on PR #5883:
URL: https://github.com/apache/hbase/pull/5883#issuecomment-2114199013
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s |
stoty merged PR #5881:
URL: https://github.com/apache/hbase/pull/5881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vineet4008 opened a new pull request, #5907:
URL: https://github.com/apache/hbase/pull/5907
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
ndimiduk merged PR #5902:
URL: https://github.com/apache/hbase/pull/5902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ndimiduk merged PR #5901:
URL: https://github.com/apache/hbase/pull/5901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ndimiduk merged PR #5900:
URL: https://github.com/apache/hbase/pull/5900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-2114088475
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache-HBase commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-2114088119
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache-HBase commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-2114088089
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache-HBase commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-2114087829
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache9 commented on code in PR #5545:
URL: https://github.com/apache/hbase/pull/5545#discussion_r1602580409
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileManager.java:
##
@@ -50,15 +50,15 @@ public interface StoreFileManager {
*/
Apache-HBase commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-2113965661
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache-HBase commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-2113965652
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache-HBase commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-2113965649
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache-HBase commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-2113965547
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
kadirozde commented on code in PR #5545:
URL: https://github.com/apache/hbase/pull/5545#discussion_r1602564157
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileManager.java:
##
@@ -50,15 +50,15 @@ public interface StoreFileManager {
*/
kadirozde commented on code in PR #5545:
URL: https://github.com/apache/hbase/pull/5545#discussion_r1602560727
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java:
##
@@ -48,17 +52,38 @@ class DefaultStoreFileManager implements
Apache-HBase commented on PR #5883:
URL: https://github.com/apache/hbase/pull/5883#issuecomment-2113930166
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5868:
URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113502179
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 4s |
Apache-HBase commented on PR #5868:
URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113496816
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s |
Apache-HBase commented on PR #5868:
URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113495636
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 13s |
Apache-HBase commented on PR #5868:
URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113491628
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 5s |
DieterDP-ng commented on PR #5868:
URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113452806
@rmdmattingly rebased the PR after addressing the `getAncestors` concerns.
The test failure in previous version is a flaky test, it also occurs in
Apache-HBase commented on PR #5903:
URL: https://github.com/apache/hbase/pull/5903#issuecomment-2113412114
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5903:
URL: https://github.com/apache/hbase/pull/5903#issuecomment-2113365350
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5903:
URL: https://github.com/apache/hbase/pull/5903#issuecomment-2113363345
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
virajjasani merged PR #5899:
URL: https://github.com/apache/hbase/pull/5899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
virajjasani merged PR #5307:
URL: https://github.com/apache/hbase/pull/5307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on PR #5906:
URL: https://github.com/apache/hbase/pull/5906#issuecomment-2113103339
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5906:
URL: https://github.com/apache/hbase/pull/5906#issuecomment-2113102062
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5906:
URL: https://github.com/apache/hbase/pull/5906#issuecomment-2113097479
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5906:
URL: https://github.com/apache/hbase/pull/5906#issuecomment-2113094212
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
Apache-HBase commented on PR #5905:
URL: https://github.com/apache/hbase/pull/5905#issuecomment-2113070051
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 54s |
Apache-HBase commented on PR #5905:
URL: https://github.com/apache/hbase/pull/5905#issuecomment-2113063306
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 50s |
Apache-HBase commented on PR #5904:
URL: https://github.com/apache/hbase/pull/5904#issuecomment-2113050194
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
Apache-HBase commented on PR #5905:
URL: https://github.com/apache/hbase/pull/5905#issuecomment-2113047961
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 13s |
Apache-HBase commented on PR #5904:
URL: https://github.com/apache/hbase/pull/5904#issuecomment-2113044620
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
Apache-HBase commented on PR #5904:
URL: https://github.com/apache/hbase/pull/5904#issuecomment-2113039642
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
wchevreuil commented on code in PR #5905:
URL: https://github.com/apache/hbase/pull/5905#discussion_r1601975139
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java:
##
@@ -1357,9 +1357,16 @@ public HFileBlock readBlock(long dataBlockOffset, long
Apache-HBase commented on PR #5904:
URL: https://github.com/apache/hbase/pull/5904#issuecomment-2113000337
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5904:
URL: https://github.com/apache/hbase/pull/5904#issuecomment-2112989343
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 44s |
Apache-HBase commented on PR #5904:
URL: https://github.com/apache/hbase/pull/5904#issuecomment-2112982784
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5903:
URL: https://github.com/apache/hbase/pull/5903#issuecomment-2112980831
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
csringhofer opened a new pull request, #5904:
URL: https://github.com/apache/hbase/pull/5904
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
Apache-HBase commented on PR #5902:
URL: https://github.com/apache/hbase/pull/5902#issuecomment-2112909831
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
Apache-HBase commented on PR #5902:
URL: https://github.com/apache/hbase/pull/5902#issuecomment-2112905858
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
Apache9 opened a new pull request, #5903:
URL: https://github.com/apache/hbase/pull/5903
… when closing unused region replicas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Apache-HBase commented on PR #5901:
URL: https://github.com/apache/hbase/pull/5901#issuecomment-2112896360
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 10s |
Apache-HBase commented on PR #5902:
URL: https://github.com/apache/hbase/pull/5902#issuecomment-2112892247
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 50s |
Apache-HBase commented on PR #5901:
URL: https://github.com/apache/hbase/pull/5901#issuecomment-2112891097
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 8s |
Apache-HBase commented on PR #5900:
URL: https://github.com/apache/hbase/pull/5900#issuecomment-2112877030
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5900:
URL: https://github.com/apache/hbase/pull/5900#issuecomment-2112876132
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5900:
URL: https://github.com/apache/hbase/pull/5900#issuecomment-2112874843
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache-HBase commented on PR #5901:
URL: https://github.com/apache/hbase/pull/5901#issuecomment-2112857551
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5900:
URL: https://github.com/apache/hbase/pull/5900#issuecomment-2112856270
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 14s |
ndimiduk opened a new pull request, #5902:
URL: https://github.com/apache/hbase/pull/5902
In older versions of HBase's backup mechanism, a manifest was written per
table being backed up. This was since refactored to one manifest per backup,
but the manifest code was not updated. A concrete
jhungund commented on code in PR #5866:
URL: https://github.com/apache/hbase/pull/5866#discussion_r1601814522
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo
hFileInfo,
ndimiduk opened a new pull request, #5901:
URL: https://github.com/apache/hbase/pull/5901
In older versions of HBase's backup mechanism, a manifest was written per
table being backed up. This was since refactored to one manifest per backup,
but the manifest code was not updated. A concrete
ndimiduk opened a new pull request, #5900:
URL: https://github.com/apache/hbase/pull/5900
In older versions of HBase's backup mechanism, a manifest was written per
table being backed up. This was since refactored to one manifest per backup,
but the manifest code was not updated. A concrete
ndimiduk commented on PR #5871:
URL: https://github.com/apache/hbase/pull/5871#issuecomment-2112749361
Merged to master. I'll start backporting and holler if I have any issues.
Thanks for the contribution @DieterDP-ng and for the review @rmdmattingly !
--
This is an automated message
ndimiduk merged PR #5871:
URL: https://github.com/apache/hbase/pull/5871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
wchevreuil commented on code in PR #5866:
URL: https://github.com/apache/hbase/pull/5866#discussion_r1601716156
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo
Apache-HBase commented on PR #5881:
URL: https://github.com/apache/hbase/pull/5881#issuecomment-2112453219
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5881:
URL: https://github.com/apache/hbase/pull/5881#issuecomment-2112452475
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #5881:
URL: https://github.com/apache/hbase/pull/5881#issuecomment-2112451591
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5881:
URL: https://github.com/apache/hbase/pull/5881#issuecomment-2112448624
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 16s |
2005hithlj commented on code in PR #5893:
URL: https://github.com/apache/hbase/pull/5893#discussion_r1601578510
##
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java:
##
@@ -162,8 +162,8 @@ public void testSelectiveFlushWhenEnabled()
2005hithlj commented on code in PR #5893:
URL: https://github.com/apache/hbase/pull/5893#discussion_r1601555207
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##
@@ -686,12 +686,6 @@ public void abortCacheFlush(byte[]
stoty commented on code in PR #5881:
URL: https://github.com/apache/hbase/pull/5881#discussion_r1601547952
##
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/Client.java:
##
@@ -377,19 +476,59 @@ public HttpResponse execute(Cluster cluster,
HttpUriRequest method,
stoty commented on code in PR #5881:
URL: https://github.com/apache/hbase/pull/5881#discussion_r1601523125
##
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/Client.java:
##
@@ -176,22 +229,56 @@ public Client(Cluster cluster, Configuration conf,
boolean
petersomogyi commented on code in PR #5881:
URL: https://github.com/apache/hbase/pull/5881#discussion_r1601501495
##
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/Client.java:
##
@@ -377,19 +476,59 @@ public HttpResponse execute(Cluster cluster,
HttpUriRequest
vinayakphegde commented on code in PR #5866:
URL: https://github.com/apache/hbase/pull/5866#discussion_r1601501477
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo
jhungund commented on code in PR #5866:
URL: https://github.com/apache/hbase/pull/5866#discussion_r1601360335
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo
hFileInfo,
jhungund commented on code in PR #5866:
URL: https://github.com/apache/hbase/pull/5866#discussion_r1601360335
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo
hFileInfo,
jhungund commented on code in PR #5866:
URL: https://github.com/apache/hbase/pull/5866#discussion_r1601360335
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo
hFileInfo,
jhungund commented on code in PR #5866:
URL: https://github.com/apache/hbase/pull/5866#discussion_r1601360335
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo
hFileInfo,
vinayakphegde commented on code in PR #5866:
URL: https://github.com/apache/hbase/pull/5866#discussion_r1601338343
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo
jhungund commented on code in PR #5866:
URL: https://github.com/apache/hbase/pull/5866#discussion_r1601144798
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo
hFileInfo,
jhungund commented on code in PR #5866:
URL: https://github.com/apache/hbase/pull/5866#discussion_r1601142345
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo
hFileInfo,
Apache9 commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111814481
> > > Both approaches have their own drawbacks. I still wonder what we can
do here for ConnectionRegistry timeouts, given that Zookeeper response might
never come back for timer to be
q977734161 commented on PR #5883:
URL: https://github.com/apache/hbase/pull/5883#issuecomment-2111806293
> Ping @q977734161
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
virajjasani commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111800160
> > Both approaches have their own drawbacks. I still wonder what we can do
here for ConnectionRegistry timeouts, given that Zookeeper response might never
come back for timer to be
Apache9 commented on code in PR #5545:
URL: https://github.com/apache/hbase/pull/5545#discussion_r1601087841
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java:
##
@@ -48,17 +52,38 @@ class DefaultStoreFileManager implements
Apache9 commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111748836
> Both approaches have their own drawbacks. I still wonder what we can do
here for ConnectionRegistry timeouts, given that Zookeeper response might never
come back for timer to be
virajjasani commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111746391
Both approaches have their own drawbacks.
I still wonder what we can do here for ConnectionRegistry timeouts, given
that Zookeeper response might never come back for timer to be
apurtell commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-2111577285
@Apache9 I think there was only one issue considered a blocker and
@kadirozde has addressed it. There are three failing tests in the precommit but
all are related to quotas so are
Apache9 commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111493641
> > Here you just submit the async zk operation in the timer task, and then
in the callback, you check reschedule the timer task and then you have a chance
to check timeout, but what if
601 - 700 of 13820 matches
Mail list logo