Apache9 commented on a change in pull request #4088:
URL: https://github.com/apache/hbase/pull/4088#discussion_r800067794



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
##########
@@ -222,6 +223,7 @@ public void drop() {
       call.setResponse(null, null, CALL_DROPPED_EXCEPTION, "Call dropped, 
server "
         + (address != null ? address : "(channel closed)") + " is overloaded, 
please retry.");
       call.sendResponseIfReady();
+      this.rpcServer.getMetrics().exception(CALL_DROPPED_EXCEPTION);

Review comment:
       Where do we call this method in the past? Will this introduce double 
accounting?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to