[GitHub] [hbase] Apache9 commented on pull request #2569: HBASE-25206 Data loss can happen if a cloned table loses original spl…

2020-10-20 Thread GitBox
Apache9 commented on pull request #2569: URL: https://github.com/apache/hbase/pull/2569#issuecomment-712919691 Oh it is in HBASE-14614, where the patch is several MB, which means we can not know the actual reason on why the code is like this... If you do not mind, I plan to open an

[GitHub] [hbase] Apache9 commented on pull request #2569: HBASE-25206 Data loss can happen if a cloned table loses original spl…

2020-10-20 Thread GitBox
Apache9 commented on pull request #2569: URL: https://github.com/apache/hbase/pull/2569#issuecomment-712916667 Oh the logic is already there before HBASE-23187. In HBASE-23187 we just add checks for RegionInfo. Let me check for earlier changes.

[GitHub] [hbase] Apache9 commented on pull request #2569: HBASE-25206 Data loss can happen if a cloned table loses original spl…

2020-10-20 Thread GitBox
Apache9 commented on pull request #2569: URL: https://github.com/apache/hbase/pull/2569#issuecomment-712914659 They are added by this issue. https://issues.apache.org/jira/browse/HBASE-23187 Let me take a look on the PR about why we add these checks.