JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position
of WALs currently being replicated
URL: https://github.com/apache/hbase/pull/749#issuecomment-564501788
> We might want to expose ReplicationSourceWALReaderThread.lastReadPosition,
in order to eventually have
JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position
of WALs currently being replicated
URL: https://github.com/apache/hbase/pull/749#issuecomment-558894591
No further comments on this PR? If any lacks of description or something for
code reviews, please let me
JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position
of WALs currently being replicated
URL: https://github.com/apache/hbase/pull/749#issuecomment-554897893
Failed tests are unrelated to this PR, and not reproduced in my local env.
JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position
of WALs currently being replicated
URL: https://github.com/apache/hbase/pull/749#issuecomment-550234489
JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position
of WALs currently being replicated
URL: https://github.com/apache/hbase/pull/749#issuecomment-548307708
Thanks for the review!
> there are few variable/method renaming, moving to different class, just
JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position
of WALs currently being replicated
URL: https://github.com/apache/hbase/pull/749#issuecomment-547708224
added a minor fix in test code and rebased.
JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position
of WALs currently being replicated
URL: https://github.com/apache/hbase/pull/749#issuecomment-545873597
I made a typo when i fixed checkstyle warnings
JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position
of WALs currently being replicated
URL: https://github.com/apache/hbase/pull/749#issuecomment-545712558
Failed tests is not related to this PR. Tests has broken since #745, and
Those will be fixed at #748.
