NihalJain commented on PR #5346:
URL: https://github.com/apache/hbase/pull/5346#issuecomment-1715376070
Thanks for making your 1st contribution in Apache HBase @nikita15p :)
Also, could you please raise a backport PR for branch-2 (since the failure
is only relevant for branch-2 as
NihalJain commented on PR #5346:
URL: https://github.com/apache/hbase/pull/5346#issuecomment-1709880884
> I suspect https://issues.apache.org/jira/browse/HBASE-22244 /
https://github.com/apache/hbase/pull/155 might have broken compatibility on
what can be passed to ExecutorService as the
NihalJain commented on PR #5346:
URL: https://github.com/apache/hbase/pull/5346#issuecomment-1686910826
Overall the change in this PR looks good to me, if above concern is not an
issue. Good catch @nikita15p :)
--
This is an automated message from the Apache Git Service.
To respond to
NihalJain commented on PR #5346:
URL: https://github.com/apache/hbase/pull/5346#issuecomment-1686890438
Hi @Apache9 I suspect https://issues.apache.org/jira/browse/HBASE-22244 /
https://github.com/apache/hbase/pull/155 might have broken compatibility as the
failure of this example client
NihalJain commented on PR #5346:
URL: https://github.com/apache/hbase/pull/5346#issuecomment-1673477675
Thank you @nikita15p for raising you 1st PR in HBase. It would be great if
you could give some context for others on how the change fixes the issue and/or
why this change is needed.
--
