[GitHub] [hbase] Reidddddd commented on a change in pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

Reidd commented on a change in pull request #2941: URL: https://github.com/apache/hbase/pull/2941#discussion_r652491718 ## File path: hbase-thrift/src/main/resources/hbase-webapps/thrift/thrift.jsp ## @@ -93,11 +98,6 @@ String framed = conf.get("hbase.regionserver.thrift.fr

[GitHub] [hbase] Reidddddd commented on a change in pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

Reidd commented on a change in pull request #2941: URL: https://github.com/apache/hbase/pull/2941#discussion_r652490713 ## File path: hbase-thrift/src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift ## @@ -296,6 +318,187 @@ enum TCompareOp { NO_OP = 6 } +

[GitHub] [hbase] Reidddddd commented on a change in pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

Reidd commented on a change in pull request #2941: URL: https://github.com/apache/hbase/pull/2941#discussion_r652488577 ## File path: hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java ## @@ -1,40 +1,49 @@ /* - * Copyright The Apache So

[GitHub] [hbase] Reidddddd commented on a change in pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

Reidd commented on a change in pull request #2941: URL: https://github.com/apache/hbase/pull/2941#discussion_r652487758 ## File path: hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [hbase] Reidddddd commented on a change in pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

Reidd commented on a change in pull request #2941: URL: https://github.com/apache/hbase/pull/2941#discussion_r652487568 ## File path: hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [hbase] Reidddddd commented on a change in pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

Reidd commented on a change in pull request #2941: URL: https://github.com/apache/hbase/pull/2941#discussion_r652485054 ## File path: hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [hbase] Reidddddd commented on a change in pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

Reidd commented on a change in pull request #2941: URL: https://github.com/apache/hbase/pull/2941#discussion_r652483439 ## File path: hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java ## @@ -97,8 +93,13 @@ import static org.apac

[GitHub] [hbase] Reidddddd commented on a change in pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

Reidd commented on a change in pull request #2941: URL: https://github.com/apache/hbase/pull/2941#discussion_r652482730 ## File path: hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java ## @@ -1465,37 +1465,6 @@ public void testChe

[GitHub] [hbase] Reidddddd commented on a change in pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

Reidd commented on a change in pull request #2941: URL: https://github.com/apache/hbase/pull/2941#discussion_r651681985 ## File path: hbase-thrift/src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift ## @@ -973,4 +965,11 @@ service Hbase { /** Mutation attri