[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r939578238 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r938827967 ## hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestNettyIPCSsl.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r935923001 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java: ## @@ -0,0 +1,394 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r935921511 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java: ## @@ -0,0 +1,394 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r935921511 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java: ## @@ -0,0 +1,394 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r935918622 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java: ## @@ -0,0 +1,346 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r935910287 ## hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java: ## @@ -214,4 +227,29 @@ public int getNumOpenConnections() { // allChannels also

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r935909549 ## hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java: ## @@ -106,6 +116,9 @@ protected void initChannel(Channel ch) throws Exception {

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r935908317 ## hbase-client/src/test/java/org/apache/hadoop/hbase/ipc/TestNettyRpcConnection.java: ## @@ -57,7 +58,7 @@ public class TestNettyRpcConnection { private static

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r935908527 ## hbase-it/src/test/java/org/apache/hadoop/hbase/ipc/IntegrationTestRpcClient.java: ## @@ -66,7 +67,8 @@ public IntegrationTestRpcClient() { conf =

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r934926781 ## hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcClient.java: ## @@ -39,14 +49,20 @@ @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r934926611 ## hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java: ## @@ -107,7 +108,8 @@ protected abstract RpcServer createRpcServer(final Server server,

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r934917330 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java: ## @@ -0,0 +1,346 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r934916264 ## hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcClient.java: ## @@ -81,4 +99,43 @@ protected void closeInternal() { group.shutdownGracefully();

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r934915278 ## hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java: ## @@ -276,17 +286,28 @@ private void connect() throws UnknownHostException {

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r934521561 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java: ## @@ -0,0 +1,394 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r934521324 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java: ## @@ -0,0 +1,394 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r934520607 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java: ## @@ -0,0 +1,394 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r934521107 ## hbase-server/src/test/resources/log4j2.properties: ## @@ -0,0 +1,137 @@ +#/** Review Comment: This file has been added by mistake. Removed. -- This is an

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r934519446 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java: ## @@ -0,0 +1,394 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r934519086 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java: ## @@ -0,0 +1,394 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r934518687 ## hbase-common/src/main/java/org/apache/hadoop/hbase/exceptions/X509Exception.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r934518340 ## hbase-common/src/main/java/org/apache/hadoop/hbase/exceptions/X509Exception.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r934518047 ## hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java: ## @@ -157,11 +167,11 @@ public void cleanupConnection() { private void

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r934516447 ## hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java: ## @@ -296,6 +317,32 @@ public void operationComplete(ChannelFuture future) throws

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r934516186 ## hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java: ## @@ -90,6 +94,9 @@ class NettyRpcConnection extends RpcConnection { // connection

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r934492668 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/KeyStoreFileType.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [hbase] anmolnar commented on a diff in pull request #4666: HBASE-26666 Add native TLS encryption support to RPC server/client

anmolnar commented on code in PR #4666: URL: https://github.com/apache/hbase/pull/4666#discussion_r934465287 ## hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcClient.java: ## @@ -81,4 +96,31 @@ protected void closeInternal() { group.shutdownGracefully();