[GitHub] [hbase] anoopsjohn commented on pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-04 Thread GitBox
anoopsjohn commented on pull request #3318: URL: https://github.com/apache/hbase/pull/3318#issuecomment-853616762 Thanks Duo. Ya I got it.. Was looking around that lastCleanCell ref as that was initially been referred. I got it very clear from @mymeiyi reply. Ya change looks good.

[GitHub] [hbase] anoopsjohn commented on pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-03 Thread GitBox
anoopsjohn commented on pull request #3318: URL: https://github.com/apache/hbase/pull/3318#issuecomment-853616762 Thanks Duo. Ya I got it.. Was looking around that lastCleanCell ref as that was initially been referred. I got it very clear from @mymeiyi reply. Ya change looks good.

[GitHub] [hbase] anoopsjohn commented on pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-01 Thread GitBox
anoopsjohn commented on pull request #3318: URL: https://github.com/apache/hbase/pull/3318#issuecomment-852002682 So the latest version change is moving the check for possible shipped() called out of the for loop. The cons here is that when we have wide rows with so many cells in it,

[GitHub] [hbase] anoopsjohn commented on pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-05-28 Thread GitBox
anoopsjohn commented on pull request #3318: URL: https://github.com/apache/hbase/pull/3318#issuecomment-850453676 > I write a case how this error could happen in the doc: https://docs.google.com/document/d/1_3HXgOSGHsHFqLiOWUsE3m6pHKjebSwrRObcPTqkSTE/edit?usp=sharing, please have a look,