[GitHub] [hbase] apurtell commented on issue #1084: HBASE-23330: Fix delegation token fetch with MasterRegistry

2020-01-24 Thread GitBox
apurtell commented on issue #1084: HBASE-23330: Fix delegation token fetch with MasterRegistry URL: https://github.com/apache/hbase/pull/1084#issuecomment-578366062 Got tired of waiting for another QA run. Since this is a feature branch I think it's fine to merge now.

[GitHub] [hbase] apurtell commented on issue #1084: HBASE-23330: Fix delegation token fetch with MasterRegistry

2020-01-24 Thread GitBox
apurtell commented on issue #1084: HBASE-23330: Fix delegation token fetch with MasterRegistry URL: https://github.com/apache/hbase/pull/1084#issuecomment-578235767 @bharathv Please push an update that resolves the conflicts.

[GitHub] [hbase] apurtell commented on issue #1084: HBASE-23330: Fix delegation token fetch with MasterRegistry

2020-01-23 Thread GitBox
apurtell commented on issue #1084: HBASE-23330: Fix delegation token fetch with MasterRegistry URL: https://github.com/apache/hbase/pull/1084#issuecomment-577948950 TestFromClientSide is a known issue and the other failure doesn't look related.

[GitHub] [hbase] apurtell commented on issue #1084: HBASE-23330: Fix delegation token fetch with MasterRegistry

2020-01-23 Thread GitBox
apurtell commented on issue #1084: HBASE-23330: Fix delegation token fetch with MasterRegistry URL: https://github.com/apache/hbase/pull/1084#issuecomment-577878959 Changes look fine, waiting on a clean precommit before approval