[GitHub] [hbase] apurtell commented on pull request #2669: HBASE-25292 Improve InetSocketAddress usage discipline

2020-12-04 Thread GitBox
apurtell commented on pull request #2669: URL: https://github.com/apache/hbase/pull/2669#issuecomment-738925992 Thank for for the merge @Apache9 . Let me merge the branch-2 and branch-1 PRs now too. This is an automated

[GitHub] [hbase] apurtell commented on pull request #2669: HBASE-25292 Improve InetSocketAddress usage discipline

2020-11-20 Thread GitBox
apurtell commented on pull request #2669: URL: https://github.com/apache/hbase/pull/2669#issuecomment-731488069 There is plenty of time for review, no worries. Will wait. This is an automated message from the Apache Git

[GitHub] [hbase] apurtell commented on pull request #2669: HBASE-25292 Improve InetSocketAddress usage discipline

2020-11-20 Thread GitBox
apurtell commented on pull request #2669: URL: https://github.com/apache/hbase/pull/2669#issuecomment-731464399 Great, let's set up an online get-together if all are agreeable @dhirajh @liuml07 @Apache9 This is an

[GitHub] [hbase] apurtell commented on pull request #2669: HBASE-25292 Improve InetSocketAddress usage discipline

2020-11-20 Thread GitBox
apurtell commented on pull request #2669: URL: https://github.com/apache/hbase/pull/2669#issuecomment-731265531 @Apache9 if OK with you to use your JIRA contact email I will connect you with the architect at Salesforce leading the HBase on K8S effort (it's not me) and we can maybe the

[GitHub] [hbase] apurtell commented on pull request #2669: HBASE-25292 Improve InetSocketAddress usage discipline

2020-11-19 Thread GitBox
apurtell commented on pull request #2669: URL: https://github.com/apache/hbase/pull/2669#issuecomment-730487149 I decided not to try replacing ISA with Address for bind() use cases. The problem there is it leads to a lot of conversions between Address and ISA, back and forth. Frameworks

[GitHub] [hbase] apurtell commented on pull request #2669: HBASE-25292 Improve InetSocketAddress usage discipline

2020-11-19 Thread GitBox
apurtell commented on pull request #2669: URL: https://github.com/apache/hbase/pull/2669#issuecomment-730480580 > testGetAdminBadHostname() is relevant Yeah, this test is going to have to change or maybe go away. I will look at it.

[GitHub] [hbase] apurtell commented on pull request #2669: HBASE-25292 Improve InetSocketAddress usage discipline

2020-11-18 Thread GitBox
apurtell commented on pull request #2669: URL: https://github.com/apache/hbase/pull/2669#issuecomment-729845443 In the description I said this: > Use of ISA with bind. Typical uses like bindAddress, listenerAddress, initialIsa, or localAddress. >(There is no harm to keep