bbeaudreault commented on PR #4940:
URL: https://github.com/apache/hbase/pull/4940#issuecomment-1384213434
@Apache9 my other PR which does this using ScannerContext is ready for
review. #4967. I'm going to close this PR for now, though may revisit in the
future if we ever need to do
bbeaudreault commented on PR #4940:
URL: https://github.com/apache/hbase/pull/4940#issuecomment-1382611213
I've pushed https://github.com/apache/hbase/pull/4967 which handles this
using ScannerContext. I still need to add tests, but it's working on one of our
test clusters.
--
This is
bbeaudreault commented on PR #4940:
URL: https://github.com/apache/hbase/pull/4940#issuecomment-1378763490
> Maybe a simpler solution is to just return the result(maybe empty) to
client when we have already hold up too many buffers? We have a ScannerContext
to limit the time and size, we
bbeaudreault commented on PR #4940:
URL: https://github.com/apache/hbase/pull/4940#issuecomment-1368330792
When I get back in the office next week, I plan to simplify this a bit by
removing the `retainBlock` stuff. It's an unnecessary optimization on top of
checkpointing and adds a bit of
bbeaudreault commented on PR #4940:
URL: https://github.com/apache/hbase/pull/4940#issuecomment-1366684479
For anyone looking, the current failures are due to my attempt at optionally
enabling this feature. There are some corner cases due to
StoreScanner.resetKVHeap which would be tricky
