[GitHub] [hbase] bharathv commented on pull request #2075: HBASE-24742 Improve performance of SKIP vs SEEK logic.

2020-07-16 Thread GitBox
bharathv commented on pull request #2075: URL: https://github.com/apache/hbase/pull/2075#issuecomment-659540298 Agree that the indents can be fixed separately in the interest of keeping the patch smaller. +1 from my side on the patch.

[GitHub] [hbase] bharathv commented on pull request #2075: HBASE-24742 Improve performance of SKIP vs SEEK logic.

2020-07-15 Thread GitBox
bharathv commented on pull request #2075: URL: https://github.com/apache/hbase/pull/2075#issuecomment-65804 > Just a question: The speed is inline with 1.3? Its within 5-10% bounds based on my preliminary analysis (on my local box, **if this optimization kicks in**). Will have

[GitHub] [hbase] bharathv commented on pull request #2075: HBASE-24742 Improve performance of SKIP vs SEEK logic.

2020-07-15 Thread GitBox
bharathv commented on pull request #2075: URL: https://github.com/apache/hbase/pull/2075#issuecomment-658879791 Looks like branch-1 pre-commit is broken. @Reidd has a patch at #2065. Let me take a look at that. This is