[GitHub] [hbase] brfrn169 commented on issue #647: HBASE-22988 Backport HBASE-11062 "hbtop" to branch-1

2019-09-27 Thread GitBox
brfrn169 commented on issue #647: HBASE-22988 Backport HBASE-11062 "hbtop" to branch-1 URL: https://github.com/apache/hbase/pull/647#issuecomment-535860663 Actually, I'm not sure if we can go ahead and merge the patch or not as the compile and javac errors occurred in the last QA.

[GitHub] [hbase] brfrn169 commented on issue #647: HBASE-22988 Backport HBASE-11062 "hbtop" to branch-1

2019-09-25 Thread GitBox
brfrn169 commented on issue #647: HBASE-22988 Backport HBASE-11062 "hbtop" to branch-1 URL: https://github.com/apache/hbase/pull/647#issuecomment-535052624 I think we can ignore the error-prone waring: ``` [WARNING]

[GitHub] [hbase] brfrn169 commented on issue #647: HBASE-22988 Backport HBASE-11062 "hbtop" to branch-1

2019-09-25 Thread GitBox
brfrn169 commented on issue #647: HBASE-22988 Backport HBASE-11062 "hbtop" to branch-1 URL: https://github.com/apache/hbase/pull/647#issuecomment-534936440 Thank you for reviewing! @Reidd This is an automated message

[GitHub] [hbase] brfrn169 commented on issue #647: HBASE-22988 Backport HBASE-11062 "hbtop" to branch-1

2019-09-25 Thread GitBox
brfrn169 commented on issue #647: HBASE-22988 Backport HBASE-11062 "hbtop" to branch-1 URL: https://github.com/apache/hbase/pull/647#issuecomment-534936171 I changed the commons-lang3 version to 3.8.1 to support java7: https://commons.apache.org/proper/commons-lang/changes-report.html

[GitHub] [hbase] brfrn169 commented on issue #647: HBASE-22988 Backport HBASE-11062 "hbtop" to branch-1

2019-09-23 Thread GitBox
brfrn169 commented on issue #647: HBASE-22988 Backport HBASE-11062 "hbtop" to branch-1 URL: https://github.com/apache/hbase/pull/647#issuecomment-534353097 @Reidd I renamed the test classes. I will file these modifications in Apache Jira to apply them to branch-2s and master.

[GitHub] [hbase] brfrn169 commented on issue #647: HBASE-22988 Backport HBASE-11062 "hbtop" to branch-1

2019-09-20 Thread GitBox
brfrn169 commented on issue #647: HBASE-22988 Backport HBASE-11062 "hbtop" to branch-1 URL: https://github.com/apache/hbase/pull/647#issuecomment-533760057 I don't think we need to rebase the patch because GitHub says `This branch has no conflicts with the base branch`. Waiting for the