[GitHub] [hbase] brfrn169 commented on pull request #2498: HBASE-24996 Support CheckAndMutate in Region.batchMutate()

2020-11-03 Thread GitBox
brfrn169 commented on pull request #2498: URL: https://github.com/apache/hbase/pull/2498#issuecomment-721511433 It looks like this change will make things too complicated and it has big side effects, so I will give it up. Closing it.

[GitHub] [hbase] brfrn169 commented on pull request #2498: HBASE-24996 Support CheckAndMutate in Region.batchMutate()

2020-10-28 Thread GitBox
brfrn169 commented on pull request #2498: URL: https://github.com/apache/hbase/pull/2498#issuecomment-718287389 The failed UT is not related to the patch. It was successful locally. I removed the new additional Scanner things from the patch and add the following document to the

[GitHub] [hbase] brfrn169 commented on pull request #2498: HBASE-24996 Support CheckAndMutate in Region.batchMutate()

2020-10-20 Thread GitBox
brfrn169 commented on pull request #2498: URL: https://github.com/apache/hbase/pull/2498#issuecomment-713179853 Thank you very much! @Apache9 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] brfrn169 commented on pull request #2498: HBASE-24996 Support CheckAndMutate in Region.batchMutate()

2020-10-19 Thread GitBox
brfrn169 commented on pull request #2498: URL: https://github.com/apache/hbase/pull/2498#issuecomment-712087992 @saintstack @Apache9 @joshelser Could you please review this? I want to include this to hbase-2.4 if possible. Thanks.

[GitHub] [hbase] brfrn169 commented on pull request #2498: HBASE-24996 Support CheckAndMutate in Region.batchMutate()

2020-10-12 Thread GitBox
brfrn169 commented on pull request #2498: URL: https://github.com/apache/hbase/pull/2498#issuecomment-707424113 @saintstack @Apache9 @joshelser Could you please review this when you have time? I wrote down the summary of this change in the following comment:

[GitHub] [hbase] brfrn169 commented on pull request #2498: HBASE-24996 Support CheckAndMutate in Region.batchMutate()

2020-10-10 Thread GitBox
brfrn169 commented on pull request #2498: URL: https://github.com/apache/hbase/pull/2498#issuecomment-706534570 @saintstack Thank you very much for reviewing this! I'm working on fixing the test failure in the last QA. Once it's done, will work on your review. Thanks.