[GitHub] [hbase] bsglz commented on pull request #2044: HBASE-24709 Support MoveCostFunction use a lower multiplier in offpea…

2020-07-18 Thread GitBox
bsglz commented on pull request #2044: URL: https://github.com/apache/hbase/pull/2044#issuecomment-660481996 Seems the test failture unrelated to this PR, could you help to return QA to confirm? Thanks. @virajjasani

[GitHub] [hbase] bsglz commented on pull request #2044: HBASE-24709 Support MoveCostFunction use a lower multiplier in offpea…

2020-07-17 Thread GitBox
bsglz commented on pull request #2044: URL: https://github.com/apache/hbase/pull/2044#issuecomment-660427923 > In my last comment, > > > That said, to remove this.conf = conf dependency, we can get two multipliers from config, and call setMultiplier() accordingly here in cost() by

[GitHub] [hbase] bsglz commented on pull request #2044: HBASE-24709 Support MoveCostFunction use a lower multiplier in offpea…

2020-07-17 Thread GitBox
bsglz commented on pull request #2044: URL: https://github.com/apache/hbase/pull/2044#issuecomment-660410619 The prob is that here we want change the multiplier everyday when the current hour switch between peak and offpeak, there will not a config changed event. Thanks. @virajjasani

[GitHub] [hbase] bsglz commented on pull request #2044: HBASE-24709 Support MoveCostFunction use a lower multiplier in offpea…

2020-07-16 Thread GitBox
bsglz commented on pull request #2044: URL: https://github.com/apache/hbase/pull/2044#issuecomment-659786007 @virajjasani Ping. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hbase] bsglz commented on pull request #2044: HBASE-24709 Support MoveCostFunction use a lower multiplier in offpea…

2020-07-14 Thread GitBox
bsglz commented on pull request #2044: URL: https://github.com/apache/hbase/pull/2044#issuecomment-658504662 @virajjasani Seems no more comments, could you help merge it? Thanks. This is an automated message from the Apache