[GitHub] [hbase] ddupg commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

2020-08-20 Thread GitBox
ddupg commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-677997250 > Thanks @ddupg. One quick question, will the new UT fail without changes in refreshSources()? Just want to make sure that the UT really does its job. +1 pending on your answer.

[GitHub] [hbase] ddupg commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

2020-08-20 Thread GitBox
ddupg commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-677355961 > Add a UT for this case? Thank @huaxiangsun for reviewing, I've added an UT for this case. This is an

[GitHub] [hbase] ddupg commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

2020-08-12 Thread GitBox
ddupg commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-672741439 > Add a UT for this case? OK, I'll try it. This is an automated message from the Apache Git Service. To