joshelser commented on a change in pull request #3104:
URL: https://github.com/apache/hbase/pull/3104#discussion_r604320831
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALFactory.java
##########
@@ -311,7 +311,7 @@ public Reader createReader(final FileSystem fs, final Path
path,
reader.init(fs, path, conf, stream);
return reader;
}
- } catch (IOException e) {
+ } catch (Exception e) {
Review comment:
Catching throwable is usually a smell as it also encompasses
`java.lang.Error`'s. We definitely don't want to catch `Error`'s as we want to
let them propagate as quickly as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
