[GitHub] [hbase] joshelser commented on issue #661: HBASE-15519 Add per-user metrics with lossy counting

2019-10-22 Thread GitBox
joshelser commented on issue #661: HBASE-15519 Add per-user metrics with lossy counting URL: https://github.com/apache/hbase/pull/661#issuecomment-545081071 Going to try this locally -- the default method suggestion above is super-minor. Doing a lot of "try-and-wait" on other stuff today.

[GitHub] [hbase] joshelser commented on issue #661: HBASE-15519 Add per-user metrics with lossy counting

2019-10-18 Thread GitBox
joshelser commented on issue #661: HBASE-15519 Add per-user metrics with lossy counting URL: https://github.com/apache/hbase/pull/661#issuecomment-543765757 Just chatted with Busbey offline. @ankitsinghal is it possible to create a simple configuration property that can disable

[GitHub] [hbase] joshelser commented on issue #661: HBASE-15519 Add per-user metrics with lossy counting

2019-10-15 Thread GitBox
joshelser commented on issue #661: HBASE-15519 Add per-user metrics with lossy counting URL: https://github.com/apache/hbase/pull/661#issuecomment-542404043 Awesome, thanks for sharing the YCSB numbers. This looks OK to me. @busbey do you want me to wait for your review?