[GitHub] [hbase] joshelser commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-09 Thread GitBox
joshelser commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-705757460 > If 'main' or the session name are of no value, just exclude? Yeah, if we're consciously making that change, I can get behind it, too. Something as simple as: `hbase:%03n

[GitHub] [hbase] joshelser commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-08 Thread GitBox
joshelser commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-705757460 > If 'main' or the session name are of no value, just exclude? Yeah, if we're consciously making that change, I can get behind it, too. Something as simple as: `hbase:%03n

[GitHub] [hbase] joshelser commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-07 Thread GitBox
joshelser commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-705123438 > Isn't the pretty print because of HBASE-23930? Aha! Right you are. Sorry for sending you on a goose-chase. -

[GitHub] [hbase] joshelser commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-09-22 Thread GitBox
joshelser commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-696870760 Some subtle changes I'm noticing, the prompt is different. Now.. ``` hbase(#):003:0> ``` and before... ``` hbase(main):001:0> ``` Timestamps are also p

[GitHub] [hbase] joshelser commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-09-22 Thread GitBox
joshelser commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-696870760 Some subtle changes I'm noticing, the prompt is different. Now.. ``` hbase(#):003:0> ``` and before... ``` hbase(main):001:0> ``` Timestamps are also p

[GitHub] [hbase] joshelser commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-09-10 Thread GitBox
joshelser commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-690353142 It looks like unit tests are passing (per the last report). @nkalmar have you launched a local instance with HBase shell just to make sure basic operations still work (e.g. crea