[GitHub] [hbase] ndimiduk commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-06-02 Thread GitBox
ndimiduk commented on pull request #1786: URL: https://github.com/apache/hbase/pull/1786#issuecomment-637734627 Thanks for review everyone. Good discussion! This is an automated message from the Apache Git Service. To

[GitHub] [hbase] ndimiduk commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-28 Thread GitBox
ndimiduk commented on pull request #1786: URL: https://github.com/apache/hbase/pull/1786#issuecomment-635688358 > Interesting. Wonder why the change was made. Looks like it was slipped in with https://issues.apache.org/jira/browse/HBASE-15065. There's some interesting comments as

[GitHub] [hbase] ndimiduk commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-27 Thread GitBox
ndimiduk commented on pull request #1786: URL: https://github.com/apache/hbase/pull/1786#issuecomment-634960241 > Generally, I think the default is too aggressive. @saintstack Looks liked we originally ran the normalizer on a 30min period. This was reduced to 5 min for 2.0,

[GitHub] [hbase] ndimiduk commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-26 Thread GitBox
ndimiduk commented on pull request #1786: URL: https://github.com/apache/hbase/pull/1786#issuecomment-634358652 I intend to backport this at least to branch-2.3. I think branch-2.2 needs some other patches before this would apply. PTAL, @saintstack @Apache9 @infraio @huaxiangsun