ndimiduk commented on pull request #3913:
URL: https://github.com/apache/hbase/pull/3913#issuecomment-998145153
@Apache9 if you'd like to try out spotless, please open a separate issue for
that. I think it looks promising.
In the mean time, what's wrong with the single line scoped
ndimiduk commented on pull request #3913:
URL: https://github.com/apache/hbase/pull/3913#issuecomment-996937315
> For me I do not like to have a left '{' and right '}' on the same line,
unless there is nothing inside the '{}'.
Oh interesting, so you prefer
```java
if (foo
ndimiduk commented on pull request #3913:
URL: https://github.com/apache/hbase/pull/3913#issuecomment-993063501
The `.editorconfig` has drifted from the checkstyle file, I'm not sure
why/how. Maybe a newer version of the IntelliJ or the IntelliJ Checkstyle
Plugin have changed how settings
ndimiduk commented on pull request #3913:
URL: https://github.com/apache/hbase/pull/3913#issuecomment-993021853
Eclipse should be using the formatting configuration that is committed to
the project, which was generated from checkstyle config. Actually,let me update
both configurations
ndimiduk commented on pull request #3913:
URL: https://github.com/apache/hbase/pull/3913#issuecomment-987009061
> For me I do not think it is a big deal to not allow single line if block,
just a reformat is enough? At least I know eclipse by default will format the
single line block to
ndimiduk commented on pull request #3913:
URL: https://github.com/apache/hbase/pull/3913#issuecomment-985726228
> I don't have strong opinion on the this single line statement, but I'm
wondered what standard we're following? e.g. myself always find [google's java
ndimiduk commented on pull request #3913:
URL: https://github.com/apache/hbase/pull/3913#issuecomment-985703248
> What's the problem on the current style check?
Sorry, I thought I left a reply, but apparently it didn't save.
This change allows for more compact single-line
