nkalmar commented on pull request #2308:
URL: https://github.com/apache/hbase/pull/2308#issuecomment-718901775
Why is this so flaky? Different 5 tests this time, only 1 test last time :(
This is an automated message from the
nkalmar commented on pull request #2308:
URL: https://github.com/apache/hbase/pull/2308#issuecomment-717826088
Different test failed than before, restarting build
This is an automated message from the Apache Git Service.
To
nkalmar commented on pull request #2308:
URL: https://github.com/apache/hbase/pull/2308#issuecomment-713414274
Thanks Sean, added back the indentation level, makes sense to leave it in,
it is also there by default.
This is
nkalmar commented on pull request #2308:
URL: https://github.com/apache/hbase/pull/2308#issuecomment-708330789
I rebased as bootstrapping changed. While I was force pushing anyway I
pushed the 2 commits into 1.
I changed prompt as talked, for example after issuing 2 commands this is
nkalmar commented on pull request #2308:
URL: https://github.com/apache/hbase/pull/2308#issuecomment-705494972
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
nkalmar commented on pull request #2308:
URL: https://github.com/apache/hbase/pull/2308#issuecomment-706086820
I could not find out what %i means exactly... Docs contains
"%N(%m):%03n:%i>" as the default, but does not go into detail what are the
values. I found an article explaining them,
nkalmar commented on pull request #2308:
URL: https://github.com/apache/hbase/pull/2308#issuecomment-705638394
Okay, I set the session name back to main. But I cheated. Basically I
hardcoded the session name to be main. Is this ok? with the patch it changed
how it gets the session name.
nkalmar commented on pull request #2308:
URL: https://github.com/apache/hbase/pull/2308#issuecomment-705630401
I only found a way to change the format, I didn't see any way to give a name
myself. It gets it's workspace name from the underlying object. I don't know
why this changed from
nkalmar commented on pull request #2308:
URL: https://github.com/apache/hbase/pull/2308#issuecomment-705580405
I found a config that sets session name. It should have no impact on the
prompt, I tested with my usual process (create/list/put/scan commands). I
didn't see any issue.
nkalmar commented on pull request #2308:
URL: https://github.com/apache/hbase/pull/2308#issuecomment-705494972
No, I couldn't find why session name changed unfortunately. I found some
vague info that this prints top lvl class/instance. I think the solution is in
hirb.rb class where we
nkalmar commented on pull request #2308:
URL: https://github.com/apache/hbase/pull/2308#issuecomment-702636618
Isn't the pretty print because of HBASE-23930?
This is an automated message from the Apache Git Service.
To
nkalmar commented on pull request #2308:
URL: https://github.com/apache/hbase/pull/2308#issuecomment-702588102
Hi @joshelser , I found why it is pretty printed. It is strange, because it
is explicitly converted by this function:
```
def toLocalDateTime(millis)
instant =
nkalmar commented on pull request #2308:
URL: https://github.com/apache/hbase/pull/2308#issuecomment-696685975
Rebased to current master
This is an automated message from the Apache Git Service.
To respond to the message,
nkalmar commented on pull request #2308:
URL: https://github.com/apache/hbase/pull/2308#issuecomment-696685975
Rebased to current master
This is an automated message from the Apache Git Service.
To respond to the message,
nkalmar commented on pull request #2308:
URL: https://github.com/apache/hbase/pull/2308#issuecomment-693518601
Hi @joshelser , yes I did test shell on my local machine, but just for a
sanity check, I tested again.
- Built master with this commit on top (mvn clean install -DskipTests
15 matches
Mail list logo