[GitHub] [hbase] nyl3532016 commented on pull request #2437: HBASE-25053 WAL replay should ignore 0-length files

2020-10-18 Thread GitBox
nyl3532016 commented on pull request #2437: URL: https://github.com/apache/hbase/pull/2437#issuecomment-711472666 > @Apache9 @saintstack This PR can be merged and closed? @saintstack please have a look, thanks This is

[GitHub] [hbase] nyl3532016 commented on pull request #2437: HBASE-25053 WAL replay should ignore 0-length files

2020-10-10 Thread GitBox
nyl3532016 commented on pull request #2437: URL: https://github.com/apache/hbase/pull/2437#issuecomment-706548263 @Apache9 @saintstack This PR can be merged and closed? This is an automated message from the Apache Git

[GitHub] [hbase] nyl3532016 commented on pull request #2437: HBASE-25053 WAL replay should ignore 0-length files

2020-10-01 Thread GitBox
nyl3532016 commented on pull request #2437: URL: https://github.com/apache/hbase/pull/2437#issuecomment-702163306 > Files that have not been closed show as 0-length. I'm concerned looking at length will have us miss edits. Can you address my concern? Thanks. @saintstack as Duo

[GitHub] [hbase] nyl3532016 commented on pull request #2437: HBASE-25053 WAL replay should ignore 0-length files

2020-09-27 Thread GitBox
nyl3532016 commented on pull request #2437: URL: https://github.com/apache/hbase/pull/2437#issuecomment-699634693 > This is just a simple optimization or something related to correctness? > > I'm not sure whether at this step we have finished recoverLease for all the WAL files? I