saintstack commented on a change in pull request #1877:
URL: https://github.com/apache/hbase/pull/1877#discussion_r447166769
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
##########
@@ -474,6 +474,7 @@ protected boolean isMatchingRegionLocation(RegionStateNode
rsn) {
* it.
*/
private void assignRegions(MasterProcedureEnv env, List<RegionInfo> regions)
throws IOException {
+ LOG.info("=============assign " + regions);
Review comment:
Need this? Don't we have enough spew in log already around assign?
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZKConnectionRegistry.java
##########
@@ -161,7 +159,8 @@ private void
getMetaRegionLocation(CompletableFuture<RegionLocations> future,
LOG.warn("Meta region is in state " +
stateAndServerName.getFirst());
}
locs[DEFAULT_REPLICA_ID] = new HRegionLocation(
- getRegionInfoForDefaultReplica(FIRST_META_REGIONINFO),
stateAndServerName.getSecond());
+
RegionInfoBuilder.newBuilder(TableName.META_TABLE_NAME).setRegionId(1).build(),
Review comment:
I was thinking that when we allow split, that the first region would no
longer have a regionid of '1'. Rather, it would have the 'natural' number, the
hash, as user-space regions have. Old clients would keep referring to the old
region name w/ the replicaid of '1'... We use this fact figuring when to put up
the facade over hbase:meta for old clients to use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
