[GitHub] [hbase] saintstack commented on a change in pull request #2591: HBASE-24859: Optimize in-memory representation of HBase map reduce table splits

[GitBox]

saintstack commented on a change in pull request #2591:
URL: https://github.com/apache/hbase/pull/2591#discussion_r513179886



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
##########
@@ -323,7 +323,7 @@ public boolean nextKeyValue() throws IOException, 
InterruptedException {
       }
       List<InputSplit> splits = new ArrayList<>(1);
       long regionSize = 
sizeCalculator.getRegionSize(regLoc.getRegionInfo().getRegionName());
-      TableSplit split = new TableSplit(tableName, scan,
+      TableSplit split = new TableSplit(tableName,

Review comment:
       So, we do not pass the scan object and then we save a bunch of memory? 
The TableSplit doesn't carry around the heavy scan instance anymore? Is that 
it? Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org