[GitHub] [hbase] saintstack commented on a change in pull request #2884: HBASE-25512 May throw StringIndexOutOfBoundsException when construct illegal tablename error

[GitBox]

saintstack commented on a change in pull request #2884:
URL: https://github.com/apache/hbase/pull/2884#discussion_r558583937



##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/TableName.java
##########
@@ -192,16 +192,16 @@ public static void isLegalTableQualifierName(final byte[] 
qualifierName,
     if(end - start < 1) {
       throw new IllegalArgumentException(isSnapshot ? "Snapshot" : "Table" + " 
qualifier must not be empty");
     }
+    // Treat the bytes as UTF-8
+    String qualifierString = new String(

Review comment:
       nit: Why do this 'new String' instead of doing 
Bytes.toString(qualifierName, start, end - start) ?
   
   I fixed the summary.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org