[GitHub] [hbase] saintstack commented on pull request #2037: HBASE-24698 Turn OFF Canary WebUI as default

2020-07-17 Thread GitBox
saintstack commented on pull request #2037: URL: https://github.com/apache/hbase/pull/2037#issuecomment-660357609 Merged this. Shout if you not ok @Apache9 ... did 1/2 of what you asked ... other define not used. This is an

[GitHub] [hbase] saintstack commented on pull request #2037: HBASE-24698 Turn OFF Canary WebUI as default

2020-07-10 Thread GitBox
saintstack commented on pull request #2037: URL: https://github.com/apache/hbase/pull/2037#issuecomment-656756543 @Apache9 I was going to merge unless objection... I put back the define that is still used. This is an

[GitHub] [hbase] saintstack commented on pull request #2037: HBASE-24698 Turn OFF Canary WebUI as default

2020-07-09 Thread GitBox
saintstack commented on pull request #2037: URL: https://github.com/apache/hbase/pull/2037#issuecomment-656476438 Looks like tests passed: 13:23:36 | +1 | unit | 180m 33s | hbase-server in the patch passed. Couldn't push the update to here.