[GitHub] [hbase] saintstack commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-03-18 Thread GitBox
saintstack commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-802224481 Is the complaint that thrift 0.13 has been compiled w/ jdk8? There is white space complaints, the javadoc WARNINGs we can ignore since they are in generated code, can

[GitHub] [hbase] saintstack commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-02-08 Thread GitBox
saintstack commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-775671930 > While we update the thrift version from 0.98 to 0.13.0, which needs java version at least 52, this will lead to the javadoc failures Where does the update from 0.98