[GitHub] [hbase] saintstack commented on pull request #3184: HBASE-25792 Filter out o.a.hadoop.thirdparty building shaded jars

2021-04-27 Thread GitBox
saintstack commented on pull request #3184: URL: https://github.com/apache/hbase/pull/3184#issuecomment-827704453 Thanks for taking a look @jojochuang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] saintstack commented on pull request #3184: HBASE-25792 Filter out o.a.hadoop.thirdparty building shaded jars

2021-04-26 Thread GitBox
saintstack commented on pull request #3184: URL: https://github.com/apache/hbase/pull/3184#issuecomment-827080353 Thanks @Apache9 for excluding h18. Thanks for review @jojochuang . Seems like this patch ok by you as is? I can change it if wanted else need +1 to commit. -- This

[GitHub] [hbase] saintstack commented on pull request #3184: HBASE-25792 Filter out o.a.hadoop.thirdparty building shaded jars

2021-04-21 Thread GitBox
saintstack commented on pull request #3184: URL: https://github.com/apache/hbase/pull/3184#issuecomment-824211187 Rerun tests to see if related (they don't look so) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the