timoha commented on pull request #1826:
URL: https://github.com/apache/hbase/pull/1826#issuecomment-689901122
yup, the approach wasn't suitable enough to address the issue and I wasn't
planning to improve it further, so I'll leave it to be properly addressed by
hbase team
timoha commented on pull request #1826:
URL: https://github.com/apache/hbase/pull/1826#issuecomment-654381936
Looks like operator intervention is needed for this issue :)
> I for one do not look at TaskMonitor figuring state of Procedures. Do
others? Thanks.
Just from my
timoha commented on pull request #1826:
URL: https://github.com/apache/hbase/pull/1826#issuecomment-639009293
I'll let others also comment before submitting a patch. I personally prefer
for de-serialize to not have side effects all the way to what shows in the UI
and also like removing
timoha commented on pull request #1826:
URL: https://github.com/apache/hbase/pull/1826#issuecomment-638533674
That's a good point @Apache9, I guess it would add sort of "continuity" to
show that the task is still ongoing during master failover in case the
procedure hasn't actually
timoha commented on pull request #1826:
URL: https://github.com/apache/hbase/pull/1826#issuecomment-637745870
Thanks for suggestion @Apache9, but I don't think that's going to work for
the case of state being `SERVER_CRASH_FINISH`. With such code change,
`executeFromState` will end up
