virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-589948906
> I think the patch looks in a decent shape after the refactor.. There are
some minor comments I posted...
>
> Also, few things you
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-586820503
@ndimiduk if you have time today, please review
This is an automated message
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-586575972
Using thread-safe wrapper over EvictingQueue makes life simpler, however it
does not have any perf improvement because earlier I was using lock
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-586385701
Failed tests in recent build are passing locally, not relevant to the PR
changes
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-586127846
> No, I do not thing it's good to maintain uniform print format across all
client. Anything that is providing display functionality for an object
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-585829397
> Thanks for addressing all my concerns so far @virajjasani . I've tried to
resolve all the inline discussions. Here's a summary of what I think
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-584788210
> > > 1. Since the detailed info is going through this ring buffer
subsystem, why do we continue to log at all? Why not replace the logging with
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-582723753
Please review @ndimiduk
This is an automated message from the Apache Git
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-581747580
@saintstack I will start creating necessary sub-tasks to this. For now,
having ring buffer might be a good addition to 2.3.0 release for
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-579605235
> I think you misunderstood me here...
>
> "With the patch we would run at RS entrance only and for any slow running
query it will go to
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-579541178
@ndimiduk @saintstack Would you be able to spend some time for review
today?(I am available today) If not, I can work on this after 2/3 days.
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-579162619
> A couple high-level questions:
>
> 1. Since the detailed info is going through this ring buffer subsystem,
why do we continue to log at
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-579052854
> I sent a note to dev@ giving a status update. If you don’t find there what
you need, or have some comments, please reply on that thread.
>
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-579025766
Thanks for the review @ndimiduk
I will try to be on top of this. Could you please let me know if you have
any estimate of 2.3.0 release? May
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-577086481
Pushed new commit, rebased, we have new QA results available too. Please
take a look @saintstack
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-576961336
> Skimmed.
>
> One thought was that we'd want to run a buffer at the RS entrance too, not
just at the point where we interact with HDFS.
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-565830334
Please review @xcangCRM
This is an automated message from the Apache Git
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-564146946
Please review @ramkrish86
This is an automated message from the Apache Git
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-559696527
@guangxuCheng Could you please review?
This is an automated message from the
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-557908675
Please review @anoopsjohn @saintstack
This is an automated message from the
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-555150670
Please review @apurtell @busbey @guangxuCheng
This is an automated message from
virajjasani commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-546956454
Requesting your reviews @apurtell @busbey
This is an automated message from the
22 matches
Mail list logo
