[GitHub] [hbase] wchevreuil commented on issue #712: HBASE-23136

2019-10-18 Thread GitBox
wchevreuil commented on issue #712: HBASE-23136 URL: https://github.com/apache/hbase/pull/712#issuecomment-543585550 Thanks @joshelser , the test failure seems unrelated. Had pushed another commit addressing the reported checkstyle issues. I will wait for the pre-commit results, if all

[GitHub] [hbase] wchevreuil commented on issue #712: HBASE-23136

2019-10-12 Thread GitBox
wchevreuil commented on issue #712: HBASE-23136 URL: https://github.com/apache/hbase/pull/712#issuecomment-541341267 Thanks for the comments @joshelser ! Had pushed new commit addressing most of it. Oddly, noticed the pre-commit job has not been triggered for this PR. Any ideas? Also, let