[GitHub] [hbase] z-york commented on issue #229: HBASE-22389 Revert "HBASE-19275 TestSnapshotFileCache never worked pr…

2019-05-09 Thread GitBox
z-york commented on issue #229: HBASE-22389 Revert "HBASE-19275 TestSnapshotFileCache never worked pr… URL: https://github.com/apache/hbase/pull/229#issuecomment-491110739 Reran TestSnapshotFileCache after #230 and confirmed it passes now. Fixed checkstyle.

[GitHub] [hbase] z-york commented on issue #229: HBASE-22389 Revert "HBASE-19275 TestSnapshotFileCache never worked pr…

2019-05-09 Thread GitBox
z-york commented on issue #229: HBASE-22389 Revert "HBASE-19275 TestSnapshotFileCache never worked pr… URL: https://github.com/apache/hbase/pull/229#issuecomment-491035742 https://github.com/apache/hbase/pull/230 should be merged first since it will cause test failures otherwise (as

[GitHub] [hbase] z-york commented on issue #229: HBASE-22389 Revert "HBASE-19275 TestSnapshotFileCache never worked pr…

2019-05-09 Thread GitBox
z-york commented on issue #229: HBASE-22389 Revert "HBASE-19275 TestSnapshotFileCache never worked pr… URL: https://github.com/apache/hbase/pull/229#issuecomment-491029923 Note this will actually cause the new test added in HBASE-21070 in TestSnapshotFileCache to fail until HBASE-22190 is