phrocker commented on a change in pull request #2:
URL: https://github.com/apache/hbase-native-client/pull/2#discussion_r432795101
##
File path: cmake/DownloadFolly.cmake
##
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
phrocker commented on a change in pull request #2:
URL: https://github.com/apache/hbase-native-client/pull/2#discussion_r430331425
##
File path: cmake/DownloadFolly.cmake
##
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
phrocker commented on a change in pull request #2:
URL: https://github.com/apache/hbase-native-client/pull/2#discussion_r429177939
##
File path: cmake/DownloadFolly.cmake
##
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
phrocker commented on a change in pull request #2:
URL: https://github.com/apache/hbase-native-client/pull/2#discussion_r429177939
##
File path: cmake/DownloadFolly.cmake
##
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
phrocker commented on a change in pull request #2:
URL: https://github.com/apache/hbase-native-client/pull/2#discussion_r429166593
##
File path: cmake/DownloadFolly.cmake
##
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
phrocker commented on a change in pull request #2:
URL: https://github.com/apache/hbase-native-client/pull/2#discussion_r429166593
##
File path: cmake/DownloadFolly.cmake
##
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
phrocker commented on a change in pull request #2:
URL: https://github.com/apache/hbase-native-client/pull/2#discussion_r429160017
##
File path: cmake/DownloadFizz.cmake
##
@@ -0,0 +1,41 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
phrocker commented on a change in pull request #2:
URL: https://github.com/apache/hbase-native-client/pull/2#discussion_r428980914
##
File path: NOTICE
##
@@ -0,0 +1,15 @@
+Apache HBase
+Copyright 2019 The Apache Software Foundation
Review comment:
ha!
phrocker commented on a change in pull request #2:
URL: https://github.com/apache/hbase-native-client/pull/2#discussion_r428779148
##
File path: cmake/patches/zookeeper.3.4.14.buf
##
@@ -0,0 +1,3767 @@
+/**
Review comment:
This is a patch file. I should shorten this to
phrocker commented on a change in pull request #2:
URL: https://github.com/apache/hbase-native-client/pull/2#discussion_r428778571
##
File path: cmake/BuildTests.cmake
##
@@ -48,10 +48,13 @@ function(createTests testName)
target_include_directories(${testName} PRIVATE
10 matches
Mail list logo