[GitHub] [hbase-native-client] phrocker commented on pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

2020-08-16 Thread GitBox
phrocker commented on pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#issuecomment-674583369 @bharathv I relied on CI to run docker for me. that appears to be the issue. xenial doesn't have libfmt-dev -- so I'll have to download that manually or add it to the

[GitHub] [hbase-native-client] phrocker commented on pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

2020-08-15 Thread GitBox
phrocker commented on pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#issuecomment-674463431 @bharathv thanks! I saw something about whitespace. Probably hygiene. Will address! This is an

[GitHub] [hbase-native-client] phrocker commented on pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

2020-08-15 Thread GitBox
phrocker commented on pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#issuecomment-674384634 > > > @phrocker Sounds good, will take a look. Sounds good. I had issues fixing the boost build problems. I think the issues may be linking in folly but

[GitHub] [hbase-native-client] phrocker commented on pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

2020-08-14 Thread GitBox
phrocker commented on pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#issuecomment-674104314 @bharathv Sorry for the delay. I'm rebasing and rebuilding. ran into some issues with boost so I'll correct those then push them up . Thanks!

[GitHub] [hbase-native-client] phrocker commented on pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

2020-07-09 Thread GitBox
phrocker commented on pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#issuecomment-656339614 > > > Had a chance to apply your patch locally and try it out, running into this weird linker issue. > > > >

[GitHub] [hbase-native-client] phrocker commented on pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

2020-07-09 Thread GitBox
phrocker commented on pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#issuecomment-656187689 > > Had a chance to apply your patch locally and try it out, running into this weird linker issue. > > >

[GitHub] [hbase-native-client] phrocker commented on pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

2020-07-07 Thread GitBox
phrocker commented on pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#issuecomment-654886206 > Had a chance to apply your patch locally and try it out, running into this weird linker issue. > > >

[GitHub] [hbase-native-client] phrocker commented on pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

2020-06-22 Thread GitBox
phrocker commented on pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#issuecomment-647831826 @bharathv Thanks. making some changes now to download double conversion and gsasl2. will mark as ready for review after. thanks!