[GitHub] [hbase-thirdparty] Apache9 commented on pull request #22: HBASE-19256 [hbase-thirdparty] shade jetty

2020-07-29 Thread GitBox
Apache9 commented on pull request #22: URL: https://github.com/apache/hbase-thirdparty/pull/22#issuecomment-664729832 > Glancing at the jars, I see some ServiceLoader entries in both the jetty and jersey jars. I _think_ this would break, if we happen to use it, given the entry in the jar

[GitHub] [hbase-thirdparty] Apache9 commented on pull request #22: HBASE-19256 [hbase-thirdparty] shade jetty

2020-07-25 Thread GitBox
Apache9 commented on pull request #22: URL: https://github.com/apache/hbase-thirdparty/pull/22#issuecomment-663836388 Any other problems? I think upgrade the version of jetty is trivial... This is an automated message from

[GitHub] [hbase-thirdparty] Apache9 commented on pull request #22: HBASE-19256 [hbase-thirdparty] shade jetty

2020-07-23 Thread GitBox
Apache9 commented on pull request #22: URL: https://github.com/apache/hbase-thirdparty/pull/22#issuecomment-663065833 Still need to take a look at the jersey part. We need to exclude the general API jar, just like what I have done for jetty, to exclude servlet-api. > [INFO]