Re: [PR] HBASE-25880 remove files from filesCompacting when clear compaction queue [hbase]

2024-05-14 Thread via GitHub
frostruan commented on PR #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-2109960909 > Thanks @frostruan. I don't have any other feedback here, I just saw that it stalled. > > If you have time to finish it, that'd be great. If not I can ask someone at my company

Re: [PR] HBASE-25880 remove files from filesCompacting when clear compaction queue [hbase]

2024-05-14 Thread via GitHub
bbeaudreault commented on PR #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-2109932196 Thanks @frostruan. I don't have any other feedback here, I just saw that it stalled. If you have time to finish it, that'd be great. If not I can ask someone at my company to

Re: [PR] HBASE-25880 remove files from filesCompacting when clear compaction queue [hbase]

2024-05-14 Thread via GitHub
frostruan commented on PR #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-2109777296 @bbeaudreault This PR has some conflicts with the master branch. I can fix PR if you need. And if you have new or more ideas, it's completely ok for me to close this PR and you can

Re: [PR] HBASE-25880 remove files from filesCompacting when clear compaction queue [hbase]

2024-05-13 Thread via GitHub
frostruan commented on PR #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-2109241221 We have this patch in our internal branch for a long time, and the effect is in line with expectations. So I think we can pick this up too. -- This is an automated message from the

Re: [PR] HBASE-25880 remove files from filesCompacting when clear compaction queue [hbase]

2024-05-13 Thread via GitHub
Apache9 commented on PR #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-2108018917 Have you faced this problem in your production? @bbeaudreault We can pick this up I think. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] HBASE-25880 remove files from filesCompacting when clear compaction queue [hbase]

2024-05-13 Thread via GitHub
bbeaudreault commented on PR #3261: URL: https://github.com/apache/hbase/pull/3261#issuecomment-2107770254 Can we pick this back up? This is actually a big issue. If you clear compaction queues, you're almost guaranteed to enter a case where new compactions for those regions cannot