apurtell merged PR #5780:
URL: https://github.com/apache/hbase/pull/5780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apurtell merged PR #5772:
URL: https://github.com/apache/hbase/pull/5772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apurtell commented on PR #5780:
URL: https://github.com/apache/hbase/pull/5780#issuecomment-2043644026
No further comments, going to merge. Thank you @mihir6692 for the
contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
apurtell commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2043644217
No further comments, going to merge. Thank you @mihir6692 for the
contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mihir6692 commented on code in PR #5772:
URL: https://github.com/apache/hbase/pull/5772#discussion_r1544893288
##
hbase-server/src/test/java/org/apache/hadoop/hbase/master/http/TestHbckMetricsResource.java:
##
@@ -0,0 +1,422 @@
+/*
+ * Licensed to the Apache Software Foundation
d-c-manning commented on code in PR #5772:
URL: https://github.com/apache/hbase/pull/5772#discussion_r1544692039
##
hbase-server/src/test/java/org/apache/hadoop/hbase/master/http/TestHbckMetricsResource.java:
##
@@ -0,0 +1,422 @@
+/*
+ * Licensed to the Apache Software
mihir6692 commented on PR #5780:
URL: https://github.com/apache/hbase/pull/5780#issuecomment-2021921186
Test failure in `TestBlockEvictionOnRegionMovement` is not related. I ran
this test multiple times in local and it doesn't fail.
--
This is an automated message from the Apache Git
Apache-HBase commented on PR #5780:
URL: https://github.com/apache/hbase/pull/5780#issuecomment-2021802269
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
Apache-HBase commented on PR #5780:
URL: https://github.com/apache/hbase/pull/5780#issuecomment-2021800157
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5780:
URL: https://github.com/apache/hbase/pull/5780#issuecomment-2021603545
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
mihir6692 commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2021561414
PR for branch-2 and branch-2.x https://github.com/apache/hbase/pull/5780
(It only required one manual change, using
`org.apache.hadoop.hbase.StartMiniClusterOption` in branch-2 in
mihir6692 commented on code in PR #5772:
URL: https://github.com/apache/hbase/pull/5772#discussion_r1540072864
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/http/hbck/resource/HbckMetricsResource.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software
apurtell commented on code in PR #5772:
URL: https://github.com/apache/hbase/pull/5772#discussion_r1539849184
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/http/hbck/resource/HbckMetricsResource.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software
apurtell commented on code in PR #5772:
URL: https://github.com/apache/hbase/pull/5772#discussion_r1539849184
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/http/hbck/resource/HbckMetricsResource.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software
apurtell commented on code in PR #5772:
URL: https://github.com/apache/hbase/pull/5772#discussion_r1539847142
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/http/hbck/HbckConfigFactory.java:
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation
apurtell closed pull request #4470: HBASE-26192 Master UI hbck should provide a
JSON formatted output option
URL: https://github.com/apache/hbase/pull/4470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2018987203
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2018973711
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 27s |
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2018954446
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2018608695
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2016423792
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2016379192
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2016373802
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2016322684
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2016313766
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2016303737
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2016301167
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 14s |
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2016016598
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
mihir6692 commented on code in PR #5772:
URL: https://github.com/apache/hbase/pull/5772#discussion_r1536258156
##
hbase-server/src/test/java/org/apache/hadoop/hbase/master/http/TestHbckMetricsResource.java:
##
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2015690523
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 50s |
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2015672063
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 54s |
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2015479311
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s |
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2015063280
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2014990855
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2014963305
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2014944699
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
mihir6692 commented on code in PR #5772:
URL: https://github.com/apache/hbase/pull/5772#discussion_r1535456588
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/http/hbck/resource/HbckMetricsResource.java:
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2014629430
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2014583486
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2014567161
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2014532990
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
ranganathg commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2014466500
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ranganathg commented on code in PR #5772:
URL: https://github.com/apache/hbase/pull/5772#discussion_r1535124490
##
hbase-server/src/test/java/org/apache/hadoop/hbase/master/http/TestHbckMetricsResource.java:
##
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software
ranganathg commented on code in PR #5772:
URL: https://github.com/apache/hbase/pull/5772#discussion_r1535120524
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/http/hbck/resource/HbckMetricsResource.java:
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software
ranganathg commented on code in PR #5772:
URL: https://github.com/apache/hbase/pull/5772#discussion_r1535096103
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/http/hbck/model/HbckOverlapRegions.java:
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software
mihir6692 commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2014346223
Here is Sample Output for `/hbck/hbck_metrics` call
```
{
"data": {
"hbck_report_start_time": 1711082593359,
"hbck_report_end_time": 1711082593924,
Apache-HBase commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2014338929
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
mihir6692 commented on PR #5772:
URL: https://github.com/apache/hbase/pull/5772#issuecomment-2014309924
Hi @virajjasani @apurtell @ndimiduk
Can I get review on this JIRA? (I have tried to include all the comments
mentioned the PR https://github.com/apache/hbase/pull/4470 )
--
ranganathg commented on code in PR #4470:
URL: https://github.com/apache/hbase/pull/4470#discussion_r1430907596
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/http/MasterHbckServlet.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation
ranganathg commented on code in PR #4470:
URL: https://github.com/apache/hbase/pull/4470#discussion_r1430905636
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/http/MasterHbckServlet.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation
ranganathg commented on code in PR #4470:
URL: https://github.com/apache/hbase/pull/4470#discussion_r1430902296
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/http/MasterHbckServlet.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation
51 matches
Mail list logo
