Re: [PR] HBASE-28135 Specify -Xms for tests [hbase]

2023-10-12 Thread via GitHub
petersomogyi merged PR #5451: URL: https://github.com/apache/hbase/pull/5451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28135 Specify -Xms for tests [hbase]

2023-10-11 Thread via GitHub
Apache-HBase commented on PR #5451: URL: https://github.com/apache/hbase/pull/5451#issuecomment-1758600725 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28135 Specify -Xms for tests [hbase]

2023-10-11 Thread via GitHub
Apache-HBase commented on PR #5451: URL: https://github.com/apache/hbase/pull/5451#issuecomment-1758430763 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28135 Specify -Xms for tests [hbase]

2023-10-11 Thread via GitHub
Apache-HBase commented on PR #5451: URL: https://github.com/apache/hbase/pull/5451#issuecomment-1757917655 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

Re: [PR] HBASE-28135 Specify -Xms for tests [hbase]

2023-10-11 Thread via GitHub
stoty commented on PR #5451: URL: https://github.com/apache/hbase/pull/5451#issuecomment-1757822957 You are right, the variable substitutions were missing the dollar sign. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] HBASE-28135 Specify -Xms for tests [hbase]

2023-10-11 Thread via GitHub
petersomogyi commented on PR #5451: URL: https://github.com/apache/hbase/pull/5451#issuecomment-1757685692 The pre-commit checks timed out for the second and third builds. Only the general checks completed which do not trigger unit tests. -- This is an automated message from the Apache

Re: [PR] HBASE-28135 Specify -Xms for tests [hbase]

2023-10-10 Thread via GitHub
Apache-HBase commented on PR #5451: URL: https://github.com/apache/hbase/pull/5451#issuecomment-1755167975 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28135 Specify -Xms for tests [hbase]

2023-10-06 Thread via GitHub
Apache-HBase commented on PR #5451: URL: https://github.com/apache/hbase/pull/5451#issuecomment-1750877799 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28135 Specify -Xms for tests [hbase]

2023-10-06 Thread via GitHub
Apache-HBase commented on PR #5451: URL: https://github.com/apache/hbase/pull/5451#issuecomment-1750783003 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-28135 Specify -Xms for tests [hbase]

2023-10-06 Thread via GitHub
stoty commented on PR #5451: URL: https://github.com/apache/hbase/pull/5451#issuecomment-1750558786 Sure, I have added the property. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] HBASE-28135 Specify -Xms for tests [hbase]

2023-10-06 Thread via GitHub
Apache9 commented on PR #5451: URL: https://github.com/apache/hbase/pull/5451#issuecomment-1750399585 Can we use surefire.Xms instead of a hard coded one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] HBASE-28135 Specify -Xms for tests [hbase]

2023-10-06 Thread via GitHub
Apache-HBase commented on PR #5451: URL: https://github.com/apache/hbase/pull/5451#issuecomment-1750188392 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s |

Re: [PR] HBASE-28135 Specify -Xms for tests [hbase]

2023-10-06 Thread via GitHub
Apache-HBase commented on PR #5451: URL: https://github.com/apache/hbase/pull/5451#issuecomment-1750160972 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

[PR] HBASE-28135 Specify -Xms for tests [hbase]

2023-10-06 Thread via GitHub
stoty opened a new pull request, #5451: URL: https://github.com/apache/hbase/pull/5451 Change-Id: I45a17ac34b12aa00a04341413ac01dc70e5f328b -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the