Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-23 Thread via GitHub
Apache9 merged PR #5461: URL: https://github.com/apache/hbase/pull/5461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-20 Thread via GitHub
Apache-HBase commented on PR #5461: URL: https://github.com/apache/hbase/pull/5461#issuecomment-1773109359 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 15s |

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-20 Thread via GitHub
Apache-HBase commented on PR #5461: URL: https://github.com/apache/hbase/pull/5461#issuecomment-1773107446 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-20 Thread via GitHub
Apache-HBase commented on PR #5461: URL: https://github.com/apache/hbase/pull/5461#issuecomment-1772788494 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-20 Thread via GitHub
rmdmattingly commented on code in PR #5461: URL: https://github.com/apache/hbase/pull/5461#discussion_r1366967976 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -716,18 +707,13 @@ public static void

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-20 Thread via GitHub
bbeaudreault commented on code in PR #5461: URL: https://github.com/apache/hbase/pull/5461#discussion_r1366957817 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -716,18 +707,13 @@ public static void

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-18 Thread via GitHub
Apache-HBase commented on PR #5461: URL: https://github.com/apache/hbase/pull/5461#issuecomment-1769515968 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 18s |

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-18 Thread via GitHub
Apache-HBase commented on PR #5461: URL: https://github.com/apache/hbase/pull/5461#issuecomment-1769514336 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-18 Thread via GitHub
Apache-HBase commented on PR #5461: URL: https://github.com/apache/hbase/pull/5461#issuecomment-1769188855 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-16 Thread via GitHub
Apache9 commented on code in PR #5461: URL: https://github.com/apache/hbase/pull/5461#discussion_r1360664367 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -718,14 +720,19 @@ public static void

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-16 Thread via GitHub
rmdmattingly commented on code in PR #5461: URL: https://github.com/apache/hbase/pull/5461#discussion_r1360631177 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -718,14 +720,19 @@ public static void

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-12 Thread via GitHub
Apache-HBase commented on PR #5461: URL: https://github.com/apache/hbase/pull/5461#issuecomment-1760443461 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-12 Thread via GitHub
Apache-HBase commented on PR #5461: URL: https://github.com/apache/hbase/pull/5461#issuecomment-1760409599 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 15s |

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-12 Thread via GitHub
Apache-HBase commented on PR #5461: URL: https://github.com/apache/hbase/pull/5461#issuecomment-1760163936 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-12 Thread via GitHub
Apache-HBase commented on PR #5461: URL: https://github.com/apache/hbase/pull/5461#issuecomment-1760103112 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 15s |

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-12 Thread via GitHub
Apache-HBase commented on PR #5461: URL: https://github.com/apache/hbase/pull/5461#issuecomment-1760098522 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-12 Thread via GitHub
bbeaudreault commented on code in PR #5461: URL: https://github.com/apache/hbase/pull/5461#discussion_r1356965047 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -718,14 +720,19 @@ public static void

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-12 Thread via GitHub
Apache-HBase commented on PR #5461: URL: https://github.com/apache/hbase/pull/5461#issuecomment-1759751872 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 49s |

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-12 Thread via GitHub
rmdmattingly commented on code in PR #5461: URL: https://github.com/apache/hbase/pull/5461#discussion_r1356892819 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -718,14 +720,19 @@ public static void

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-12 Thread via GitHub
Apache9 commented on code in PR #5461: URL: https://github.com/apache/hbase/pull/5461#discussion_r1356884191 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -718,14 +720,19 @@ public static void

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-12 Thread via GitHub
Apache9 commented on code in PR #5461: URL: https://github.com/apache/hbase/pull/5461#discussion_r1356835441 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -128,7 +128,8 @@ public class ServerManager { * Map of admin interfaces per

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-12 Thread via GitHub
Apache9 commented on PR #5461: URL: https://github.com/apache/hbase/pull/5461#issuecomment-1759622141 Ah, OK, we change to use async connection for master and branch-3... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-12 Thread via GitHub
bbeaudreault commented on PR #5461: URL: https://github.com/apache/hbase/pull/5461#issuecomment-1759553079 > This problem only affects 2.x? Master and branch-3 are safe? It looks like master was fixed via your commit

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-12 Thread via GitHub
Apache9 commented on PR #5461: URL: https://github.com/apache/hbase/pull/5461#issuecomment-1759028250 This problem only affects 2.x? Master and branch-3 are safe? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-11 Thread via GitHub
Apache-HBase commented on PR #5461: URL: https://github.com/apache/hbase/pull/5461#issuecomment-1758146440 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 16s |

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-11 Thread via GitHub
Apache-HBase commented on PR #5461: URL: https://github.com/apache/hbase/pull/5461#issuecomment-1758144320 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-11 Thread via GitHub
Apache-HBase commented on PR #5461: URL: https://github.com/apache/hbase/pull/5461#issuecomment-1757766376 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

[PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-11 Thread via GitHub
rmdmattingly opened a new pull request, #5461: URL: https://github.com/apache/hbase/pull/5461 On 2.x [the ServerManager registers admins in a HashMap](https://github.com/apache/hbase/blob/branch-2/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java). This can